From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Adam Richter Newsgroups: gmane.emacs.devel Subject: Untested patch for trivial memory leak in update-game-score.c Date: Tue, 30 Apr 2019 14:21:56 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000042d7f20587c5fef2" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="237222"; mail-complaints-to="usenet@blaine.gmane.org" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 30 23:22:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLaCj-000zZ3-Cn for ged-emacs-devel@m.gmane.org; Tue, 30 Apr 2019 23:22:21 +0200 Original-Received: from localhost ([127.0.0.1]:53711 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLaCi-0004Z0-EE for ged-emacs-devel@m.gmane.org; Tue, 30 Apr 2019 17:22:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLaCa-0004Xt-BP for emacs-devel@gnu.org; Tue, 30 Apr 2019 17:22:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLaCZ-0004uL-EY for emacs-devel@gnu.org; Tue, 30 Apr 2019 17:22:12 -0400 Original-Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]:45822) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLaCZ-0004tZ-6c for emacs-devel@gnu.org; Tue, 30 Apr 2019 17:22:11 -0400 Original-Received: by mail-vk1-xa30.google.com with SMTP id h127so3442001vkd.12 for ; Tue, 30 Apr 2019 14:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=jFja9IIIg/iwF3KRpJQ/V8+cIScyEpo5BStKppoSvcQ=; b=IPmOjxjTjG7j9/+TSenMQs1MaoJgbDhybWB8r4Ey+LzYv9MQNDirNE7ZwU6bw063jE 1Gg0ZaMxjFRCSM8iKxuMOiJ8eZWzxCiOkiYT61emraxkgQC2RGKO4/fVkoMQVedz2sZ/ jjyDrR5g2VH7MKhfGsUMu/DCibO3NTSzPHyf4J0Vbi5cXtaTwErNQuN2tczULsZGIyhC /KuCqabP9S5qTFOs5MY48lKkg0WSIHWZQ2clrLydPRy9zjXegwmDoE+G41ii9R5kEpBQ uhnpfZexyZS1nqRkwdvIEmL9iDZOtaXnK3AhpQh5nO4lZcpLP+6SO36T4pCs8Y85yQAt 63XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=jFja9IIIg/iwF3KRpJQ/V8+cIScyEpo5BStKppoSvcQ=; b=jDJLZZHqq3n3R8NcVW6UGbmTn6X9Dpam0pEkfnU4t/JGNhxMvWa9runJYQSh8avNjV MdvSGoh9/f27MoAfB2sDe6YR8s75VAsSNitFPJ2PeIQfW4++q+aA34wClVSXAG5L/cNu cJH58UBOu5bXYAPygOISOpg9ww2dr8VnbW03m2FtyPbHmaoHQyFZHqWVxN3d+KNYeeb/ 7uvDyY0t//e5KawZKPoeAXKPEJWsibHc47gHdMK2kPNf5MQKZIRRT1tUVYvU0z86WwQ4 +w++gesnVzEcoCfzg9YaGsqlzjubV9DNQPpPy4evIf1/owBPSnJSzTT071ccbNHkAw2C x+Yg== X-Gm-Message-State: APjAAAXT/lDJNv/I4G9ccZR7SozCSzuJCgnrlVT3MTdLzisrDjaPCJfP vumo1AW4SjWdNlL3tYIlUnA7mdcZh5ZtQQIYYlSIFYTI X-Google-Smtp-Source: APXvYqzSNe7hEpemc42uldMN7q/Ce8daf3iJIqQZAuvVKV2ccqKSAYs313J9zZkpt1pPxWa2fEJ1Bzd85DOobbTaNNs= X-Received: by 2002:a1f:c009:: with SMTP id q9mr37411979vkf.85.1556659327639; Tue, 30 Apr 2019 14:22:07 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::a30 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236075 Archived-At: --00000000000042d7f20587c5fef2 Content-Type: text/plain; charset="UTF-8" Hi, everyone. Attached is a patch to update-games-score.c for trivial memory leaks found by cppcheck. In the hopes of expediting integration, I hereby release my interest in this patch into the public domain. As far as I can tell, update-game-score.c is not compiled when I build emacs, so the purpose of this patch might mostly be to clean up cppcheck output, but I did compile my modified version of the file manually, and gcc -Wall had no complaints, although gcc -Wextra complained about some signed/unsigned comparisons and unlock_file() ignoring its filename parameter. Thanks in advance for considering this patch. Adam --00000000000042d7f20587c5fef2 Content-Type: text/x-diff; charset="US-ASCII"; name="emacs.update-games-score.diff" Content-Disposition: attachment; filename="emacs.update-games-score.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jv488lxt0 LS0tIGxpYi1zcmMvdXBkYXRlLWdhbWUtc2NvcmUuYy5vcmlnCTIwMTktMDEtMDcgMDY6MjY6MDYu MDAwMDAwMDAwIC0wODAwCisrKyBsaWItc3JjL3VwZGF0ZS1nYW1lLXNjb3JlLmMJMjAxOS0wNC0z MCAxMjozNDoyMy40NTk5ODYxMzQgLTA3MDAKQEAgLTMyNSwxNiArMzI1LDIxIEBAIHJlYWRfc2Nv cmVzIChjb25zdCBjaGFyICpmaWxlbmFtZSwgc3RydWMKICAgbnJlYWQgPSBmcmVhZCAoZmlsZWRh dGEsIDEsIGZpbGVzaXplICsgMSwgZik7CiAgIGlmIChmaWxlc2l6ZSA8IG5yZWFkKQogICAgIHsK KyAgICAgIGZyZWUgKGZpbGVkYXRhKTsKICAgICAgIGVycm5vID0gMDsKICAgICAgIHJldHVybiAt MTsKICAgICB9CiAgIGlmIChucmVhZCA8IGZpbGVzaXplKQogICAgIGZpbGVzaXplID0gbnJlYWQ7 CiAgIGlmIChmZXJyb3IgKGYpIHx8IGZjbG9zZSAoZikgIT0gMCkKLSAgICByZXR1cm4gLTE7Cisg ICAgeworICAgICAgZnJlZSAoZmlsZWRhdGEpOworICAgICAgcmV0dXJuIC0xOworICAgIH0KICAg ZmlsZWRhdGFbZmlsZXNpemVdID0gMDsKICAgaWYgKHN0cmxlbiAoZmlsZWRhdGEpICE9IGZpbGVz aXplKQogICAgIHsKKyAgICAgIGZyZWUgKGZpbGVkYXRhKTsKICAgICAgIGVycm5vID0gMDsKICAg ICAgIHJldHVybiAtMTsKICAgICB9Cg== --00000000000042d7f20587c5fef2--