all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Karl Otness <karl@karlotness.com>
To: Daniel Colascione <dancol@dancol.org>
Cc: 34114@debbugs.gnu.org
Subject: bug#34114: 27.0.50: pdumper and themes with Emacs daemon
Date: Sat, 19 Jan 2019 00:09:18 +0000	[thread overview]
Message-ID: <CAGk_8XLy8cGmTtWDzmuMrK6_H7iJon68yQQQ2MX7i3gV2D8_WQ@mail.gmail.com> (raw)
In-Reply-To: <78748460-d8a4-47fb-8eec-cd97b1fdc0e2@email.android.com>

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

I might have exhausted those limits as well with a few other changes.
I've prepared and attached a patch that makes the change I described
above, but I'm not sure if it can be installed as-is without the
copyright paperwork.

Thanks,
Karl


On Fri, Jan 18, 2019 at 11:50 PM Daniel Colascione <dancol@dancol.org> wrote:
>
> Should fall under the de minimus exception to paperwork requirements

[-- Attachment #2: 0001-Initialize-faces-in-daemon-mode-with-pdumper-Bug-341.patch --]
[-- Type: text/x-patch, Size: 1171 bytes --]

From 6c85063851f83e51532013a354c0f1ce329d070a Mon Sep 17 00:00:00 2001
From: Karl Otness <karl@karlotness.com>
Date: Fri, 18 Jan 2019 23:56:44 +0000
Subject: [PATCH] Initialize faces in daemon mode with pdumper (Bug#34114)

* src/dispnew.c (init_display_interactive): Call init_faces_initial
in daemon mode.
---
 src/dispnew.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/dispnew.c b/src/dispnew.c
index 88783cd5da..226f4731cd 100644
--- a/src/dispnew.c
+++ b/src/dispnew.c
@@ -6033,6 +6033,10 @@ init_display_interactive (void)
     }
 #endif /* SIGWINCH */
 
+  /* Set up faces of the initial terminal frame.  */
+  if (!noninteractive && NILP (Vinitial_window_system))
+    init_faces_initial ();
+
   /* If running as a daemon, no need to initialize any frames/terminal,
      except on Windows, where we at least want to initialize it.  */
 #ifndef WINDOWSNT
@@ -6176,10 +6180,6 @@ init_display_interactive (void)
   }
 
   calculate_costs (XFRAME (selected_frame));
-
-  /* Set up faces of the initial terminal frame.  */
-  if (!noninteractive && NILP (Vinitial_window_system))
-    init_faces_initial ();
 }
 
 void
-- 
2.20.1


  reply	other threads:[~2019-01-19  0:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 11:15 bug#34114: 27.0.50: pdumper and themes with Emacs daemon Karl Otness
2019-01-17 20:01 ` Kaushal Modi
2019-01-17 20:38   ` Kaushal Modi
2019-01-18 23:02     ` Karl Otness
2019-01-18 23:23       ` Daniel Colascione
2019-01-18 23:37         ` Karl Otness
2019-01-18 23:49           ` Daniel Colascione
2019-01-19  0:09             ` Karl Otness [this message]
2019-01-19  7:05       ` Eli Zaretskii
2019-01-21 22:59         ` Daniel Colascione
2019-01-22 16:28           ` Kaushal Modi
2019-01-22 16:45           ` Eli Zaretskii
2019-01-23  1:41             ` Daniel Colascione
2019-01-23  3:43               ` Eli Zaretskii
2019-01-23  4:05                 ` Daniel Colascione
2019-01-23  5:32                   ` Eli Zaretskii
2019-01-23  6:48                     ` Daniel Colascione
2019-01-24 15:11                       ` Eli Zaretskii
2019-01-24 19:22                         ` Karl Otness
2019-01-26 10:22                           ` Eli Zaretskii
2019-01-27 18:40                             ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGk_8XLy8cGmTtWDzmuMrK6_H7iJon68yQQQ2MX7i3gV2D8_WQ@mail.gmail.com \
    --to=karl@karlotness.com \
    --cc=34114@debbugs.gnu.org \
    --cc=dancol@dancol.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.