From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Otness Newsgroups: gmane.emacs.bugs Subject: bug#31236: [PATCH] Fix pre- and post-command-hook errors in term.el Date: Sat, 21 Apr 2018 23:41:51 -0400 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e1f3d5056a67b44e" X-Trace: blaine.gmane.org 1524375553 15553 195.159.176.226 (22 Apr 2018 05:39:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Apr 2018 05:39:13 +0000 (UTC) To: 31236@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 22 07:39:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fA7iO-0003vY-HS for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Apr 2018 07:39:08 +0200 Original-Received: from localhost ([::1]:54454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fA7kT-00073Q-IW for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Apr 2018 01:41:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fA7kI-00072M-7f for bug-gnu-emacs@gnu.org; Sun, 22 Apr 2018 01:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fA7kF-0007ME-4d for bug-gnu-emacs@gnu.org; Sun, 22 Apr 2018 01:41:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fA7kE-0007LR-W2 for bug-gnu-emacs@gnu.org; Sun, 22 Apr 2018 01:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fA7kE-0007Pl-Ix for bug-gnu-emacs@gnu.org; Sun, 22 Apr 2018 01:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Karl Otness Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Apr 2018 05:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31236 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152437561228430 (code B ref -1); Sun, 22 Apr 2018 05:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Apr 2018 05:40:12 +0000 Original-Received: from localhost ([127.0.0.1]:35342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fA7jQ-0007OS-1V for submit@debbugs.gnu.org; Sun, 22 Apr 2018 01:40:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fA5tS-0004ZW-Ga for submit@debbugs.gnu.org; Sat, 21 Apr 2018 23:42:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fA5tM-0008Bw-By for submit@debbugs.gnu.org; Sat, 21 Apr 2018 23:42:21 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53478) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fA5tM-0008Bq-7V for submit@debbugs.gnu.org; Sat, 21 Apr 2018 23:42:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fA5tK-00041U-Tp for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 23:42:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fA5tH-00086j-12 for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 23:42:18 -0400 Original-Received: from mail-it0-x235.google.com ([2607:f8b0:4001:c0b::235]:34085) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fA5tG-00085g-Q7 for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 23:42:14 -0400 Original-Received: by mail-it0-x235.google.com with SMTP id t192-v6so6366968itc.1 for ; Sat, 21 Apr 2018 20:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=IObXfdbI+9ehAnkIdteO48ZJGwNT2cMrEY7yVNstJpE=; b=YDcOyOIF1otIG/jP7tIGgVLo6+OZ2O6NIVlAyWcWcu/bqXc/hf6vB8l0+03SGv8cX6 bVS8A3d8UtgXKekbCIeEUTMjoIOigmyYC82HsubIiEh0hEDyOr3cxhpvCNsRv9UR3fwK mQmhHZ9Z/+mBkgM0xDzWcqbtU02is81i9h6Bx7x66CJUGwpgbEy15Np8gQ2D7XXNkuCX /KJhKLEJmaT5Xi8qUSbLEi0HpiKHIHmDlQJ2Ixu+G+MkSO3WUwO44QQSsgAsNStZRq02 gvz5hvf7BJa9BUT8RkbsiS46X4oJI5SOBbL1DSB+E0F/NABVryuRtQfZaj3xygPJgD57 vXKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IObXfdbI+9ehAnkIdteO48ZJGwNT2cMrEY7yVNstJpE=; b=Q7G/r4BIMNsOfbFIAsVd2VO8tkg4WwzpOltGOrNrfNKR9xNYLxa4Yw6XFAIoB7veBs mUd+MkqfUNoybG80ytQY+YXXK/h7juvLpnEXNzt9wJMY8aCdhe3NQIn9J7uIsOTEPuo4 sxwUtFTx37gs7lkoClf+U67FMCZKbXR//6nfIznRvyogsejtTHrd/ak6jXyLNLrY+qxo J99UKERy8XdmFbKUAK33MRdDdo32m+cv+7QZ6SaJSY8TcipAO8HQ592KaclUKqig6dTp st4VjBTJsAX6rTT21UfTmNu1/YOWInWA2cyfmI/aYz7VSjHhQthAdtNq/s6EbbUGGRaK VCBA== X-Gm-Message-State: ALQs6tDrlybyXJ4L7LoZ+Y2qnTHVboOK4+rAZnbbyiNIcS7ujlrSGfrP +4Y2ls0CwsI4VOGqTV8DHa1P774iGRw= X-Google-Smtp-Source: AB8JxZo4BUPSeZLumXUthrBSZfNUZg6ZgoIlvEX6Zkt/4XMgPhdOTDYxwlTuxgYK39xYg603lF7faQ== X-Received: by 2002:a24:3d01:: with SMTP id n1-v6mr9010130itn.134.1524368533598; Sat, 21 Apr 2018 20:42:13 -0700 (PDT) Original-Received: from mail-io0-f171.google.com (mail-io0-f171.google.com. [209.85.223.171]) by smtp.gmail.com with ESMTPSA id q5-v6sm1725234iof.5.2018.04.21.20.42.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Apr 2018 20:42:12 -0700 (PDT) Original-Received: by mail-io0-f171.google.com with SMTP id t123-v6so14698330iof.7 for ; Sat, 21 Apr 2018 20:42:12 -0700 (PDT) X-Received: by 2002:a6b:35d0:: with SMTP id k77-v6mr16171232ioo.42.1524368532425; Sat, 21 Apr 2018 20:42:12 -0700 (PDT) Original-Received: by 2002:a4f:d592:0:0:0:0:0 with HTTP; Sat, 21 Apr 2018 20:41:51 -0700 (PDT) X-Gmail-Original-Message-ID: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Sun, 22 Apr 2018 01:40:11 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145664 Archived-At: --000000000000e1f3d5056a67b44e Content-Type: text/plain; charset="UTF-8" As far as I can tell there isn't an existing bug report for this issue. It is very minor but I have attached a fix. This affects Emacs 26.1-rc1 `term' and `ansi-term'. In char mode term installs functions in both pre- and post-command-hooks. After the process exits both of these hooks produce errors and then are removed by Emacs after printing a message. Both of these hooks are re-installed when entering char mode and removing them if they are not present will do nothing. To produce this change, I took the remove-hook lines used when entering line mode and placed them in `term-handle-exit'. To reproduce the issue in 26.1, M-x term, exit the running process and execute any command (i.e. move point). In *Messages* there should be the following lines: Error in pre-command-hook (term-set-goto-process-mark): (wrong-type-argument processp nil) Error in post-command-hook (term-goto-process-mark-maybe): (wrong-type-argument processp nil) The error seems to come up from `process-mark'. After this change, these errors no longer appear as the hooks are removed. I have attached a patch which applies this change to current master. Thank you, Karl --000000000000e1f3d5056a67b44e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-pre-and-post-command-hook-errors-in-term.el.patch" Content-Disposition: attachment; filename="0001-Fix-pre-and-post-command-hook-errors-in-term.el.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jga9g8tc0 RnJvbSBlOTg4OTE0NTA1YTY5NGIwMGVhZmY2MGNhMjI2NDAwZDk5OGMxOWFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXJsIE90bmVzcyA8a2FybEBrYXJsb3RuZXNzLmNvbT4KRGF0 ZTogU2F0LCAyMSBBcHIgMjAxOCAyMzowMToxMSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBw cmUtIGFuZCBwb3N0LWNvbW1hbmQtaG9vayBlcnJvcnMgaW4gdGVybS5lbAoKQmVmb3JlIHRoaXMg cGF0Y2gsIGFmdGVyIHRoZSB0ZXJtaW5hbCBwcm9jZXNzIGRpZXMgdGhlIGNvbW1hbmQgaG9va3MK YWRkZWQgaW4gdGVybS1tb2RlJ3MgY2hhciBtb2RlIHdvdWxkIHByb2R1Y2UgZXJyb3JzLiBUaGlz IGZpeCByZW1vdmVzCnRoZXNlIGhvb2tzIHdoZW4gdGhlIHByb2Nlc3MgZGllcy4KLS0tCiBsaXNw L3Rlcm0uZWwgfCAzICsrKwogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQoKZGlmZiAt LWdpdCBhL2xpc3AvdGVybS5lbCBiL2xpc3AvdGVybS5lbAppbmRleCBjZmIzOWMzNGU1Li4wMTdi MDIyMWVjIDEwMDY0NAotLS0gYS9saXNwL3Rlcm0uZWwKKysrIGIvbGlzcC90ZXJtLmVsCkBAIC0x NDU2LDYgKzE0NTYsOSBAQCB0ZXJtLWhhbmRsZS1leGl0CiAgIChsZXQgKChidWZmZXItcmVhZC1v bmx5IG5pbCkKIAkob21heCAocG9pbnQtbWF4KSkKIAkob3BvaW50IChwb2ludCkpKQorICAgIDs7 IFJlbW92ZSBob29rcyB0byBhdm9pZCBlcnJvcnMgZHVlIHRvIGRlYWQgcHJvY2Vzcy4KKyAgICAo cmVtb3ZlLWhvb2sgJ3ByZS1jb21tYW5kLWhvb2sgIyd0ZXJtLXNldC1nb3RvLXByb2Nlc3MtbWFy ayB0KQorICAgIChyZW1vdmUtaG9vayAncG9zdC1jb21tYW5kLWhvb2sgIyd0ZXJtLWdvdG8tcHJv Y2Vzcy1tYXJrLW1heWJlIHQpCiAgICAgOzsgUmVjb3JkIHdoZXJlIHdlIHB1dCB0aGUgbWVzc2Fn ZSwgc28gd2UgY2FuIGlnbm9yZSBpdAogICAgIDs7IGxhdGVyIG9uLgogICAgIChnb3RvLWNoYXIg b21heCkKLS0gCjIuMTcuMAoK --000000000000e1f3d5056a67b44e--