From: "João Paulo Labegalini de Carvalho" <jaopaulolc@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: Code navigation for sh-mode with Tree-sitter
Date: Mon, 5 Dec 2022 08:24:37 -0700 [thread overview]
Message-ID: <CAGjvy29V_BM5ddy99Xvfk3Rjn4Me0Eex-bRsYECgRm3fdPcUyw@mail.gmail.com> (raw)
In-Reply-To: <Y4vDumJgrf1yOxvC@ACM>
[-- Attachment #1: Type: text/plain, Size: 2153 bytes --]
On Sat, Dec 3, 2022 at 2:46 PM Alan Mackenzie <acm@muc.de> wrote:
> Yes. beginning-of-defun and end-of-defun are broken, and have been for
> a long time. They cannot, in general, work, for the reason you've just
> noted.
>
Thanks for confirming this, Alan. For a moment I thought that I was making
one of those elisp newbie mistakes.
> The problem has been raised on emacs-devel before, without the problem
> getting solved. CC Mode, for example, works around the problem by
> binding c-beginning-of-defun and c-end-of-defun directly to C-M-a and
> C-M-e, bypassing the offending code.
>
I think for now I will use the same workaround.
> The tactic of using beginning-of-defun-raw is only valid in certain
> circumstances, and is an inappropriate inefficiency in modes such as
> the one you're writing, where it is just as easy to go directly to an
> end of defun as a beginning of defun.
>
> > What I think is happening is that, when `end-of-defun' calls
> > `beginning-of-defun-raw' it brings point to the beginning of a top-level
> > function, so the subsequent call to `end-of-defun' moves point to the
> start
> > location, does it make it seems as the point did not move.
>
> Yes. I suggest you submit a bug report for this bug.
>
I will put some time into this and see if I can come up with a patch before
flagging it as a bug.
> To work properly, beginning/end-of-defun need to know whether the
> starting point is inside a defun or between defuns. Your patch includes
> a macro which determines this (as CC Mode includes a function which
> determines this). Possibly, a proper bug fix might include a function
> supplied by the major mode for this analysis.
>
Indeed. I am not sure if that would be as easy as without tree-sitter, but
such a function is definitely handy and easy to implement thanks to Yuan's
efforts to bring tree-sitter to core.
--
João Paulo L. de Carvalho
Ph.D Computer Science | IC-UNICAMP | Campinas , SP - Brazil
Postdoctoral Research Fellow | University of Alberta | Edmonton, AB - Canada
joao.carvalho@ic.unicamp.br
joao.carvalho@ualberta.ca
[-- Attachment #2: Type: text/html, Size: 3291 bytes --]
next prev parent reply other threads:[~2022-12-05 15:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 20:23 Code navigation for sh-mode with Tree-sitter João Paulo Labegalini de Carvalho
2022-12-03 21:46 ` Alan Mackenzie
2022-12-05 15:24 ` João Paulo Labegalini de Carvalho [this message]
2022-12-05 20:12 ` Stefan Monnier
2022-12-05 21:29 ` Alan Mackenzie
2022-12-05 21:56 ` Stefan Monnier
2022-12-06 15:51 ` João Paulo Labegalini de Carvalho
2022-12-06 16:48 ` Stefan Monnier
2022-12-06 21:04 ` Yuan Fu
2022-12-06 21:08 ` Yuan Fu
2022-12-06 21:40 ` Alan Mackenzie
2022-12-06 21:46 ` João Paulo Labegalini de Carvalho
2022-12-06 21:55 ` João Paulo Labegalini de Carvalho
2022-12-06 22:35 ` Stefan Monnier
2022-12-06 22:41 ` João Paulo Labegalini de Carvalho
2022-12-06 22:57 ` Stefan Monnier
2022-12-06 23:43 ` João Paulo Labegalini de Carvalho
2022-12-06 23:50 ` Stefan Monnier
2022-12-07 1:12 ` João Paulo Labegalini de Carvalho
2022-12-07 17:20 ` João Paulo Labegalini de Carvalho
2022-12-10 4:58 ` Yuan Fu
2022-12-13 4:55 ` Yuan Fu
2022-12-13 16:00 ` João Paulo Labegalini de Carvalho
2022-12-13 5:20 ` New defun navigation for tree-sitter (Was: Code navigation for sh-mode with Tree-sitter) Yuan Fu
2022-12-13 16:11 ` João Paulo Labegalini de Carvalho
2022-12-13 16:38 ` Eli Zaretskii
2022-12-13 18:03 ` João Paulo Labegalini de Carvalho
2022-12-13 18:07 ` Yuan Fu
2022-12-13 18:48 ` João Paulo Labegalini de Carvalho
2022-12-13 18:56 ` Yuan Fu
2022-12-13 19:46 ` João Paulo Labegalini de Carvalho
2022-12-16 1:49 ` Yuan Fu
2022-12-16 16:24 ` João Paulo Labegalini de Carvalho
2022-12-17 23:32 ` Yuan Fu
2022-12-07 0:41 ` Code navigation for sh-mode with Tree-sitter Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGjvy29V_BM5ddy99Xvfk3Rjn4Me0Eex-bRsYECgRm3fdPcUyw@mail.gmail.com \
--to=jaopaulolc@gmail.com \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.