Bug in sql.el : sql-add-product

Bug in sql.el : sql-add-product

[Kirstin Rhys]

The line:

    ;; Add product to the alist
    (add-to-list 'sql-product-alist `((,product :name ,display . ,plist)))

Should be:

    ;; Add product to the alist
    (add-to-list 'sql-product-alist `(,product :name ,display . ,plist))

As the original causes sql-product-alist to contain

( ( ( myproduct :name "My Product" ... ) )
  (ansi :name "ANSI" :font-lock ...)
  (db2 :name "DB2" ...)
)

instead of:

( (myproduct :name "My Product" ... )
  (ansi :name "ANSI" :font-lock ...)
  (db2 :name "DB2" ...)
)

Re: Bug in sql.el : sql-add-product

[Dmitry Gutov]

On 05/19/2015 01:24 AM, Kirstin Rhys wrote:
> The line:
>
>      ;; Add product to the alist
>      (add-to-list 'sql-product-alist `((,product :name ,display . ,plist)))
>
> Should be:
>
>      ;; Add product to the alist
>      (add-to-list 'sql-product-alist `(,product :name ,display . ,plist))

I believe that is http://debbugs.gnu.org/15435, fixed about one and a 
half years ago.

Re: Bug in sql.el : sql-add-product

[Kirstin Rhys]

Ah! Sorry.

I must be using an older version of emacs24.

For posterity and for other users, perhaps hive users in a controlled
environment who are forced to work with older versions, a fix is to add to
your .emacs :

...

(require 'sql)

(defun sql-add-product ... with corrected definition)

(require 'hive)

Thanks!





On Mon, May 18, 2015 at 4:48 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 05/19/2015 01:24 AM, Kirstin Rhys wrote:
>
>> The line:
>>
>>      ;; Add product to the alist
>>      (add-to-list 'sql-product-alist `((,product :name ,display .
>> ,plist)))
>>
>> Should be:
>>
>>      ;; Add product to the alist
>>      (add-to-list 'sql-product-alist `(,product :name ,display . ,plist))
>>
>
> I believe that is http://debbugs.gnu.org/15435, fixed about one and a
> half years ago.
>