From: Jackson Hamilton <jackson@jacksonrayhamilton.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 21799@debbugs.gnu.org
Subject: bug#21799: Requesting review for change to js.el
Date: Sat, 31 Oct 2015 09:53:05 -0700 [thread overview]
Message-ID: <CAGiE8Azp=M38A74MDdqVKGyi5x5ThTqAru7TNXjJhHNLz9ykdg@mail.gmail.com> (raw)
In-Reply-To: <5634B5B4.6070907@yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
Some use the ".jsx" extension, some just use ".js". One could also do
(add-to-list 'auto-mode-alist '("\\.js\\'" . js-jsx-mode)).
I like the idea of separating the modes as js-jsx-mode and js2-jsx-mode,
I'll make that change.
On Sat, Oct 31, 2015 at 5:36 AM, Dmitry Gutov <dgutov@yandex.ru> wrote:
> On 10/31/2015 11:37 AM, Jackson Hamilton wrote:
>
>> See attached patch. Adds JSX indentation support to js-mode.
>>
>
> Hi Jackson,
>
> JSX files have a different extension, right? Why don't we make it a
> separate major mode?
>
> It can also live in js.el and derive from js-mode. The only thing it'll
> change (for now?) is the indentation function.
>
> And for those who also want the js2-mode AST, we can either tell them to
> use js2-minor-mode, or also create a js2-jsx-mode that would derive from
> js2-mode and use the indentation function defined here.
>
> Then there will be no need for the option js-indent-jsx.
>
[-- Attachment #2: Type: text/html, Size: 1586 bytes --]
next prev parent reply other threads:[~2015-10-31 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 9:37 bug#21799: Requesting review for change to js.el Jackson Hamilton
2015-10-31 12:36 ` Dmitry Gutov
2015-10-31 16:53 ` Jackson Hamilton [this message]
2015-10-31 17:05 ` Dmitry Gutov
2015-10-31 17:53 ` Jackson Hamilton
2015-10-31 19:20 ` Dmitry Gutov
2016-02-23 5:15 ` Lars Ingebrigtsen
2016-02-23 10:14 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGiE8Azp=M38A74MDdqVKGyi5x5ThTqAru7TNXjJhHNLz9ykdg@mail.gmail.com' \
--to=jackson@jacksonrayhamilton.com \
--cc=21799@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.