From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.bugs Subject: bug#20161: Fwd: Requesting review for change to lisp/textmodes/sgml-mode.el Date: Sat, 21 Mar 2015 13:20:09 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11333434ee6bd80511d228b0 X-Trace: ger.gmane.org 1426982725 32096 80.91.229.3 (22 Mar 2015 00:05:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Mar 2015 00:05:25 +0000 (UTC) To: 20161@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 22 01:05:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZTO9-0002Cg-UX for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 01:05:10 +0100 Original-Received: from localhost ([::1]:49386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZTO8-0004Hf-Rz for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Mar 2015 20:05:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZTO4-0004G8-2w for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 20:05:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZTO2-0007gP-QY for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 20:05:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZTO2-0007fJ-Mr for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 20:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZTO1-0004Xn-V0 for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 20:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jackson Hamilton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Mar 2015 00:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20161 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142698267217426 (code B ref -1); Sun, 22 Mar 2015 00:05:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Mar 2015 00:04:32 +0000 Original-Received: from localhost ([127.0.0.1]:60144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZTNX-0004Wz-Nt for submit@debbugs.gnu.org; Sat, 21 Mar 2015 20:04:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44195) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZPsb-0007e8-PN for submit@debbugs.gnu.org; Sat, 21 Mar 2015 16:20:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZPsV-0007uZ-61 for submit@debbugs.gnu.org; Sat, 21 Mar 2015 16:20:16 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZPsV-0007uT-2O for submit@debbugs.gnu.org; Sat, 21 Mar 2015 16:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZPsT-0006dD-Qc for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 16:20:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZPsS-0007tQ-7J for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 16:20:13 -0400 Original-Received: from mail-oi0-x232.google.com ([2607:f8b0:4003:c06::232]:33180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZPsR-0007t3-W2 for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 16:20:12 -0400 Original-Received: by oifl3 with SMTP id l3so85013490oif.0 for ; Sat, 21 Mar 2015 13:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=IMGNtoNaFQmb6oXTjZ8WYBROJb715I8jVKQsVbHwEy0=; b=vZJS0Rvy7Ik7tgZmLC0d4YI2Dgtgr+6+0YjuJeU7PfF/zLnXg12fi/gzvHE91D1ITb FVcGGRkNYFp1utoCshG4BcKkQdSPG5z9zkwPSOuhaWlUlVrjeM9bB//lsFVWzBAwWeI6 LC8iWhhQ+G+akTnNP8BNOZyHCEkTJ8ZiIBVLLkZ3EtwMZGg4WKAOpo2KkzQZgxUYKObq m1rmksorZlZ2Nbp+byZjbuvtIl+mR2A8598YW4ts/3fvlW6xrq2CALBgO2K9hlrPWVoE Y9HzbPQLRCbuOUmRkakCJeeFF9hiRbGvhxSHPLrTsHSD8QmtP6a7oqMI5ZmukUYJjb9D N26Q== X-Received: by 10.60.70.211 with SMTP id o19mr66351168oeu.21.1426969211062; Sat, 21 Mar 2015 13:20:11 -0700 (PDT) Original-Received: by 10.76.54.11 with HTTP; Sat, 21 Mar 2015 13:20:09 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: tYtknePUHju8NhtHvfZDBQOHw-M X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sat, 21 Mar 2015 20:04:30 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100771 Archived-At: --001a11333434ee6bd80511d228b0 Content-Type: multipart/alternative; boundary=001a11333434ee6bd20511d228ae --001a11333434ee6bd20511d228ae Content-Type: text/plain; charset=ISO-8859-1 No one on emacs-devel seemed to notice, so I'm pushing this on to the bug mailing list. If someone could please review this I'd appreciate it. ---------- Forwarded message ---------- From: Jackson Hamilton Date: Sat, Mar 7, 2015 at 4:49 PM Subject: Fwd: Requesting review for change to lisp/textmodes/sgml-mode.el To: emacs-devel Hey guys, still hoping to get this reviewed. I wouldn't want to merge something in that wasn't given the "A-OK." ---------- Forwarded message ---------- From: Jackson Hamilton Date: Wed, Feb 25, 2015 at 2:35 AM Subject: Requesting review for change to lisp/textmodes/sgml-mode.el To: emacs-devel Hello comrades, I made an adjustment (fix?) to the way SGML attributes are indented. Previously, if one wrote a form like the following: He could break the attribute onto a new line and it would be indented like so: But sgml-basic-offset defaults to 2, not 3, so it doesn't make much sense that the attribute is indented by 3 spaces. And if I (setq sgml-basic-offset 4), now my attributes are indented by 5 spaces. Personally I do not expect this behavior, I expect the indentation to match. Perhaps it could be argued that the extra space helps to improve readability; maybe so, but it still seems to contradict the offset value. In teams where many people use editors that insert multiples of N spaces or tabs, this +1 indentation strategy feels rather alienating. I think it would be better to stick to a multiple of the specified offset when an attribute is sitting on its own line. Hence the attached patch to remove the +1 indentation behavior. Thanks for reviewing, Jackson --001a11333434ee6bd20511d228ae Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
No one on emacs-devel seemed to notice, so I'm pu= shing this on to the bug mailing list. If someone could please review this = I'd appreciate it.

---------- Forwa= rded message ----------
From: Jackson Hami= lton <jackson@jacksonrayhamilton.com>
Date: Sat, Mar 7, 20= 15 at 4:49 PM
Subject: Fwd: Requesting review for change to lisp/textmod= es/sgml-mode.el
To: emacs-devel <emacs-devel@gnu.org>


Hey guys, s= till hoping to get this reviewed. I wouldn't want to merge
so= mething in that wasn't given the "A-OK."

---------- Forwarded message -------= ---
From: Jackson Hamilton <jackson@jacksonrayhamilton.com>
Date: Wed, Feb 25, 2= 015 at 2:35 AM
Subject: Requesting review for change to lisp/textmodes/s= gml-mode.el
To: emacs-devel <emacs-devel@gnu.org>


Hello comrades,

I made an adjustment (fix?) to = the way SGML attributes are indented.

Previously, = if one wrote a form like the following:

<elemen= t attribute=3D"value">

He could break= the attribute onto a new line and it would be indented like so:
=
<element
=A0 =A0attribute=3D"value"&g= t;

But sgml-basic-offset defaults to 2, not 3, so = it doesn't make much sense that
the attribute is indented by = 3 spaces.

And if I (setq sgml-basic-offset 4), now= my attributes are indented by 5
spaces. Personally I do not expe= ct this behavior, I expect the indentation to
match.
Perhaps it could be argued that the extra space helps to impro= ve readability;
maybe so, but it still seems to contradict the of= fset value. In teams where many
people use editors that insert mu= ltiples of N spaces or tabs, this +1
indentation strategy feels r= ather alienating. I think it would be better to
stick to a multip= le of the specified offset when an attribute is sitting on its
ow= n line.

Hence the attached patch to remove the +1 = indentation behavior.

Thanks for reviewing,
<= div>Jackson


--001a11333434ee6bd20511d228ae-- --001a11333434ee6bd80511d228b0 Content-Type: text/x-patch; charset=US-ASCII; name="0001-lisp-textmodes-sgml-mode.el-sgml-calculate-indent-Fi.patch" Content-Disposition: attachment; filename="0001-lisp-textmodes-sgml-mode.el-sgml-calculate-indent-Fi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i6kl46v30 RnJvbSA0ZTRmNDUxOTY0MTk0NmVlMGIzNjgzNjY0NmZiMzM5Y2JhZmFkMTgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNrc29uIFJheSBIYW1pbHRvbiA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgpEYXRlOiBXZWQsIDI1IEZlYiAyMDE1IDAxOjU2OjQ5IC0wODAwClN1 YmplY3Q6IFtQQVRDSF0gKiBsaXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwgKHNnbWwtY2FsY3Vs YXRlLWluZGVudCk6IEZpeAogaW5kZW50LgoKUHJldmlvdXNseSwgU0dNTCBhdHRyaWJ1dGVzIHdl cmUgYWx3YXlzIGluZGVudGVkIG9uZSBhZGRpdGlvbmFsIHNwYWNlCnBhc3QgYHNnbWwtYmFzaWMt b2Zmc2V0Jy4gVGhpcyBmaXhlcyB0aGF0LgotLS0KIGxpc3AvQ2hhbmdlTG9nICAgICAgICAgICAg ICB8IDUgKysrKysKIGxpc3AvdGV4dG1vZGVzL3NnbWwtbW9kZS5lbCB8IDQgKystLQogMiBmaWxl cyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv bGlzcC9DaGFuZ2VMb2cgYi9saXNwL0NoYW5nZUxvZwppbmRleCBmYzI4OTNlLi4xNzcxN2UwIDEw MDY0NAotLS0gYS9saXNwL0NoYW5nZUxvZworKysgYi9saXNwL0NoYW5nZUxvZwpAQCAtMSwzICsx LDggQEAKKzIwMTUtMDItMjUgIEphY2tzb24gUmF5IEhhbWlsdG9uICA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgorCisJKiBsaXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwgKHNnbWwt Y2FsY3VsYXRlLWluZGVudCk6IEZpeAorCWF0dHJpYnV0ZSBpbmRlbnRhdGlvbi4KKwogMjAxNS0w Mi0yNSAgU3RlZmFuIE1vbm5pZXIgIDxtb25uaWVyQGlyby51bW9udHJlYWwuY2E+CiAKIAkqIGVt YWNzLWxpc3AvZWRlYnVnLmVsIChlZGVidWctLWRpc3BsYXkpOiBTYXZlLWV4Y3Vyc2lvbiAoYnVn IzE5NjExKS4KZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL3NnbWwtbW9kZS5lbCBiL2xpc3Av dGV4dG1vZGVzL3NnbWwtbW9kZS5lbAppbmRleCAxMmQ5OGM4Li44ODdjNzBkIDEwMDY0NAotLS0g YS9saXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvc2dtbC1t b2RlLmVsCkBAIC0xNTEwLDEzICsxNTEwLDEzIEBAIExDT04gaXMgdGhlIGxleGljYWwgY29udGV4 dCwgaWYgYW55LiIKICAgICAoYHBpIG5pbCkKIAogICAgIChgdGFnCi0gICAgIChnb3RvLWNoYXIg KDErIChjZHIgbGNvbikpKQorICAgICAoZ290by1jaGFyIChjZHIgbGNvbikpCiAgICAgIChza2lw LWNoYXJzLWZvcndhcmQgIl4gXHRcbiIpCTtTa2lwIHRhZyBuYW1lLgogICAgICAoc2tpcC1jaGFy cy1mb3J3YXJkICIgXHQiKQogICAgICAoaWYgKG5vdCAoZW9scCkpCiAJIChjdXJyZW50LWNvbHVt bikKICAgICAgICA7OyBUaGlzIGlzIHRoZSBmaXJzdCBhdHRyaWJ1dGU6IGluZGVudC4KLSAgICAg ICAoZ290by1jaGFyICgxKyAoY2RyIGxjb24pKSkKKyAgICAgICAoZ290by1jaGFyIChjZHIgbGNv bikpCiAgICAgICAgKCsgKGN1cnJlbnQtY29sdW1uKSBzZ21sLWJhc2ljLW9mZnNldCkpKQogCiAg ICAgKGB0ZXh0Ci0tIAoxLjkuMQoK --001a11333434ee6bd80511d228b0--