From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.bugs Subject: bug#20161: Fwd: Requesting review for change to lisp/textmodes/sgml-mode.el Date: Sun, 22 Mar 2015 08:39:22 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b33934189d2190511e25af3 X-Trace: ger.gmane.org 1427038842 4843 80.91.229.3 (22 Mar 2015 15:40:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Mar 2015 15:40:42 +0000 (UTC) Cc: 20161@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 22 16:40:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZhz3-0001BM-Ln for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 16:40:13 +0100 Original-Received: from localhost ([::1]:51423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZhz1-0006n0-Na for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 11:40:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZhyx-0006jz-6m for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 11:40:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZhyt-0000Wf-Tv for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 11:40:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZhyt-0000VW-PI for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 11:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZhyt-0002Nc-9C for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 11:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jackson Hamilton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Mar 2015 15:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20161 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20161-submit@debbugs.gnu.org id=B20161.14270387729103 (code B ref 20161); Sun, 22 Mar 2015 15:40:03 +0000 Original-Received: (at 20161) by debbugs.gnu.org; 22 Mar 2015 15:39:32 +0000 Original-Received: from localhost ([127.0.0.1]:60777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZhyN-0002Mk-1A for submit@debbugs.gnu.org; Sun, 22 Mar 2015 11:39:31 -0400 Original-Received: from mail-ob0-f177.google.com ([209.85.214.177]:36343) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZhyK-0002MX-HH for 20161@debbugs.gnu.org; Sun, 22 Mar 2015 11:39:29 -0400 Original-Received: by obdfc2 with SMTP id fc2so107729010obd.3 for <20161@debbugs.gnu.org>; Sun, 22 Mar 2015 08:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=fCYteIyNJJzoy4lvUbnqcfhkOxayBLSs2zW8Wr+/SX4=; b=YpH4/RyaXfrWCbzNRcd1K8feMrrnE3GDatZp9rRV+k/GfgFOCZESyEWflEDyLIcLxs vrcdfOLVaEhzY/priZXPk81jM7I+hAvWZ3UvK6WiF0IBaE5cZBJBhPbZWP5NyppNTjs6 lLw2kWRVN6X1llejlJfKH6p0xEmSE2sUhqVmq2/aOmx/EHI9Wh0lsVzrEbZymJ0pf2EL zJaKMbRUav1CV3jZBeLbDiIfPYUblIhHoBQ2nhiW+l9kGuZqOWTP8yrQ9WjPzga+SCRj tpiGzmY55qGWFdOkXyx3KpBckDspmQDeF9XfnauKDetj2hj55QnWUk1XiBGrBWAryOac mnfA== X-Received: by 10.60.120.36 with SMTP id kz4mr72447274oeb.47.1427038762807; Sun, 22 Mar 2015 08:39:22 -0700 (PDT) Original-Received: by 10.76.54.11 with HTTP; Sun, 22 Mar 2015 08:39:22 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: EgfZtB0DYWWQr0L6arjWH82Zu50 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100782 Archived-At: --047d7b33934189d2190511e25af3 Content-Type: multipart/alternative; boundary=047d7b33934189d2120511e25af1 --047d7b33934189d2120511e25af1 Content-Type: text/plain; charset=ISO-8859-1 Okay, created a defcustom for it. Patch is attached. On Sun, Mar 22, 2015 at 7:03 AM, Stefan Monnier wrote: > > He could break the attribute onto a new line and it would be indented > like > > so: > > > > attribute="value"> > > > But sgml-basic-offset defaults to 2, not 3, so it doesn't make much sense > > that > > the attribute is indented by 3 spaces. > > As is clear from the code you're changing the "1+" is quite deliberate, > which shows some people prefer it that way. > > So as discussed, this indentation step should have its own custom var. > You can make it default to the behavior you prefer if you want. > > Other than that, the patch looks OK. > > > Stefan > --047d7b33934189d2120511e25af1 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Okay, created a defcustom for it. Patch is attached.
=

On Sun, Mar 22, 2= 015 at 7:03 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> He could break the attri= bute onto a new line and it would be indented like
> so:

> <element
>=A0 =A0 attribute=3D"value">

> But sgml-basic-offset defaults to 2, not 3, so it doesn't make muc= h sense
> that
> the attribute is indented by 3 spaces.

As is clear from the code you're changing the "1+" is quite d= eliberate,
which shows some people prefer it that way.

So as discussed, this indentation step should have its own custom var.
You can make it default to the behavior you prefer if you want.

Other than that, the patch looks OK.


=A0 =A0 =A0 =A0 Stefan

--047d7b33934189d2120511e25af1-- --047d7b33934189d2190511e25af3 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Have-sgml-attribute-offset-control-SGML-attribute-in.patch" Content-Disposition: attachment; filename="0001-Have-sgml-attribute-offset-control-SGML-attribute-in.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i7km0ir40 RnJvbSBjNGFiMjBlYjVhMDQ1NDQzOGQ5NjYzNWIxYzEyZjdiMjk5ZTEwNTc5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNrc29uIFJheSBIYW1pbHRvbiA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgpEYXRlOiBTdW4sIDIyIE1hciAyMDE1IDA4OjIyOjI5IC0wNzAwClN1 YmplY3Q6IFtQQVRDSF0gSGF2ZSBgc2dtbC1hdHRyaWJ1dGUtb2Zmc2V0JyBjb250cm9sIFNHTUwg YXR0cmlidXRlCiBpbmRlbnRhdGlvbgoKRml4ZXM6IGRlYmJ1Z3M6MjAxNjEKCiogdGV4dG1vZGVz L3NnbWwtbW9kZS5lbCAoc2dtbC1hdHRyaWJ1dGUtb2Zmc2V0KTogTmV3IGRlZmN1c3RvbS4KKHNn bWwtY2FsY3VsYXRlLWluZGVudCk6IFVzZSBgc2dtbC1hdHRyaWJ1dGUtb2Zmc2V0JyBmb3IgYXR0 cmlidXRlCmluZGVudGF0aW9uLgotLS0KIGxpc3AvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICB8ICA2ICsrKysrKwogbGlzcC90ZXh0bW9kZXMvc2dtbC1tb2RlLmVsICAgICAgICAgIHwg MjMgKysrKysrKysrKysrKysrKysrKysrLS0KIHRlc3QvaW5kZW50L3NnbWwtbW9kZS1hdHRyaWJ1 dGUuaHRtbCB8IDE0ICsrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgdGVzdC9pbmRlbnQvc2dt bC1tb2RlLWF0dHJpYnV0ZS5odG1sCgpkaWZmIC0tZ2l0IGEvbGlzcC9DaGFuZ2VMb2cgYi9saXNw L0NoYW5nZUxvZwppbmRleCAyZjljNDMwLi5iYTk1NDAxIDEwMDY0NAotLS0gYS9saXNwL0NoYW5n ZUxvZworKysgYi9saXNwL0NoYW5nZUxvZwpAQCAtMSwzICsxLDkgQEAKKzIwMTUtMDMtMjIgIEph Y2tzb24gUmF5IEhhbWlsdG9uICA8amFja3NvbkBqYWNrc29ucmF5aGFtaWx0b24uY29tPgorCisJ KiB0ZXh0bW9kZXMvc2dtbC1tb2RlLmVsIChzZ21sLWF0dHJpYnV0ZS1vZmZzZXQpOiBOZXcgZGVm Y3VzdG9tLgorCShzZ21sLWNhbGN1bGF0ZS1pbmRlbnQpOiBVc2UgYHNnbWwtYXR0cmlidXRlLW9m ZnNldCcgZm9yIGF0dHJpYnV0ZQorCWluZGVudGF0aW9uLgorCiAyMDE1LTAzLTIxICBUaXR1cyB2 b24gZGVyIE1hbHNidXJnICA8bWFsc2J1cmdAcG9zdGVvLmRlPgogCiAJKiB3aW5kb3cuZWwgKHdp bmRvdy1mb250LXdpZHRoLCB3aW5kb3ctZm9udC1oZWlnaHQpCmRpZmYgLS1naXQgYS9saXNwL3Rl eHRtb2Rlcy9zZ21sLW1vZGUuZWwgYi9saXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwKaW5kZXgg MTJkOThjOC4uODI2NjY0NyAxMDA2NDQKLS0tIGEvbGlzcC90ZXh0bW9kZXMvc2dtbC1tb2RlLmVs CisrKyBiL2xpc3AvdGV4dG1vZGVzL3NnbWwtbW9kZS5lbApAQCAtNDYsNiArNDYsMjUgQEAKICAg OnR5cGUgJ2ludGVnZXIKICAgOmdyb3VwICdzZ21sKQogCisoZGVmY3VzdG9tIHNnbWwtYXR0cmli dXRlLW9mZnNldCAwCisgICJTcGVjaWZpZXMgYSBkZWx0YSBmb3IgYXR0cmlidXRlIGluZGVudGF0 aW9uIGluIGBzZ21sLWluZGVudC1saW5lJy4KKworV2hlbiAwLCBhdHRyaWJ1dGUgaW5kZW50YXRp b24gbG9va3MgbGlrZSB0aGlzOgorCisgIDxlbGVtZW50CisgICAgYXR0cmlidXRlPVwidmFsdWVc Ij4KKyAgPC9lbGVtZW50PgorCitXaGVuIDIsIGF0dHJpYnV0ZSBpbmRlbnRhdGlvbiBsb29rcyBs aWtlIHRoaXM6CisKKyAgPGVsZW1lbnQKKyAgICAgIGF0dHJpYnV0ZT1cInZhbHVlXCI+CisgIDwv ZWxlbWVudD4iCisgIDp2ZXJzaW9uICIyNS4xIgorICA6dHlwZSAnaW50ZWdlcgorICA6c2FmZSAn aW50ZWdlcnAKKyAgOmdyb3VwICdzZ21sKQorCiAoZGVmY3VzdG9tIHNnbWwteG1sLW1vZGUgbmls CiAgICJXaGVuIG5vbi1uaWwsIHRhZyBpbnNlcnRpb24gZnVuY3Rpb25zIHdpbGwgYmUgWE1MLWNv bXBsaWFudC4KIEl0IGlzIHNldCB0byBiZSBidWZmZXItbG9jYWwgd2hlbiB0aGUgZmlsZSBoYXMK QEAgLTE1MTAsMTMgKzE1MjksMTMgQEAgTENPTiBpcyB0aGUgbGV4aWNhbCBjb250ZXh0LCBpZiBh bnkuIgogICAgIChgcGkgbmlsKQogCiAgICAgKGB0YWcKLSAgICAgKGdvdG8tY2hhciAoMSsgKGNk ciBsY29uKSkpCisgICAgIChnb3RvLWNoYXIgKCsgKGNkciBsY29uKSBzZ21sLWF0dHJpYnV0ZS1v ZmZzZXQpKQogICAgICAoc2tpcC1jaGFycy1mb3J3YXJkICJeIFx0XG4iKQk7U2tpcCB0YWcgbmFt ZS4KICAgICAgKHNraXAtY2hhcnMtZm9yd2FyZCAiIFx0IikKICAgICAgKGlmIChub3QgKGVvbHAp KQogCSAoY3VycmVudC1jb2x1bW4pCiAgICAgICAgOzsgVGhpcyBpcyB0aGUgZmlyc3QgYXR0cmli dXRlOiBpbmRlbnQuCi0gICAgICAgKGdvdG8tY2hhciAoMSsgKGNkciBsY29uKSkpCisgICAgICAg KGdvdG8tY2hhciAoKyAoY2RyIGxjb24pIHNnbWwtYXR0cmlidXRlLW9mZnNldCkpCiAgICAgICAg KCsgKGN1cnJlbnQtY29sdW1uKSBzZ21sLWJhc2ljLW9mZnNldCkpKQogCiAgICAgKGB0ZXh0CmRp ZmYgLS1naXQgYS90ZXN0L2luZGVudC9zZ21sLW1vZGUtYXR0cmlidXRlLmh0bWwgYi90ZXN0L2lu ZGVudC9zZ21sLW1vZGUtYXR0cmlidXRlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uNGNiZWMwYQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3QvaW5kZW50L3NnbWwtbW9k ZS1hdHRyaWJ1dGUuaHRtbApAQCAtMCwwICsxLDE0IEBACis8ZWxlbWVudCBhdHRyaWJ1dGU9InZh bHVlIj48L2VsZW1lbnQ+CisKKzxlbGVtZW50CisgICAgYXR0cmlidXRlPSJ2YWx1ZSI+CisgIDxl bGVtZW50CisgICAgICBhdHRyaWJ1dGU9InZhbHVlIj4KKyAgPC9lbGVtZW50PgorPC9lbGVtZW50 PgorCis8IS0tCisgICAgTG9jYWwgVmFyaWFibGVzOgorICAgIHNnbWwtYXR0cmlidXRlLW9mZnNl dDogMgorICAgIEVuZDoKKyAgLS0+Ci0tIAoxLjkuMQoK --047d7b33934189d2190511e25af3--