From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.devel Subject: Fwd: Requesting review for change to lisp/textmodes/sgml-mode.el Date: Sat, 7 Mar 2015 16:49:59 -0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113d593a2332d20510bc4c9f X-Trace: ger.gmane.org 1425775826 25899 80.91.229.3 (8 Mar 2015 00:50:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Mar 2015 00:50:26 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 08 01:50:24 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YUPQC-0007zW-0r for ged-emacs-devel@m.gmane.org; Sun, 08 Mar 2015 01:50:20 +0100 Original-Received: from localhost ([::1]:37083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUPQA-00007D-Sj for ged-emacs-devel@m.gmane.org; Sat, 07 Mar 2015 19:50:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUPPv-00005j-Gh for emacs-devel@gnu.org; Sat, 07 Mar 2015 19:50:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUPPu-0002oi-88 for emacs-devel@gnu.org; Sat, 07 Mar 2015 19:50:03 -0500 Original-Received: from mail-ob0-x230.google.com ([2607:f8b0:4003:c01::230]:35777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUPPu-0002nS-1E for emacs-devel@gnu.org; Sat, 07 Mar 2015 19:50:02 -0500 Original-Received: by obbgq1 with SMTP id gq1so27472944obb.2 for ; Sat, 07 Mar 2015 16:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=RkXHBNbZM57lP+X8KT2uFnjzcpivYNVPEYV67HZTvTM=; b=iA+GRa22AKw/du7JRLSS9SRLUh6mb4CluY15LRuoV59cm+uT3wLKAh/BrbtMZs4De/ wvVcpxk/vfQmVqScdCaKM6H8O24ZVmucuSTgIe/9k7bNEXzhzNqy8CYiC+739n6HHwm2 svox7gjfMgUDlKocXiofqn+Hz4XhOwYEaO8VH467IiHoYrClgOuLZKVU6ejqHTNlq4Sv pqK1g9jeHJMotcTWVt+hRT7qlFsCObGvYdFSeiBChLlollZe5uMKYcEWUJqhI/UcSAKp Awi/B9QgllSNwbXm9uEhjgpmv61nsv2weP7qnKrCeCZxSGGup4mBTqXxLcl6P3cHlQBw ovOw== X-Received: by 10.202.224.9 with SMTP id x9mr15611695oig.62.1425775800812; Sat, 07 Mar 2015 16:50:00 -0800 (PST) Original-Received: by 10.76.195.8 with HTTP; Sat, 7 Mar 2015 16:49:59 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: 4r9VvvQIa3xKlXqmpDYz5gi69-I X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183717 Archived-At: --001a113d593a2332d20510bc4c9f Content-Type: multipart/alternative; boundary=001a113d593a2332ca0510bc4c9d --001a113d593a2332ca0510bc4c9d Content-Type: text/plain; charset=ISO-8859-1 Hey guys, still hoping to get this reviewed. I wouldn't want to merge something in that wasn't given the "A-OK." ---------- Forwarded message ---------- From: Jackson Hamilton Date: Wed, Feb 25, 2015 at 2:35 AM Subject: Requesting review for change to lisp/textmodes/sgml-mode.el To: emacs-devel Hello comrades, I made an adjustment (fix?) to the way SGML attributes are indented. Previously, if one wrote a form like the following: He could break the attribute onto a new line and it would be indented like so: But sgml-basic-offset defaults to 2, not 3, so it doesn't make much sense that the attribute is indented by 3 spaces. And if I (setq sgml-basic-offset 4), now my attributes are indented by 5 spaces. Personally I do not expect this behavior, I expect the indentation to match. Perhaps it could be argued that the extra space helps to improve readability; maybe so, but it still seems to contradict the offset value. In teams where many people use editors that insert multiples of N spaces or tabs, this +1 indentation strategy feels rather alienating. I think it would be better to stick to a multiple of the specified offset when an attribute is sitting on its own line. Hence the attached patch to remove the +1 indentation behavior. Thanks for reviewing, Jackson --001a113d593a2332ca0510bc4c9d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hey guys, still hoping to get this reviewed. I wouldn= 't want to merge
something in that wasn't given the "= ;A-OK."

---------- Forwarded messa= ge ----------
From: Jackson Hamilton <= span dir=3D"ltr"><jack= son@jacksonrayhamilton.com>
Date: Wed, Feb 25, 2015 at 2:3= 5 AM
Subject: Requesting review for change to lisp/textmodes/sgml-mode.e= l
To: emacs-devel <emacs-devel= @gnu.org>


Hello comrades,

I made an adjustment (fix?) to the way SGML attributes are = indented.

Previously, if one wrote a form like the= following:

<element attribute=3D"value&qu= ot;>

He could break the attribute onto a new li= ne and it would be indented like so:

<element
=A0 =A0attribute=3D"value">

= But sgml-basic-offset defaults to 2, not 3, so it doesn't make much sen= se that
the attribute is indented by 3 spaces.

And if I (setq sgml-basic-offset 4), now my attributes are indented = by 5
spaces. Personally I do not expect this behavior, I expect t= he indentation to
match.

Perhaps it coul= d be argued that the extra space helps to improve readability;
ma= ybe so, but it still seems to contradict the offset value. In teams where m= any
people use editors that insert multiples of N spaces or tabs,= this +1
indentation strategy feels rather alienating. I think it= would be better to
stick to a multiple of the specified offset w= hen an attribute is sitting on its
own line.

=
Hence the attached patch to remove the +1 indentation behavior.
<= div>
Thanks for reviewing,
Jackson

--001a113d593a2332ca0510bc4c9d-- --001a113d593a2332d20510bc4c9f Content-Type: text/x-patch; charset=US-ASCII; name="0001-lisp-textmodes-sgml-mode.el-sgml-calculate-indent-Fi.patch" Content-Disposition: attachment; filename="0001-lisp-textmodes-sgml-mode.el-sgml-calculate-indent-Fi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i6kl46v30 RnJvbSA0ZTRmNDUxOTY0MTk0NmVlMGIzNjgzNjY0NmZiMzM5Y2JhZmFkMTgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNrc29uIFJheSBIYW1pbHRvbiA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgpEYXRlOiBXZWQsIDI1IEZlYiAyMDE1IDAxOjU2OjQ5IC0wODAwClN1 YmplY3Q6IFtQQVRDSF0gKiBsaXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwgKHNnbWwtY2FsY3Vs YXRlLWluZGVudCk6IEZpeAogaW5kZW50LgoKUHJldmlvdXNseSwgU0dNTCBhdHRyaWJ1dGVzIHdl cmUgYWx3YXlzIGluZGVudGVkIG9uZSBhZGRpdGlvbmFsIHNwYWNlCnBhc3QgYHNnbWwtYmFzaWMt b2Zmc2V0Jy4gVGhpcyBmaXhlcyB0aGF0LgotLS0KIGxpc3AvQ2hhbmdlTG9nICAgICAgICAgICAg ICB8IDUgKysrKysKIGxpc3AvdGV4dG1vZGVzL3NnbWwtbW9kZS5lbCB8IDQgKystLQogMiBmaWxl cyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv bGlzcC9DaGFuZ2VMb2cgYi9saXNwL0NoYW5nZUxvZwppbmRleCBmYzI4OTNlLi4xNzcxN2UwIDEw MDY0NAotLS0gYS9saXNwL0NoYW5nZUxvZworKysgYi9saXNwL0NoYW5nZUxvZwpAQCAtMSwzICsx LDggQEAKKzIwMTUtMDItMjUgIEphY2tzb24gUmF5IEhhbWlsdG9uICA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgorCisJKiBsaXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwgKHNnbWwt Y2FsY3VsYXRlLWluZGVudCk6IEZpeAorCWF0dHJpYnV0ZSBpbmRlbnRhdGlvbi4KKwogMjAxNS0w Mi0yNSAgU3RlZmFuIE1vbm5pZXIgIDxtb25uaWVyQGlyby51bW9udHJlYWwuY2E+CiAKIAkqIGVt YWNzLWxpc3AvZWRlYnVnLmVsIChlZGVidWctLWRpc3BsYXkpOiBTYXZlLWV4Y3Vyc2lvbiAoYnVn IzE5NjExKS4KZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL3NnbWwtbW9kZS5lbCBiL2xpc3Av dGV4dG1vZGVzL3NnbWwtbW9kZS5lbAppbmRleCAxMmQ5OGM4Li44ODdjNzBkIDEwMDY0NAotLS0g YS9saXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvc2dtbC1t b2RlLmVsCkBAIC0xNTEwLDEzICsxNTEwLDEzIEBAIExDT04gaXMgdGhlIGxleGljYWwgY29udGV4 dCwgaWYgYW55LiIKICAgICAoYHBpIG5pbCkKIAogICAgIChgdGFnCi0gICAgIChnb3RvLWNoYXIg KDErIChjZHIgbGNvbikpKQorICAgICAoZ290by1jaGFyIChjZHIgbGNvbikpCiAgICAgIChza2lw LWNoYXJzLWZvcndhcmQgIl4gXHRcbiIpCTtTa2lwIHRhZyBuYW1lLgogICAgICAoc2tpcC1jaGFy cy1mb3J3YXJkICIgXHQiKQogICAgICAoaWYgKG5vdCAoZW9scCkpCiAJIChjdXJyZW50LWNvbHVt bikKICAgICAgICA7OyBUaGlzIGlzIHRoZSBmaXJzdCBhdHRyaWJ1dGU6IGluZGVudC4KLSAgICAg ICAoZ290by1jaGFyICgxKyAoY2RyIGxjb24pKSkKKyAgICAgICAoZ290by1jaGFyIChjZHIgbGNv bikpCiAgICAgICAgKCsgKGN1cnJlbnQtY29sdW1uKSBzZ21sLWJhc2ljLW9mZnNldCkpKQogCiAg ICAgKGB0ZXh0Ci0tIAoxLjkuMQoK --001a113d593a2332d20510bc4c9f--