From: Jackson Hamilton <jackson@jacksonrayhamilton.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799)
Date: Sat, 31 Oct 2015 13:21:24 -0700 [thread overview]
Message-ID: <CAGiE8Aw6EtMKMbugxbQGOmN31FvOhHw+cf8RGa+G75hm7+LZ7w@mail.gmail.com> (raw)
In-Reply-To: <83twp6yem2.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
Sorry about this :( Can/how do we fix the first problem?
On Sat, Oct 31, 2015 at 1:20 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Dmitry Gutov <dgutov@yandex.ru>
> > Date: Sat, 31 Oct 2015 22:16:31 +0200
> >
> > > * progmodes/js.el: Add JSX indentation support.
> > > (js-jsx-indent-line)
> > > (js-jsx-mode): New functions.
> >
> > Someone please correct me if I'm wrong, but I don't think the guidelines
> > allow omitting entries for "private" functions and variables.
>
> You are not wrong. All new/changed functions in the changeset should
> be mentioned.
>
[-- Attachment #2: Type: text/html, Size: 1043 bytes --]
next prev parent reply other threads:[~2015-10-31 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151031200522.15326.84667@vcs.savannah.gnu.org>
[not found] ` <E1ZscOw-0003zo-CG@vcs.savannah.gnu.org>
2015-10-31 20:16 ` [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799) Dmitry Gutov
2015-10-31 20:20 ` Eli Zaretskii
2015-10-31 20:21 ` Jackson Hamilton [this message]
2015-10-31 20:33 ` Eli Zaretskii
2015-10-31 20:42 ` Jackson Hamilton
2015-11-03 5:16 ` Jackson Hamilton
2015-11-03 10:08 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGiE8Aw6EtMKMbugxbQGOmN31FvOhHw+cf8RGa+G75hm7+LZ7w@mail.gmail.com \
--to=jackson@jacksonrayhamilton.com \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.