bug#14691: 24.3; auto-save-list

bug#14691: 24.3; auto-save-list

[João Guerra]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

Emacs is not deleting the auto-save-list file when closing. This happens
only if I set the auto-save-list file name with the
auto-save-list-file-name variable instead of with the
auto-save-list-file-prefix.

In GNU Emacs 24.3.1 (i386-mingw-nt6.1.7601) of 2013-03-17 on MARVIN
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --with-gcc (4.7) --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'

Important settings:
  value of $LANG: PTG
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  global-undo-tree-mode: t
  undo-tree-mode: t
  cua-mode: t
  autopair-global-mode: t
  autopair-mode: t
  electric-indent-mode: t
  global-hl-line-mode: t
  global-linum-mode: t
  linum-mode: t
  tabbar-mwheel-mode: t
  tabbar-mode: t
  ido-everywhere: t
  recentf-mode: t
  savehist-mode: t
  desktop-save-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

[-- Attachment #2: Type: text/html, Size: 2317 bytes --]

bug#14691: 24.3; auto-save-list

[Glenn Morris]

João Guerra wrote:

> Emacs is not deleting the auto-save-list file when closing. This happens
> only if I set the auto-save-list file name with the
> auto-save-list-file-name variable instead of with the
> auto-save-list-file-prefix.

I can't reproduce on GNU/Linux this with:

emacs-24.3 -Q --eval '(setq auto-save-list-file-name "/home/gm/FOO")' ~/bar &

If I make some changes to ~/bar and wait for it to be auto-saved, ~/FOO
is created. If I save bar and exit Emacs with C-x C-c, ~/FOO is removed.

Do you have a recipe starting from emacs -Q?

> In GNU Emacs 24.3.1 (i386-mingw-nt6.1.7601) of 2013-03-17 on MARVIN
> Windowing system distributor `Microsoft Corp.', version 6.1.7601

bug#14691: Acknowledgement (24.3; auto-save-list)

[João Guerra]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Minimal working .emacs example

(defconst backups-dir "~/.emacs.d/backups/")

;; auto-save
(setq auto-save-default t
      auto-save-interval 0
      auto-save-timeout 5
      delete-auto-save-files t
      auto-save-list-file-name (concat backups-dir (format ".auto-save-%s"
(emacs-pid)))
      auto-save-file-name-transforms `((".*" ,backups-dir t)))


I run Emacs 24.3 on Windows 7 x64 with "runemacs.exe"

[-- Attachment #2: Type: text/html, Size: 717 bytes --]

bug#14691: Acknowledgement (24.3; auto-save-list)

[Glenn Morris]

João Guerra wrote:

> Minimal working .emacs example

Thanks. My minimal example would be:

  (setq auto-save-list-file-name "~/SAVE")

> (defconst backups-dir "~/.emacs.d/backups/")

Use (expand-file-name "~/.emacs.d/backups/") and it should work.

The issue is that we use

   unlink (SSDATA (Vauto_save_list_file_name));

and unlink does not understand the "~" construct.

bug#14691: Acknowledgement (24.3; auto-save-list)

[João Guerra]

[-- Attachment #1: Type: text/plain, Size: 62 bytes --]

Thanks, that solves the problem.
Sorry for wasting your time.

[-- Attachment #2: Type: text/html, Size: 93 bytes --]

bug#14691: Acknowledgement (24.3; auto-save-list)

[Glenn Morris]

João Guerra wrote:

> Thanks, that solves the problem.
> Sorry for wasting your time.

No, it's an Emacs bug that we should fix. Thank you for reporting it.

bug#14691: Acknowledgement (24.3; auto-save-list)

[Juanma Barranquero]

On Sat, Jun 29, 2013 at 10:35 PM, Glenn Morris <rgm@gnu.org> wrote:

> No, it's an Emacs bug that we should fix.

Presumably is nothing harder than

=== modified file 'src/emacs.c'
--- src/emacs.c 2013-06-24 00:31:31 +0000
+++ src/emacs.c 2013-06-29 21:18:32 +0000
@@ -1864,7 +1864,11 @@
      kill it because we are exiting Emacs deliberately (not crashing).
      Do it after shut_down_emacs, which does an auto-save.  */
   if (STRINGP (Vauto_save_list_file_name))
-    unlink (SSDATA (Vauto_save_list_file_name));
+    {
+      Lisp_Object listfile;
+      listfile = Fexpand_file_name (Vauto_save_list_file_name, Qnil);
+      unlink (SSDATA (listfile));
+    }

   if (INTEGERP (arg))
     exit_code = (XINT (arg) < 0

bug#14691: Acknowledgement (24.3; auto-save-list)

[Juanma Barranquero]

On Sat, Jun 29, 2013 at 11:19 PM, Juanma Barranquero <lekktu@gmail.com> wrote:

> Presumably is nothing harder than
>
> === modified file 'src/emacs.c'
> --- src/emacs.c 2013-06-24 00:31:31 +0000
> +++ src/emacs.c 2013-06-29 21:18:32 +0000

I've commited this in revno:113246