From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Myhrberg Newsgroups: gmane.emacs.bugs Subject: bug#43532: [feature/native-comp] *.eln file name hashing, algorithm doesn't seem to play nice with NATIVE_FULL_AOT and self-contained, Emacs.app builds for macOS Date: Sun, 4 Oct 2020 20:54:11 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40667"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43532@debbugs.gnu.org, aloxafx@gmail.com To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 04 21:55:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPA6W-000AS5-2X for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 21:55:32 +0200 Original-Received: from localhost ([::1]:38324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPA6V-0001Gr-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 15:55:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPA62-0001G4-KK for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 15:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35296) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPA62-0003cX-0R for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 15:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPA62-0002YH-00 for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 15:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Myhrberg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Oct 2020 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43532 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 43532@debbugs.gnu.org, Aloxaf Original-Received: via spool by 43532-submit@debbugs.gnu.org id=B43532.16018412709760 (code B ref 43532); Sun, 04 Oct 2020 19:55:01 +0000 Original-Received: (at 43532) by debbugs.gnu.org; 4 Oct 2020 19:54:30 +0000 Original-Received: from localhost ([127.0.0.1]:46841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPA5W-0002XH-HL for submit@debbugs.gnu.org; Sun, 04 Oct 2020 15:54:30 -0400 Original-Received: from mail-oi1-f193.google.com ([209.85.167.193]:40388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPA5U-0002Ww-Mv for 43532@debbugs.gnu.org; Sun, 04 Oct 2020 15:54:28 -0400 Original-Received: by mail-oi1-f193.google.com with SMTP id m128so6739882oig.7 for <43532@debbugs.gnu.org>; Sun, 04 Oct 2020 12:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jimeh-me.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fYziEapD65ilIEWr3fLjygZq2koKDTxt/FHYLxQFPC0=; b=fOjEe5XB20tscxqtypRfUjWhlFdbma2a+oL5bEhSta9dIz25RSxoszRXF1pWGHlX5E w5OjkXWbvxKwPLVLYb+C176GRu5+5u11cKX7+VHzA3Pm+1IrjDiNOFyQctRJkHtreGlv miy/3laFtFm6uBqQfWbbgsh1vM1XU0c1vGpG+XcnakD+Sy+YZHaCGN898xUiuuZYVJYi LAqwxmiiIDxz+/kRnZgBz4Oqcvwzx26hSdVKsQDdUlYFDeSGTjF/FzY7KrUlg0QpXtgB hDcexqThb8QY8dT6rga29bRbcxWroMy4zUSicfgHhH7h+AKJA+yo60KPnF9ogch+GGfg 9M3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fYziEapD65ilIEWr3fLjygZq2koKDTxt/FHYLxQFPC0=; b=BDtXhd2HbdEifYakcqNJ8N4qw+buAkOi4u2Grj6f1DzEY/Jh+8tFxgphGPFME72vw2 mfsI//EwylENzO5JSoLLnxtBwMurE9HOEl2v/yYYHsYfRBK739lKam5XwMaheZ9RBATb fVM2yPus6eE+dhsrmGjsXRawz/EcF+x7GU34T8QJnL4x7p7ERLviSpnN1+fhlhyU9Jaf 6Z5kQfqYDUcAUzPpt8YO+5rnnDV76FCZq5oONZKDVsjSfoylQAxCbS09vCSaAeJgr599 gH0xyL1ov5wBJGR/0ejNRQut9piWBHh1THJgTXGufJuO8pj+Yc66OIbv5vgb9KgSNyI4 rJGg== X-Gm-Message-State: AOAM5319DFuS0D5PUMLiu3ncs3dhTxT2L5vYZ0PCxPlkpN5lp31p05ly GGqCnFIHYWkuJwCMih6KThvv7Dl2aqTbNCRKrHzUDQ== X-Google-Smtp-Source: ABdhPJwiSWJciVayN/3VY58fBc4iXHYAGYEvs4tvD4iBBd/a/dCdYeqyI25VvWmIz9xD0pIJ6xVNaKo8Vvcy2Olw9ME= X-Received: by 2002:a05:6808:1c8:: with SMTP id x8mr6893171oic.100.1601841262537; Sun, 04 Oct 2020 12:54:22 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189769 Archived-At: Thanks Andrea, I just created a build from commit 44ef243, and it did not work out quite as expected :) Is there anything extra I should do/pass in to make it work? Cause right now it seems to have taken the string "{lispdirrel}" literally without any replacement, as there's a folder called exactly that directly within the application bundle with most things I'd normally expect to find in "Contents/Resources". To illustrate with a screenshot to avoid any possible confusion: https://share.jimeh.me/Screen-Shot-2020-10-04-20-47-12.95-goSgK6urIRqD.png And this is what it's supposed to look like: https://share.jimeh.me/Screen-Shot-2020-10-04-20-48-18.29-gd8o91tZcuLj.png And for good measure, here's what I believe are the relevant things from src/epaths.h: #define PATH_LOADSEARCH "/Users/jimeh/Projects/build-emacs-for-macos/sources/emacs-mirror-emacs-44ef243/nextstep/Emacs.app/{lispdirrel}/lisp" #define PATH_REL_LOADSEARCH "Contents/Resources" #define PATH_DUMPLOADSEARCH "/Users/jimeh/Projects/build-emacs-for-macos/sources/emacs-mirror-emacs-44ef243/lisp" On Sun, Oct 4, 2020 at 7:04 PM Andrea Corallo wrote: > > Hi Aloxaf, > > I believe the following should fix the issue: > > afb765ab3c * Make filename hashing compatible with self contained builds (bug#43532) > > No additional parameter is needed. > > Could you check and confirm works for you? > > Cc-ing Jim to kindly check does not break the same functionality on > MacOS. > > Thanks! > > Andrea >