From: Joan Karadimov <joan.karadimov@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Simon Morgan <sjm@sjm.io>,
Bozhidar Batsov <bozhidar.batsov@gmail.com>,
15983@debbugs.gnu.org
Subject: bug#15983: 24.3; Emacs Not Killing Child Process
Date: Sun, 22 Dec 2013 04:03:12 +0200 [thread overview]
Message-ID: <CAGVACNUpYWH3RsxUHiqdNnc+WP5jwSU8MqmfP2Wm4KbmG7ZWKA@mail.gmail.com> (raw)
In-Reply-To: <834n629hhz.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]
>
> > I am aware that 'taskkill' is not present on windowses (is that a word?)
> > older than XP. This makes it no worse than 'CreateToolhelp32Snapshot'.
>
> No, the toolhelp functions are available on Windows 2000 and even on
> Windows 98. They are unavailable only on NT 4.0.
>
MSDN states that the "Minimum supported client" is XP. I guess 2000 is
counted with the server ones and 9x is not even considered.
> > > This might be "good enough" -- we err on the safe side, and only leave
> > > some subprocesses not killed in rare situations. Does this strategy
> > > solve the problem which started this bug report?
>
> You didn't answer that question, but I assume the answer is YES.
>
It should fix the problem, yes. And it should be safe
> I think it would be better to also require that process-start-time is
> before the time kill-process-tree is called. This might miss some
> children, if they happen to be spawned right after the call, but it is
> safer.
>
This should already be reflected in the requirement that all processes that
are killed were already in the initial-process-tree (the first snapshot).
But there is no harm in being more explicit about it in the code.
Also, didn't you mean ">" in the above inequality? A child process
> cannot be born before its parent, right? Or am I missing something?
>
Yes, of course. You are not missing anything.
> The only thing that we should worry about is not to accidentally kill
> unrelated processes. Everything else is no worse than what we have
> now.
>
I'll start working on some code that I can show, then.
[-- Attachment #2: Type: text/html, Size: 2924 bytes --]
next prev parent reply other threads:[~2013-12-22 2:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 17:47 bug#15983: 24.3; Emacs Not Killing Child Process sjm
2013-11-27 21:02 ` Eli Zaretskii
2013-12-19 15:44 ` Joan Karadimov
2013-12-19 15:56 ` bug#15983: Fw: " Bozhidar Batsov
2013-12-19 17:24 ` Eli Zaretskii
2013-12-20 22:28 ` Joan Karadimov
2013-12-21 8:15 ` Eli Zaretskii
2013-12-21 16:22 ` Joan Karadimov
2013-12-21 18:38 ` Eli Zaretskii
2013-12-22 2:03 ` Joan Karadimov [this message]
2013-12-22 3:53 ` Eli Zaretskii
2013-12-23 16:02 ` Joan Karadimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGVACNUpYWH3RsxUHiqdNnc+WP5jwSU8MqmfP2Wm4KbmG7ZWKA@mail.gmail.com \
--to=joan.karadimov@gmail.com \
--cc=15983@debbugs.gnu.org \
--cc=bozhidar.batsov@gmail.com \
--cc=eliz@gnu.org \
--cc=sjm@sjm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.