From: Alexander Vorobiev <alexander.vorobiev@gmail.com>
To: Fabrice Popineau <fabrice.popineau@supelec.fr>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-compat: Support for getting data from Windows clipboard
Date: Mon, 18 Nov 2013 22:53:16 -0600 [thread overview]
Message-ID: <CAGOCFPVWdw4ZOJiQ27g8cQA597KGtiO9eBJwFVV1Gwyh7u96dg@mail.gmail.com> (raw)
In-Reply-To: <CAFgFV9O7QZO5wUBtRu7DweRFdw3ahKQH9EgqUKmS5geGUYsmjg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]
I too was thinking of making the change to org-get-x-clipboard-compat
instead, but somehow decided not to. It calls x-get-selection and the
latter, while it does have w32-specific flavor (in w32-common-fns.el),
doesn't seem to support clipboard and its primary purpose is stated as "Fix
interface to (X-specific) mouse.el."
As far as org-no-properties goes, I don't think it will make any difference
on Windows because it looks like only plain text is supported (see e.g.
http://www.mail-archive.com/help-emacs-windows@gnu.org/msg03026.html and
the code in http://git.savannah.gnu.org/cgit/emacs.git/tree/src/w32select.c)
anyway. So it is hard to say where the patch clearly belongs
(w32-common-fns.el (x-get-selection) perhaps?). I can move it to
org-get-x-clipboard-compat of course but some change would still need to be
done to org-get-x-clipboard because it checks for (eq window-system 'x)
explicitly. Let me know what works better.
Thanks
Alex
On Mon, Nov 18, 2013 at 5:34 AM, Fabrice Popineau <
fabrice.popineau@supelec.fr> wrote:
> Yes, you could lift the patch up to `org-get-x-clipboard-compat',
> but this way, òrg-no-properties' would be applied to the w32 data too.
> Is that relevant? I don't know if w32 clipboard data can have text
> properties.
>
> Fabrice
>
>
> 2013/11/18 Bastien <bzg@gnu.org>
>
>> Hi Alexander,
>>
>> Alexander Vorobiev <alexander.vorobiev@gmail.com> writes:
>>
>> > Sorry for the mis-formatting. Here is the patch as an attachment.
>>
>> Thanks -- digging into this again, maybe we need to fix
>> `org-get-x-clipboard-compat' directly?
>>
>> I'm not using Windows so I can't test the patch.
>>
>> Can a Windows user help here?
>>
>> --
>> Bastien
>>
>>
>
>
> --
> Fabrice Popineau
> -----------------------------
> SUPELEC
> Département Informatique
> 3, rue Joliot Curie
> 91192 Gif/Yvette Cedex
> Tel direct : +33 (0) 169851950
> Standard : +33 (0) 169851212
> ------------------------------
>
>
[-- Attachment #2: Type: text/html, Size: 4548 bytes --]
next prev parent reply other threads:[~2013-11-19 4:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 0:42 [PATCH] org-compat: Support for getting data from Windows clipboard Alexander Vorobiev
2013-11-17 8:20 ` Bastien
2013-11-18 0:31 ` Alexander Vorobiev
2013-11-18 9:25 ` Bastien
2013-11-18 11:34 ` Fabrice Popineau
2013-11-19 4:53 ` Alexander Vorobiev [this message]
2013-11-19 9:40 ` Bastien
2013-11-21 23:21 ` Alexander Vorobiev
2013-11-22 9:54 ` Bastien
2013-11-24 21:37 ` Alexander Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGOCFPVWdw4ZOJiQ27g8cQA597KGtiO9eBJwFVV1Gwyh7u96dg@mail.gmail.com \
--to=alexander.vorobiev@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=fabrice.popineau@supelec.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.