From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.bugs Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status' Date: Sat, 1 Oct 2016 15:09:33 +0200 Message-ID: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1475327492 2373 195.159.176.226 (1 Oct 2016 13:11:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Oct 2016 13:11:32 +0000 (UTC) Cc: Stefan Monnier , 24555@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 01 15:11:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqK4S-0007CN-Q2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 15:11:17 +0200 Original-Received: from localhost ([::1]:55814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqK4R-00011q-B5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 09:11:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqK4I-00010R-Gz for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 09:11:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqK4E-0006ZQ-Fh for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 09:11:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqK4E-0006ZM-CM for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 09:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqK4E-0002Ea-7R for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 09:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philippe Vaucher Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2016 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24555-submit@debbugs.gnu.org id=B24555.14753274108524 (code B ref 24555); Sat, 01 Oct 2016 13:11:02 +0000 Original-Received: (at 24555) by debbugs.gnu.org; 1 Oct 2016 13:10:10 +0000 Original-Received: from localhost ([127.0.0.1]:40410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqK3O-0002DQ-G1 for submit@debbugs.gnu.org; Sat, 01 Oct 2016 09:10:10 -0400 Original-Received: from mail-ua0-f171.google.com ([209.85.217.171]:35709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqK3N-0002DE-At for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 09:10:09 -0400 Original-Received: by mail-ua0-f171.google.com with SMTP id q42so116452986uaq.2 for <24555@debbugs.gnu.org>; Sat, 01 Oct 2016 06:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Sdoi4AwlAbkbuGiEWwCsy0AaPI2/Awqr78mVSeu0Jmo=; b=Ot4sVEPdGPydGw69LdvmwWyrg82zj99GjxGkEPheNPLhfI0RyEM7HuMvBTzimnt6/w 2kby5FyvCDkU9Y8ICuHYT+gmjb8pDPHyt7e2THMuGql2DOA6fE0Xb07yWluqrF/TXD7+ rKoGOMNE4LP3N+zPwAbtxRiKB4VXaBNhUDoahWlMNOIBKwYxOduj+B86k2qB5Pfc6qB5 u9rPRI5JoGYvmgg/3iKicKWkEVJTud/Vb5GRx7xiBA5OsappIwRjZpwQiqHgy7Ih0Mlt CEIXBlziz3RVty7IobiqAoZGEHz+8iwAAO9h0rsXWNjm3L2SnXSCiSv9j30UlnOnGcoq CkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Sdoi4AwlAbkbuGiEWwCsy0AaPI2/Awqr78mVSeu0Jmo=; b=i8Lkh1C7oI//54FfZjyg1Kww4i2BUKGCUrd1s9SHwIfuWns1/LxrhTXS3KXweY3GYy 0G5MWLFiTnbA4bh78UPguPXpy6uNHrzdID0Ef0ACU6/FESbYsc40oDHPVCWEi8tZfLbH dQjEFDylThwQQeQ9CoHlbi18mYJpr/dzau2mK12HNNcZtp6SMXI1MykAcFB9MxEfqGt8 tfDMz9B8PhTjQZ+iQUY4M7o/m4SiBdSgUFAceMYPH71kep9JXPgM8pm1s9jpM7FciW5w WD/Q6R9qKxs3mDXcBA9c342WdZlKFRoRnDtASY9Xzv277VkUU9KuxAikcNfGf8QslND2 +cAQ== X-Gm-Message-State: AA6/9RldJNDZh6nKSpitMGORdjyDlll7eWfAiVMq8S3caFxtWg4nJ75fm96f2SsfX/EKZyrGfxZWkj/7qBJM2g== X-Received: by 10.176.86.23 with SMTP id y23mr8478125uaa.8.1475327403951; Sat, 01 Oct 2016 06:10:03 -0700 (PDT) Original-Received: by 10.103.0.197 with HTTP; Sat, 1 Oct 2016 06:09:33 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123844 Archived-At: >> Philippe, can you do this, please? It should be done on the emacs-25 >> branch, since the specbind was deleted in 25.1. Okay, here we go. https://github.com/Silex/emacs/compare/emacs-25~2...Silex:emacs-25 https://github.com/Silex/emacs/commit/c8566ff77a347e7efc4cb2819cd7f58b68876e6f.patch https://github.com/Silex/emacs/commit/e34b40dc4d12a0d806e59ccbf682b0980480ff88.patch What is your prefered way to receive patches? --- src/callint.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/callint.c b/src/callint.c index 053ee6c..4652151 100644 --- a/src/callint.c +++ b/src/callint.c @@ -837,7 +837,10 @@ invoke it. If KEYS is omitted or nil, the return value of kset_last_command (current_kboard, save_last_command); { - Lisp_Object val = Ffuncall (nargs, args); + Lisp_Object val; + specbind (Vcommand_debug_status, Qnil); + + val = Ffuncall (nargs, args); val = unbind_to (speccount, val); SAFE_FREE (); return val; --- doc/lispref/debugging.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi index 2f83b40..322acd0 100644 --- a/doc/lispref/debugging.texi +++ b/doc/lispref/debugging.texi @@ -654,6 +654,8 @@ invocation. The advantage of using this variable rather than an ordinary global variable is that the data will never carry over to a subsequent command invocation. + +This variable is obsolete and should be removed in future versions. @end defvar @defun backtrace-frame frame-number