From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.devel Subject: Re: ELPA policy (was: Imports / inclusion of s.el into Emacs) Date: Sat, 9 May 2020 12:42:01 +0200 Message-ID: References: <0c88192c-3c33-46ed-95cb-b4c6928016e3@default> <83zhaij4qn.fsf@gnu.org> <838si1h7m5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="73930"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 09 12:43:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXMwr-000J7b-66 for ged-emacs-devel@m.gmane-mx.org; Sat, 09 May 2020 12:43:13 +0200 Original-Received: from localhost ([::1]:37192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXMwp-0007YM-Oj for ged-emacs-devel@m.gmane-mx.org; Sat, 09 May 2020 06:43:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXMwB-000741-T7 for emacs-devel@gnu.org; Sat, 09 May 2020 06:42:31 -0400 Original-Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:44755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXMwB-0007gL-1z; Sat, 09 May 2020 06:42:31 -0400 Original-Received: by mail-lj1-x22c.google.com with SMTP id a21so4315442ljj.11; Sat, 09 May 2020 03:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xrv83srgz2vUbi7L/oA7Qr3ALvIwnVsnQvmEqSe6pF0=; b=eocLm98cj6IF0xC2gwsqgUBBbQc2lcmAcS7fHSppdeWvzhHzKMa9v09bqGyD8m3l2j WBNy8bdXGbu0LOVlAHRqmKks6cquPzp5unl/LkNHrHJOYy1dgSMW4thK/KcUiXrsveRq Z5YDi7ZYrA+/WX5JeoaslOb2gub8vgCVyVqH6oBVFJDLgU6TD64WJ7ImJc1wML11YGbm LFGBiQIqtnZpjwqodZSGgzXnCnYfEoPV0rdrQqEDKN0NF0n+8KzhdZJQPVjqHfT9ciib zHE74DGmnNsF0dz3NznKvx4gxtCOtB9GRdFI/KPdu6XiyWAhfe6uRlSUqAn5ZQ387eXK KUAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xrv83srgz2vUbi7L/oA7Qr3ALvIwnVsnQvmEqSe6pF0=; b=RtOBeGzUXyr9lqcPjSBGzYpB9NPWh6V1gjwB0+OV/1unMNBAfOf8FXvdSsJ0dIa5QN YzwtLw5s5Gs4sIGSH7UCmPlsPsup2zC9drcxbFIuNObKANtOSgFbubV+7eOECagzop4j gSX8l2sWS7l0iU4Enjb6VAuP6SE4GBIcqKwQvAeh6TJZwiDxwO4+De6KsK/j69cjdX6p ptWLkDVFGqQ1g/eigKjFX3dvzaGF9BTMx0CxTzBdirYG3idSdX0nXntIp0jjrmfsuX5Q 3CUKZ94IIRgH5dJpOftfkIn6WGgJz2E4fiMOXGOfDzx8fZu77Q9j9QJsLElKmiF91o5/ U8Aw== X-Gm-Message-State: AOAM531rQtamf9wqY5py80UTynXKEgcvKDIDLGySkV02yijVlyRblp02 5NsQCcKKCB4lljlhRgcNuZcd3BpDTgA3UpvsFtrt2bhyZTc= X-Google-Smtp-Source: ABdhPJzEpS0qXBZH4XNzTfkQzBQvQBByt1I9JzITjRAGoyXy4QRdP9L+YRQNmi3lEdc9viJ5K7B5OloDA12Hjsp4kFU= X-Received: by 2002:a05:651c:c8:: with SMTP id 8mr4200702ljr.182.1589020948345; Sat, 09 May 2020 03:42:28 -0700 (PDT) In-Reply-To: <838si1h7m5.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::22c; envelope-from=philippe.vaucher@gmail.com; helo=mail-lj1-x22c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249394 Archived-At: > > > So maybe it's time we defined the minimum requirements for packages to > > > be included in ELPA? > > > > Why not simply use MELPA's one? > > > > https://github.com/melpa/melpa/blob/master/CONTRIBUTING.org > > I'd prefer to start from our CONTRIBUTE, since (AFAIU) GNU ELPA is > supposed to be part of the Emacs project. Commonality of requirements > is important IMO to make it easier to contribute a package: we could > then decide relatively easily whether to add the package to core or to > ELPA. Sure, but from a quick look at it CONTRIBUTE lacks a lot of what https://github.com/melpa/melpa/blob/master/CONTRIBUTING.org#making-your-package-ready-for-inclusion proposes and would make sense for inclusion in ELPA. I'll copy the relevant parts of that section here: - Coding style and conventions: The Emacs Lisp files should follow the Emacs Lisp conventions and the Emacs Lisp Style Guide. - Package metadata: Package descriptions should adhere to the package.el format as specified by (info "(elisp) Packaging") documentation. More information on this format is provided by the marmalade package manual. - Use quality-checking tools: Use flycheck, package-lint and flycheck-package to help you identify common errors in your package metadata. Use checkdoc to make sure that your package follows the conventions for documentation strings. - Avoid long functions: The longer a function the harder it is for a MELPA maintainer to understand what is happening and to give feedback. It is also much harder to point to a specific portion of the code we believe could be improved. Please spend time decomposing your long functions into smaller, well-named and documented, ones. I'm sure that if we read the MELPA recommendations more in depth we'd find even more inspiration as to what ELPA's policy could be.