From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.bugs Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status' Date: Sun, 2 Oct 2016 21:41:18 +0200 Message-ID: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114ddc0aaed1e4053de7045d X-Trace: blaine.gmane.org 1475437357 14747 195.159.176.226 (2 Oct 2016 19:42:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Oct 2016 19:42:37 +0000 (UTC) Cc: Stefan Monnier , 24555@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 02 21:42:33 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqmeP-0001e2-4R for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 21:42:17 +0200 Original-Received: from localhost ([::1]:60626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqmeN-0006Xu-OE for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 15:42:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqmeH-0006Xm-3Q for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 15:42:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqmeB-0003aF-36 for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 15:42:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqmeB-0003Zy-01 for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 15:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqmeA-00025c-9q for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 15:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philippe Vaucher Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2016 19:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24555-submit@debbugs.gnu.org id=B24555.14754373158018 (code B ref 24555); Sun, 02 Oct 2016 19:42:02 +0000 Original-Received: (at 24555) by debbugs.gnu.org; 2 Oct 2016 19:41:55 +0000 Original-Received: from localhost ([127.0.0.1]:42245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqme3-00025G-HB for submit@debbugs.gnu.org; Sun, 02 Oct 2016 15:41:55 -0400 Original-Received: from mail-vk0-f48.google.com ([209.85.213.48]:35431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqme2-000251-C5 for 24555@debbugs.gnu.org; Sun, 02 Oct 2016 15:41:54 -0400 Original-Received: by mail-vk0-f48.google.com with SMTP id 192so144662751vkl.2 for <24555@debbugs.gnu.org>; Sun, 02 Oct 2016 12:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZO5vmx1MgJ1gg39gtcfmrJZo+niV6twV7Xf0oTS8b4c=; b=RmFR0KuwcWP08in+FGWOTtVO4jIECpztfdfYy5dkhd77ponTeTW0lX+yYu7RvVk/mq uoLhKjOiSr87Y/fyLdujqn8Z5TPJI6ObwHOqxLLNoYTpFGsg6u6eE0WzfQh3BDUzlyZC U4uOc1E4anPeyWPcmqNkw5q6hOZmvQ26uJMpGEVm5SGyTrZ2E4mh3C07VIfo/0u7aoRf TsL16O/dig6QYVKAP8V5GZC6NoXetghr47NQ8HgAk3mMEVo0ggDSx8gu9pZANk6G7mJb WeiPOB06b9EVZ57fb+zYbi6aRYmWYi0PcSbi4uS1i5jFWM2hF/xeJhhFOww24MGZSEzr DytA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZO5vmx1MgJ1gg39gtcfmrJZo+niV6twV7Xf0oTS8b4c=; b=jcQ8u3qoc252ErY+bmlML3rTkYMBCVNNXXx8hJrajnuEB0b1syZL5xvbKZka69TIS4 DZq7RkZyxP8XJIePAVK6hunwaJDOccLdwh5pVx8FWSKpAv2gkWWtpgSmclqeXNtVuc7H gioCNN7a2r9kcgOHytcmhGe8uG0aDVITkbJJfmB0bshcqLEWEURGrVif9eFZIwsc/bcA BIflImALIou0fPcDxLV67r8Y6uVdT9zlfJq8ixuBuhGH1wzcQFBgsVf+TBx3W6Y2k5uG yKAoNfNDAdrUNvJ4A66DNhvQrI3PaR6plvQ+Rl1IvlOR7rwA9sEssu+nXaqfCT9SvSx1 whxg== X-Gm-Message-State: AA6/9RkbaAK+gGKoSD9Ri2+l/OIKcq+nPYKiR9fp8y0sAWRmtzJ15e8nTSvzzO0bQZIX08o/LUsydaGsNFHUkA== X-Received: by 10.31.76.5 with SMTP id z5mr11999316vka.69.1475437308822; Sun, 02 Oct 2016 12:41:48 -0700 (PDT) Original-Received: by 10.103.0.197 with HTTP; Sun, 2 Oct 2016 12:41:18 -0700 (PDT) In-Reply-To: <83bmz4klyc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123920 Archived-At: --001a114ddc0aaed1e4053de7045d Content-Type: multipart/alternative; boundary=001a114ddc0aaed1e0053de7045b --001a114ddc0aaed1e0053de7045b Content-Type: text/plain; charset=UTF-8 > > > 1 Where should I make the `make-obsolete-variable` call (in which file)? > Given it's defined in callint.c it's not > > really obvious in which .el it should go. > > I'd say in subr.el; there's a bunch of those there already. > > > 2 I don't have a "current name". Should I make CURRENT-NAME something > like "This variable will be > > removed in the future"? Should I pass "nil"? > > The former, but I think the string should start with a lower-case > letter, as it will be displayed after the standard text saying the > variable is obsolete. I suggest to experiment with different strings > and find the one which makes the most sense. > > > 3 What WHEN release number should I use? 25.2 ? > > Yes, 25.2. > Okay, here attached are the patches. Philippe --001a114ddc0aaed1e0053de7045b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
> 1 Where should I make the `make-obsolete-va= riable` call (in which file)? Given it's defined in callint.c it's = not
>=C2=A0 really obvious in which .el it should go.

I'd say in subr.el; there's a bunch of those there already.<= br>
> 2 I don't have a "current name". Should I make CURRENT-N= AME something like "This variable will be
>=C2=A0 removed in the future"? Should I pass &quo= t;nil"?

The former, but I think the string should start with a lower-case letter, as it will be displayed after the standard text saying the
variable is obsolete.=C2=A0 I suggest to experiment with different strings<= br> and find the one which makes the most sense.

> 3 What WHEN release number should I use? 25.2 ?

Yes, 25.2.

Okay, here attached are the = patches.

Philippe

=
--001a114ddc0aaed1e0053de7045b-- --001a114ddc0aaed1e4053de7045d Content-Type: text/x-patch; charset=US-ASCII; name="0001-Restore-command-debug-status-functionality.patch" Content-Disposition: attachment; filename="0001-Restore-command-debug-status-functionality.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itt191g20 RnJvbSAzZDZhZDc5NjBhNDAxNjAyMjIwZTQ4N2FiMjBlYzU4MmY2NjYwOWMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogU2F0LCAxIE9jdCAyMDE2IDEzOjExOjEzICswMjAwClN1YmplY3Q6IFtQ QVRDSCAxLzJdIFJlc3RvcmUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMgZnVuY3Rpb25hbGl0eQoKLS0t CiBzcmMvY2FsbGludC5jIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxsaW50LmMgYi9zcmMvY2FsbGlu dC5jCmluZGV4IDA1M2VlNmMuLjQ2NTIxNTEgMTAwNjQ0Ci0tLSBhL3NyYy9jYWxsaW50LmMKKysr IGIvc3JjL2NhbGxpbnQuYwpAQCAtODM3LDcgKzgzNywxMCBAQCBpbnZva2UgaXQuICBJZiBLRVlT IGlzIG9taXR0ZWQgb3IgbmlsLCB0aGUgcmV0dXJuIHZhbHVlIG9mCiAgIGtzZXRfbGFzdF9jb21t YW5kIChjdXJyZW50X2tib2FyZCwgc2F2ZV9sYXN0X2NvbW1hbmQpOwogCiAgIHsKLSAgICBMaXNw X09iamVjdCB2YWwgPSBGZnVuY2FsbCAobmFyZ3MsIGFyZ3MpOworICAgIExpc3BfT2JqZWN0IHZh bDsKKyAgICBzcGVjYmluZCAoVmNvbW1hbmRfZGVidWdfc3RhdHVzLCBRbmlsKTsKKworICAgIHZh bCA9IEZmdW5jYWxsIChuYXJncywgYXJncyk7CiAgICAgdmFsID0gdW5iaW5kX3RvIChzcGVjY291 bnQsIHZhbCk7CiAgICAgU0FGRV9GUkVFICgpOwogICAgIHJldHVybiB2YWw7Ci0tIAoyLjEwLjAK Cg== --001a114ddc0aaed1e4053de7045d Content-Type: text/x-patch; charset=US-ASCII; name="0002-Deprecate-variable-command-debug-status.patch" Content-Disposition: attachment; filename="0002-Deprecate-variable-command-debug-status.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itt191gi1 RnJvbSBlZTljZWZmODllZmU1ZTcxYjk1NmQ3NWY2OWNlZjZmNTBkZDZiOGFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogV2VkLCAyOCBTZXAgMjAxNiAxMjoxNDoyOCArMDIwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBEZXByZWNhdGUgdmFyaWFibGUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMKCi0tLQog ZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgfCAyICsrCiBsaXNwL3N1YnIuZWwgICAgICAgICAg ICAgICB8IDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4 aQppbmRleCAyZjgzYjQwLi4zMjJhY2QwIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9kZWJ1Z2dp bmcudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4aQpAQCAtNjU0LDYgKzY1NCw4 IEBAIGludm9jYXRpb24uCiBUaGUgYWR2YW50YWdlIG9mIHVzaW5nIHRoaXMgdmFyaWFibGUgcmF0 aGVyIHRoYW4gYW4gb3JkaW5hcnkgZ2xvYmFsCiB2YXJpYWJsZSBpcyB0aGF0IHRoZSBkYXRhIHdp bGwgbmV2ZXIgY2Fycnkgb3ZlciB0byBhIHN1YnNlcXVlbnQgY29tbWFuZAogaW52b2NhdGlvbi4K KworVGhpcyB2YXJpYWJsZSBpcyBvYnNvbGV0ZSBhbmQgc2hvdWxkIGJlIHJlbW92ZWQgaW4gZnV0 dXJlIHZlcnNpb25zLgogQGVuZCBkZWZ2YXIKIAogQGRlZnVuIGJhY2t0cmFjZS1mcmFtZSBmcmFt ZS1udW1iZXIKZGlmZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Avc3Vici5lbAppbmRleCBl OWUxOWQzLi4yNzFjZDJmIDEwMDY0NAotLS0gYS9saXNwL3N1YnIuZWwKKysrIGIvbGlzcC9zdWJy LmVsCkBAIC0xMzc3LDYgKzEzNzcsOCBAQCBpcyBjb252ZXJ0ZWQgaW50byBhIHN0cmluZyBieSBl eHByZXNzaW5nIGl0IGluIGRlY2ltYWwuIgogKG1ha2Utb2Jzb2xldGUgJ3Byb2Nlc3MtZmlsdGVy LW11bHRpYnl0ZS1wIG5pbCAiMjMuMSIpCiAobWFrZS1vYnNvbGV0ZSAnc2V0LXByb2Nlc3MtZmls dGVyLW11bHRpYnl0ZSBuaWwgIjIzLjEiKQogCisobWFrZS1vYnNvbGV0ZS12YXJpYWJsZSAnY29t bWFuZC1kZWJ1Zy1zdGF0dXMgInNob3VsZCBiZSByZW1vdmVkIGluIGZ1dHVyZSB2ZXJzaW9ucyIg IjI1LjIiKQorCiA7OyBMaXNwIG1hbnVhbCBvbmx5IHVwZGF0ZWQgaW4gMjIuMS4KIChkZWZpbmUt b2Jzb2xldGUtdmFyaWFibGUtYWxpYXMgJ2V4ZWN1dGluZy1tYWNybyAnZXhlY3V0aW5nLWtiZC1t YWNybwogICAiYmVmb3JlIDE5LjM0IikKLS0gCjIuMTAuMAoK --001a114ddc0aaed1e4053de7045d--