From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.bugs Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status' Date: Mon, 3 Oct 2016 09:37:13 +0200 Message-ID: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=94eb2c1b074e01754a053df105a7 X-Trace: blaine.gmane.org 1475481225 30474 195.159.176.226 (3 Oct 2016 07:53:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Oct 2016 07:53:45 +0000 (UTC) Cc: Stefan Monnier , 24555@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 03 09:53:40 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqy4B-0007IZ-BX for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Oct 2016 09:53:39 +0200 Original-Received: from localhost ([::1]:34736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqy49-00034X-Vi for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Oct 2016 03:53:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxp8-0008Uv-Fa for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:38:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqxp4-0001Ub-Aq for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxp4-0001UQ-82 for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqxp3-0001YQ-Ut for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philippe Vaucher Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2016 07:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24555-submit@debbugs.gnu.org id=B24555.14754802715953 (code B ref 24555); Mon, 03 Oct 2016 07:38:01 +0000 Original-Received: (at 24555) by debbugs.gnu.org; 3 Oct 2016 07:37:51 +0000 Original-Received: from localhost ([127.0.0.1]:42485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxot-0001Xx-82 for submit@debbugs.gnu.org; Mon, 03 Oct 2016 03:37:51 -0400 Original-Received: from mail-ua0-f174.google.com ([209.85.217.174]:33822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxor-0001Xj-H0 for 24555@debbugs.gnu.org; Mon, 03 Oct 2016 03:37:50 -0400 Original-Received: by mail-ua0-f174.google.com with SMTP id p25so22439495uaa.1 for <24555@debbugs.gnu.org>; Mon, 03 Oct 2016 00:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rAW3ibyj4MJlSdWVVrLCWIGERoK9i8gABpVULMTpCNE=; b=vhY6XNSUpHFZ9Iw0CLj3PYEVu2DOLoR3xoDf+VSydgOt7QWj/ZDRw4Zk+NgJ3GTIMX 2QEya8j/+qBxT2PaYHfwLnWcvIA0V89YDlIYJ5IIymFpu6yX1iAOXFY0bErAsQgfyIE8 f/y+8s2sCUD/RPOz7AnRK1S624PluEraF0hyze//VJCt/kFP5cNT+HwpN5w0dBIOFVPT f5efx2CHU9mR6DID1q0voW6TDj1onbLOYwnqPr+zI1yG0PS6Y0Al/cDbZqU7D/6xwaLO nlQb/ubWWTNB4Wm2V6Aayq0kVP+fZYsLF478se2aPdT3OEn4GddIogl7gfH5K7w57YGw 10SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rAW3ibyj4MJlSdWVVrLCWIGERoK9i8gABpVULMTpCNE=; b=k2sBaDbJwd4x/31JVrMR55ZBm0QgOKsi8SrMz2yUUB/vTozXtwihDtoVvn600gDtmw kf81Dl3MBH8shu55v4yAswqqdFf6Xz401ZHm06/6WbqeNattGjngzCtScm0sXUm6vSZq U0flel3PB3BC6n+F+Ds/DdJLmj9SQme8L6wWTj5O5pzyrFJSaHxlUf0slhfmZyv9Ji3m VQs5+v4z6uBy92HGqekHyNAga9417pFC7UuKYgrBMxb1Zx4IFcMhpBIWqO7RsEd55LWm TJFiDDzGxNjRMrlD0TG8v7eFW3+AovPSRcjxzsXQ4RHh9OY+AY7opzXCCBhrwwqVUU9L WBqw== X-Gm-Message-State: AA6/9RkN4HK2U8YpFJEcz+gwdbBS1r6l2AW9QpoZkxHI1sUrxEXmLNzc56Iv/NnwOWgeb014w0KMZROxkEwBqw== X-Received: by 10.176.84.149 with SMTP id p21mr12646496uaa.42.1475480263927; Mon, 03 Oct 2016 00:37:43 -0700 (PDT) Original-Received: by 10.103.0.197 with HTTP; Mon, 3 Oct 2016 00:37:13 -0700 (PDT) In-Reply-To: <83k2dpq517.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123945 Archived-At: --94eb2c1b074e01754a053df105a7 Content-Type: multipart/alternative; boundary=94eb2c1b074e017546053df105a5 --94eb2c1b074e017546053df105a5 Content-Type: text/plain; charset=UTF-8 > > > +This variable is obsolete and should be removed in future versions. > > I think "will be removed" is better here. > > > +(make-obsolete-variable 'command-debug-status "should be removed in > future versions" "25.2") > > And here I'd reword the message: > > "; expect it to be removed in a future version" > Here are the new patches with your modifications. Also viewable at https://github.com/Silex/emacs/compare/emacs-25~2...Silex:emacs-25 Philippe --94eb2c1b074e017546053df105a5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
> += This variable is obsolete and should be removed in future versions.

I think "will be removed" is better here.

> +(make-obsolete-variable 'command-debug-status "should be= removed in future versions" "25.2")

And here I'd reword the message:

=C2=A0 "; expect it to be removed in a future version"

Here are the new patches with your modifications.=


Ph= ilippe

--94eb2c1b074e017546053df105a5-- --94eb2c1b074e01754a053df105a7 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Restore-command-debug-status-functionality.patch" Content-Disposition: attachment; filename="0001-Restore-command-debug-status-functionality.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ittqt2zu0 RnJvbSAxNjUyNDQ3NmEyMWEwOWUwMTk1ZDJkYjM0ZTFlZDQwMDhiOTFkMzFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogU2F0LCAxIE9jdCAyMDE2IDEzOjExOjEzICswMjAwClN1YmplY3Q6IFtQ QVRDSCAxLzJdIFJlc3RvcmUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMgZnVuY3Rpb25hbGl0eQoKLS0t CiBzcmMvY2FsbGludC5jIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxsaW50LmMgYi9zcmMvY2FsbGlu dC5jCmluZGV4IDA1M2VlNmMuLjQ2NTIxNTEgMTAwNjQ0Ci0tLSBhL3NyYy9jYWxsaW50LmMKKysr IGIvc3JjL2NhbGxpbnQuYwpAQCAtODM3LDcgKzgzNywxMCBAQCBpbnZva2UgaXQuICBJZiBLRVlT IGlzIG9taXR0ZWQgb3IgbmlsLCB0aGUgcmV0dXJuIHZhbHVlIG9mCiAgIGtzZXRfbGFzdF9jb21t YW5kIChjdXJyZW50X2tib2FyZCwgc2F2ZV9sYXN0X2NvbW1hbmQpOwogCiAgIHsKLSAgICBMaXNw X09iamVjdCB2YWwgPSBGZnVuY2FsbCAobmFyZ3MsIGFyZ3MpOworICAgIExpc3BfT2JqZWN0IHZh bDsKKyAgICBzcGVjYmluZCAoVmNvbW1hbmRfZGVidWdfc3RhdHVzLCBRbmlsKTsKKworICAgIHZh bCA9IEZmdW5jYWxsIChuYXJncywgYXJncyk7CiAgICAgdmFsID0gdW5iaW5kX3RvIChzcGVjY291 bnQsIHZhbCk7CiAgICAgU0FGRV9GUkVFICgpOwogICAgIHJldHVybiB2YWw7Ci0tIAoyLjEwLjAK Cg== --94eb2c1b074e01754a053df105a7 Content-Type: text/x-patch; charset=US-ASCII; name="0002-Deprecate-variable-command-debug-status.patch" Content-Disposition: attachment; filename="0002-Deprecate-variable-command-debug-status.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ittqt3081 RnJvbSBjNjY2YWU3NThhYzU3Y2U0Njg0ZGEyNjY3ZmQ5MTJiMGFlN2JhNDI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogV2VkLCAyOCBTZXAgMjAxNiAxMjoxNDoyOCArMDIwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBEZXByZWNhdGUgdmFyaWFibGUgY29tbWFuZC1kZWJ1Zy1zdGF0dXMKCi0tLQog ZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgfCAyICsrCiBsaXNwL3N1YnIuZWwgICAgICAgICAg ICAgICB8IDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvZG9jL2xpc3ByZWYvZGVidWdnaW5nLnRleGkgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4 aQppbmRleCAyZjgzYjQwLi5jODhhMmZhIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9kZWJ1Z2dp bmcudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kZWJ1Z2dpbmcudGV4aQpAQCAtNjU0LDYgKzY1NCw4 IEBAIGludm9jYXRpb24uCiBUaGUgYWR2YW50YWdlIG9mIHVzaW5nIHRoaXMgdmFyaWFibGUgcmF0 aGVyIHRoYW4gYW4gb3JkaW5hcnkgZ2xvYmFsCiB2YXJpYWJsZSBpcyB0aGF0IHRoZSBkYXRhIHdp bGwgbmV2ZXIgY2Fycnkgb3ZlciB0byBhIHN1YnNlcXVlbnQgY29tbWFuZAogaW52b2NhdGlvbi4K KworVGhpcyB2YXJpYWJsZSBpcyBvYnNvbGV0ZSBhbmQgd2lsbCBiZSByZW1vdmVkIGluIGZ1dHVy ZSB2ZXJzaW9ucy4KIEBlbmQgZGVmdmFyCiAKIEBkZWZ1biBiYWNrdHJhY2UtZnJhbWUgZnJhbWUt bnVtYmVyCmRpZmYgLS1naXQgYS9saXNwL3N1YnIuZWwgYi9saXNwL3N1YnIuZWwKaW5kZXggZTll MTlkMy4uMjYwMDkwMSAxMDA2NDQKLS0tIGEvbGlzcC9zdWJyLmVsCisrKyBiL2xpc3Avc3Vici5l bApAQCAtMTM3Nyw2ICsxMzc3LDggQEAgaXMgY29udmVydGVkIGludG8gYSBzdHJpbmcgYnkgZXhw cmVzc2luZyBpdCBpbiBkZWNpbWFsLiIKIChtYWtlLW9ic29sZXRlICdwcm9jZXNzLWZpbHRlci1t dWx0aWJ5dGUtcCBuaWwgIjIzLjEiKQogKG1ha2Utb2Jzb2xldGUgJ3NldC1wcm9jZXNzLWZpbHRl ci1tdWx0aWJ5dGUgbmlsICIyMy4xIikKIAorKG1ha2Utb2Jzb2xldGUtdmFyaWFibGUgJ2NvbW1h bmQtZGVidWctc3RhdHVzICI7IGV4cGVjdCBpdCB0byBiZSByZW1vdmVkIGEgZnV0dXJlIHZlcnNp b24iICIyNS4yIikKKwogOzsgTGlzcCBtYW51YWwgb25seSB1cGRhdGVkIGluIDIyLjEuCiAoZGVm aW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICdleGVjdXRpbmctbWFjcm8gJ2V4ZWN1dGluZy1r YmQtbWFjcm8KICAgImJlZm9yZSAxOS4zNCIpCi0tIAoyLjEwLjAKCg== --94eb2c1b074e01754a053df105a7--