From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.bugs Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status' Date: Sat, 1 Oct 2016 18:12:06 +0200 Message-ID: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11415958b74ca6053dcffa57 X-Trace: blaine.gmane.org 1475338401 12429 195.159.176.226 (1 Oct 2016 16:13:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Oct 2016 16:13:21 +0000 (UTC) Cc: Stefan Monnier , 24555@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 01 18:13:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqMua-0002py-SV for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 18:13:17 +0200 Original-Received: from localhost ([::1]:56423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqMuZ-0000yA-Fw for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 12:13:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqMuS-0000xv-OK for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 12:13:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqMuM-0004a4-M7 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 12:13:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqMuM-0004a0-Ia for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 12:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqMuM-0006w4-E9 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philippe Vaucher Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2016 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24555-submit@debbugs.gnu.org id=B24555.147533836526636 (code B ref 24555); Sat, 01 Oct 2016 16:13:02 +0000 Original-Received: (at 24555) by debbugs.gnu.org; 1 Oct 2016 16:12:45 +0000 Original-Received: from localhost ([127.0.0.1]:41299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqMu5-0006vY-AR for submit@debbugs.gnu.org; Sat, 01 Oct 2016 12:12:45 -0400 Original-Received: from mail-vk0-f52.google.com ([209.85.213.52]:36345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqMu3-0006vL-Pv for 24555@debbugs.gnu.org; Sat, 01 Oct 2016 12:12:44 -0400 Original-Received: by mail-vk0-f52.google.com with SMTP id y190so97305294vkd.3 for <24555@debbugs.gnu.org>; Sat, 01 Oct 2016 09:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BkTOYcIot+QfGOy4jwonqwRXdlJF5NsdW+dN+YyfyvY=; b=ytJx8mtRzQAeSD+iS3+ilOnCPzAgu3TK6YI3LfFw3rVRx8uCrTr9GN94uHDn20O6Rb T/OyhLg4EfpBrZgKcwi2D/UydF+QEV0FyeAzfj33401Vb3m4j8pNFCHJHGqfxCRnVinF UuKuTbAml1LsUf2Fa9y6g6QkjoJqPkmy68hkaJmqBkQ5hOdSHE27FDM9t+9pJVtnRNSk hNL18sGOAceyj6dD/thrnOUd+ptpPvBFcJUaIQjlHLnLTCOOFGmxoj9IVYoXIlc99f4e BjO582cTuOhy2nRg0oC0JP9cUHSV6qPcxO0RAw05QJA8o71Hr4RHphDN58E/AFmE04i5 gW6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BkTOYcIot+QfGOy4jwonqwRXdlJF5NsdW+dN+YyfyvY=; b=N2vbswUngfobWLeqOpww+Y5cDWvkjgGVx5qtKhH8LTwNPCMiVGtilcNMNuC/osblVC mTwfL76UZtf9PfOncLXNJz+lmJMsT6rDwKtgvutawCr/SuJR0q/gi047RVT+G4dZUR63 o68BlmomiWd5S/sVwqdoIv2x01X6QMT6sWHll6JOGWtU+R8uygVmtH3u6+uooRCgQcmh 8xQAQ5pXJnv5i2DjNufEZ2M+ga0WT7UXQnKXsjDS+aG1BkOKiCX48SpL1ZSzgyrRpznj 5g/7YmEW5HG2h/udZpDmtKfncry2noPHchRDKAXYEP8tJihWshfS5oZxps43Q86TqHMP 7RGw== X-Gm-Message-State: AA6/9RnPLnEGu2x3VtD1VGbTdqPBHKuidThOJeBigIH9cnfkeN/jo3KRQWGY9EgimJuGwoXIVx0GjGHb1/rtzA== X-Received: by 10.31.40.138 with SMTP id o132mr9164867vko.171.1475338357392; Sat, 01 Oct 2016 09:12:37 -0700 (PDT) Original-Received: by 10.103.0.197 with HTTP; Sat, 1 Oct 2016 09:12:06 -0700 (PDT) In-Reply-To: <83k2dskqzq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123862 Archived-At: --001a11415958b74ca6053dcffa57 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > Either "git diff" with the commit log message prepended, or > "git format-patch", whatever works best for you. Alright. > I think your patch lacks the call to make-obsolete-variable. We need > that to warn users of this variable about it being obsoleted. Well, I thought about it but was not sure about various things, so I didn't do it. Here are the things I'm unsure about: (make-obsolete-variable OBSOLETE-NAME CURRENT-NAME WHEN &optional ACCESS-TYPE) Make the byte-compiler warn that OBSOLETE-NAME is obsolete. The warning will say that CURRENT-NAME should be used instead. If CURRENT-NAME is a string, that is the =E2=80=98use instead=E2=80=99 mess= age. WHEN should be a string indicating when the variable was first made obsolete, for example a date or a release number. 1. Where should I make the `make-obsolete-variable` call (in which file)? Given it's defined in callint.c it's not really obvious in which = .el it should go. 2. I don't have a "current name". Should I make CURRENT-NAME something like "This variable will be removed in the future"? Should I pass "nil"? 3. What WHEN release number should I use? 25.2 ? Thanks, Philippe --001a11415958b74ca6053dcffa57 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

> Either "git diff" with the commit log m= essage prepended, or
> "git format-patch", whatever works b= est for you.

Alright.

> I think your patch lacks the call = to make-obsolete-variable.=C2=A0 We need
> that to warn users of this= variable about it being obsoleted.

Well, I thought about it but was= not sure about various things, so I didn't do it. Here are the things = I'm unsure about:

(make-obsolete-variable OBSOLETE-NAME CURRENT-NAME WHEN &= amp;optional=C2=A0ACCESS-TYPE)

Make the byte-compiler warn that OBSO= LETE-NAME is obsolete.
The warning will say that CURRENT-NAME should be = used instead.
If CURRENT-NAME is a string, that is the =E2=80=98use inst= ead=E2=80=99 message.
WHEN should be a string indicating when the variab= le
was first made obsolete, for example a date or a release number.
<= /blockquote>
  1. Where should I make the `make-obsolete-variabl= e` call (in which file)? Given it's defined in callint.c it's not r= eally obvious in which .el it should go.
  2. I don't have a "c= urrent name". Should I make CURRENT-NAME something like "This var= iable will be removed in the future"? Should I pass "nil"?
  3. What WHEN release number should I use? 25.2 ?
Thanks,<= /div>
Philippe
--001a11415958b74ca6053dcffa57--