From: Philippe Vaucher <philippe.vaucher@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 24555@debbugs.gnu.org
Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status'
Date: Sat, 1 Oct 2016 18:12:06 +0200 [thread overview]
Message-ID: <CAGK7Mr5cmhZtZF0VOL=RY=tUbatwngbEstP27aa6rfm7ovuE=A@mail.gmail.com> (raw)
In-Reply-To: <83k2dskqzq.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
> Either "git diff" with the commit log message prepended, or
> "git format-patch", whatever works best for you.
Alright.
> I think your patch lacks the call to make-obsolete-variable. We need
> that to warn users of this variable about it being obsoleted.
Well, I thought about it but was not sure about various things, so I didn't
do it. Here are the things I'm unsure about:
(make-obsolete-variable OBSOLETE-NAME CURRENT-NAME WHEN
&optional ACCESS-TYPE)
Make the byte-compiler warn that OBSOLETE-NAME is obsolete.
The warning will say that CURRENT-NAME should be used instead.
If CURRENT-NAME is a string, that is the ‘use instead’ message.
WHEN should be a string indicating when the variable
was first made obsolete, for example a date or a release number.
1. Where should I make the `make-obsolete-variable` call (in which
file)? Given it's defined in callint.c it's not really obvious in which .el
it should go.
2. I don't have a "current name". Should I make CURRENT-NAME something
like "This variable will be removed in the future"? Should I pass "nil"?
3. What WHEN release number should I use? 25.2 ?
Thanks,
Philippe
[-- Attachment #2: Type: text/html, Size: 1439 bytes --]
next prev parent reply other threads:[~2016-10-01 16:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 12:39 bug#24555: [PATCH] Remove unused variable `command-debug-status' Philippe Vaucher
2016-09-28 14:58 ` Eli Zaretskii
2016-09-28 16:14 ` Stefan Monnier
2016-09-28 17:24 ` Philippe Vaucher
2016-09-28 20:11 ` Eli Zaretskii
2016-09-29 0:16 ` Stefan Monnier
2016-09-29 6:50 ` Philippe Vaucher
2016-09-29 15:04 ` Eli Zaretskii
2016-09-30 9:08 ` Philippe Vaucher
2016-10-01 13:09 ` Philippe Vaucher
2016-10-01 15:50 ` Eli Zaretskii
2016-10-01 16:12 ` Philippe Vaucher [this message]
2016-10-01 17:39 ` Eli Zaretskii
2016-10-02 17:08 ` Philippe Vaucher
2016-10-02 18:32 ` Noam Postavsky
2016-10-02 18:48 ` Philippe Vaucher
2016-10-02 19:41 ` Philippe Vaucher
2016-10-03 7:13 ` Eli Zaretskii
2016-10-03 7:37 ` Philippe Vaucher
2016-10-03 7:42 ` Philippe Vaucher
2016-10-04 14:43 ` Eli Zaretskii
2016-10-04 15:18 ` Philippe Vaucher
2016-10-04 15:46 ` Eli Zaretskii
2016-10-04 15:54 ` Philippe Vaucher
2016-09-28 20:05 ` Eli Zaretskii
2016-09-29 0:12 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGK7Mr5cmhZtZF0VOL=RY=tUbatwngbEstP27aa6rfm7ovuE=A@mail.gmail.com' \
--to=philippe.vaucher@gmail.com \
--cc=24555@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.