From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.devel Subject: Re: tabulated-list sort icon is reversed Date: Wed, 27 Feb 2019 21:08:15 +0100 Message-ID: References: <83a7qbtc6l.fsf@gnu.org> <83bmaqq735.fsf@gnu.org> <87d0v1lsns.fsf@fastmail.fm> <532F6D74-E21C-45A2-B85B-01133DE1E8A1@scratch.space> <6e662c5b-3d04-2157-6712-aadcb6077f2b@gmail.com> <83a7j0pzbh.fsf@gnu.org> <83sgwpm92r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000007834e10582e5bdda" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="171928"; mail-complaints-to="usenet@blaine.gmane.org" Cc: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 27 21:09:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gz5W3-000iTa-Ik for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2019 21:09:19 +0100 Original-Received: from localhost ([127.0.0.1]:50021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz5W2-0003yb-IR for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2019 15:09:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz5Vv-0003yL-5L for emacs-devel@gnu.org; Wed, 27 Feb 2019 15:09:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gz5Vs-0008Al-BV for emacs-devel@gnu.org; Wed, 27 Feb 2019 15:09:11 -0500 Original-Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:41394) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gz5VT-0007tW-QA; Wed, 27 Feb 2019 15:08:45 -0500 Original-Received: by mail-lj1-x22c.google.com with SMTP id z25so15013083ljk.8; Wed, 27 Feb 2019 12:08:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pw8KfULy0mxVwQd8992ZbzSiyf+AaPVlx622qHB2LYo=; b=oZ2w1FoVaUe9CAnHWCGC1Q9YfBcAackx54vfbMWNg63FXxZ9o3CH2PMmr0LDU51pTa VJdgCaQtzg7h1ncZ591nfEnteABa9zci/8HVAtDvRWUa6+xSg+0ivOP+ZWpST4vP8QwM XroH89nKgKVVJQQCN/MH1LYIQyE/bK1edOQBODsBSfSkXbtlL+2cit67KTgS1L+wmqec eqVefK3LFnkx3EAYzd/Ddp9ehC8iTwJhAffe+THPCPhxbKRpXDN3P84fPF2qVDUxR5ej zGHCutJcNz26t5VnZjGFCGkc7M68ZnCqVDIfiCgEBOn97dzmbIWVYPjenfYsLwyCkqyE Vqcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pw8KfULy0mxVwQd8992ZbzSiyf+AaPVlx622qHB2LYo=; b=qILlxyXTulh1dHNAvBlWXjhHytc6YOSpiV1lDVdQi4Lfk9v2WDG6S1uaO1fhHBxXsF VXP+J3NerIKgyjwBYdsbx0EGFDPWweGzsKEjGK4ykGhVdAnrH/Xb6IAGbobcPqSZ3Z8N gZZyLjM2fzBrU4BIXwpYgYmwPtpgQixplWsSNYmKtXsvkPYolrHfQrwB9Mg1aMyWlTbu nBJR0UqOBus3hu+/fdE6M0ydzvT0ZRDAzCimLva54ZbGwJ6DpN+UeHP9H3vMR+rEdVHE YGMYpSfm9RZ2SHuFkVfsOHBs8vKrc7poZLHhRvW5IPPtEFeaS0ENrF8cA4gZMScfABw4 D90A== X-Gm-Message-State: AHQUAuZyjdvVM9Tt9rnd3NuSgEk8k//Ie1J+zvAKkUYEZt6fCbCV8eYh 0uozgK9IYEd6Ofk8wD7ryHySDazWhOANvHxdcGrszRdqq7A= X-Google-Smtp-Source: APXvYqwpH4dwPrEEKHgqJfyxFjvVzWvk01a2OY1MmvC7ha3592Av9w0zFKZrCdLTQ94OKP/jdUUDhFXkY13nVTph3Kc= X-Received: by 2002:a2e:8659:: with SMTP id i25mr2514021ljj.110.1551298121437; Wed, 27 Feb 2019 12:08:41 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233676 Archived-At: --0000000000007834e10582e5bdda Content-Type: multipart/alternative; boundary="0000000000007834dd0582e5bdd8" --0000000000007834dd0582e5bdd8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Anway, good news! I'll polish the defcustom patch a little bit and > resubmit in the next days. > Okay here are two patches. The first one is "ready" and works for my usecase. The second is Cl=C3=A9ment's idea but seems to be incomplete, the two SVGs = being the same, and I'm not sure how to modify it (it displays fine but makes an error when we try to change the sorting order). It can serve as a base for later modifications, personnally I'd be satisfied with just the first patch= . Please let me know if I should modify something else, like for example the tabulated-list group definition: should tabulated-list belong to other(s) group(s)? Kind regards, Philippe --0000000000007834dd0582e5bdd8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Anway, good news! I'll polish the defc= ustom patch a little bit and resubmit in the next days.

Okay here are two patches. The first one is = "ready" and works for my usecase.

The se= cond is Cl=C3=A9ment's idea but seems to be incomplete, the two SVGs be= ing the same, and I'm not sure how to modify it (it displays fine but m= akes an error when we try to change the sorting order). It can serve as a b= ase for later modifications, personnally I'd be satisfied with just the= first patch.

Please let me know if I should modif= y something else, like for example the tabulated-list group definition: sho= uld tabulated-list belong to other(s) group(s)?

Ki= nd regards,
Philippe
--0000000000007834dd0582e5bdd8-- --0000000000007834e10582e5bdda Content-Type: text/x-patch; charset="UTF-8"; name="0001-Allow-customization-of-sort-indicators-in-tabulated-.patch" Content-Disposition: attachment; filename="0001-Allow-customization-of-sort-indicators-in-tabulated-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jsnmncbk0 RnJvbSAyMzg5YjYxYWYxMWZlNTA3NDgxYjg2Yjc4ZTJmZmQxNjRhZmUzYzRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogRnJpLCAxMCBBdWcgMjAxOCAyMTo1OToyNCArMDIwMApTdWJqZWN0OiBb UEFUQ0ggMS8yXSBBbGxvdyBjdXN0b21pemF0aW9uIG9mIHNvcnQgaW5kaWNhdG9ycyBpbiB0YWJ1 bGF0ZWQtbGlzdAoKKiBsaXNwL2VtYWNzLWxpc3AvdGFidWxhdGVkLWxpc3QuZWw6IGFkZCBjdXN0 b21pemF0aW9uIGdyb3VwLCBhZGQKICBkZWZjdXN0b21zLgotLS0KIGxpc3AvZW1hY3MtbGlzcC90 YWJ1bGF0ZWQtbGlzdC5lbCB8IDMxICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KIDEg ZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2xpc3AvZW1hY3MtbGlzcC90YWJ1bGF0ZWQtbGlzdC5lbCBiL2xpc3AvZW1hY3MtbGlzcC90 YWJ1bGF0ZWQtbGlzdC5lbAppbmRleCAxMmQwMTUxZDY3Li43MTYyMzM0ODIyIDEwMDY0NAotLS0g YS9saXNwL2VtYWNzLWxpc3AvdGFidWxhdGVkLWxpc3QuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNw L3RhYnVsYXRlZC1saXN0LmVsCkBAIC0zNiw2ICszNiwyOSBAQAogCiA7OzsgQ29kZToKIAorKGRl Zmdyb3VwIHRhYnVsYXRlZC1saXN0IG5pbAorICAiVGFidWxhdGVkLWxpc3QgY3VzdG9taXphdGlv biBncm91cC4iKQorCisoZGVmY3VzdG9tIHRhYnVsYXRlZC1saXN0LXNvcnQtaWNvbi1hc2MgIiDi lrwiCisgICJJY29uIHRvIGRpc3BsYXkgd2hlbiBzb3J0IG9yZGVyIGlzIGFzY2VuZGluZy4iCisg IDpncm91cCAndGFidWxhdGVkLWxpc3QKKyAgOnR5cGUgJ3N0cmluZykKKworKGRlZmN1c3RvbSB0 YWJ1bGF0ZWQtbGlzdC1zb3J0LWljb24tZGVzYyAiIOKWsiIKKyAgIkljb24gdG8gZGlzcGxheSB3 aGVuIHNvcnQgb3JkZXIgaXMgZGVzY2VuZGluZy4iCisgIDpncm91cCAndGFidWxhdGVkLWxpc3QK KyAgOnR5cGUgJ3N0cmluZykKKworKGRlZmN1c3RvbSB0YWJ1bGF0ZWQtbGlzdC1nbHlwaGxlc3Mt c29ydC1pY29uLWFzYyAidiIKKyAgIkdseXBobGVzcyBpY29uIHRvIGRpc3BsYXkgd2hlbiBzb3J0 IG9yZGVyIGlzIGFzY2VuZGluZy4iCisgIDpncm91cCAndGFidWxhdGVkLWxpc3QKKyAgOnR5cGUg J3N0cmluZykKKworKGRlZmN1c3RvbSB0YWJ1bGF0ZWQtbGlzdC1nbHlwaGxlc3Mtc29ydC1pY29u LWRlc2MgIl4iCisgICJHbHlwaGxlc3MgaWNvbiB0byBkaXNwbGF5IHdoZW4gc29ydCBvcmRlciBp cyBkZXNjZW5kaW5nLiIKKyAgOmdyb3VwICd0YWJ1bGF0ZWQtbGlzdAorICA6dHlwZSAnc3RyaW5n KQorCiA7OyBUaGUgcmVhc29uIGB0YWJ1bGF0ZWQtbGlzdC1mb3JtYXQnIGFuZCBvdGhlciB2YXJp YWJsZXMgYXJlCiA7OyBwZXJtYW5lbnQtbG9jYWwgaXMgdG8gbWFrZSBpdCBjb252ZW5pZW50IHRv IHN3aXRjaCB0byBhIGRpZmZlcmVudAogOzsgbWFqb3IgbW9kZSwgc3dpdGNoIGJhY2ssIGFuZCBo YXZlIHRoZSBvcmlnaW5hbCBUYWJ1bGF0ZWQgTGlzdCBkYXRhCkBAIC0xNzgsOCArMjAxLDggQEAg SWYgQURWQU5DRSBpcyBub24tbmlsLCBtb3ZlIGZvcndhcmQgYnkgb25lIGxpbmUgYWZ0ZXJ3YXJk cy4iCiAgIChsZXQgKCh0YWJsZSAobWFrZS1jaGFyLXRhYmxlICdnbHlwaGxlc3MtY2hhci1kaXNw bGF5IG5pbCkpKQogICAgIChzZXQtY2hhci10YWJsZS1wYXJlbnQgdGFibGUgZ2x5cGhsZXNzLWNo YXItZGlzcGxheSkKICAgICA7OyBTb21lIHRleHQgdGVybWluYWxzIGNhbid0IGRpc3BsYXkgdGhl IFVuaWNvZGUgYXJyb3dzOyBiZSBzYWZlLgotICAgIChhc2V0IHRhYmxlIDk2NTAgKGNvbnMgbmls ICJeIikpCi0gICAgKGFzZXQgdGFibGUgOTY2MCAoY29ucyBuaWwgInYiKSkKKyAgICAoYXNldCB0 YWJsZSA5NjUwIChjb25zIG5pbCB0YWJ1bGF0ZWQtbGlzdC1nbHlwaGxlc3Mtc29ydC1pY29uLWRl c2MpKQorICAgIChhc2V0IHRhYmxlIDk2NjAgKGNvbnMgbmlsIHRhYnVsYXRlZC1saXN0LWdseXBo bGVzcy1zb3J0LWljb24tYXNjKSkKICAgICB0YWJsZSkKICAgIlRoZSBgZ2x5cGhsZXNzLWNoYXIt ZGlzcGxheScgdGFibGUgaW4gVGFidWxhdGVkIExpc3QgYnVmZmVycy4iKQogCkBAIC0yMzEsOCAr MjU0LDggQEAgUG9wdWxhdGVkIGJ5IGB0YWJ1bGF0ZWQtbGlzdC1pbml0LWhlYWRlcicuIikKIAkJ ICAoY29uY2F0IGxhYmVsCiAJCQkgIChjb25kCiAJCQkgICAoKD4gKCsgMiAobGVuZ3RoIGxhYmVs KSkgd2lkdGgpICIiKQotCQkJICAgKChjZHIgdGFidWxhdGVkLWxpc3Qtc29ydC1rZXkpICIg4pay IikKLQkJCSAgICh0ICIg4pa8IikpKQorCQkJICAgKChjZHIgdGFidWxhdGVkLWxpc3Qtc29ydC1r ZXkpIHRhYnVsYXRlZC1saXN0LXNvcnQtaWNvbi1kZXNjKQorCQkJICAgKHQgdGFidWxhdGVkLWxp c3Qtc29ydC1pY29uLWFzYykpKQogCQkgICdmYWNlICdib2xkCiAJCSAgJ3RhYnVsYXRlZC1saXN0 LWNvbHVtbi1uYW1lIGxhYmVsCiAJCSAgYnV0dG9uLXByb3BzKSkKLS0gCjIuMTcuMQoK --0000000000007834e10582e5bdda Content-Type: text/x-patch; charset="UTF-8"; name="0002-Use-inline-images-for-sort-icons.patch" Content-Disposition: attachment; filename="0002-Use-inline-images-for-sort-icons.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jsnmncc71 RnJvbSA3YjUzNjhkNDg5ZmJjMGFhZTk5MzhlZTMzYmM4NDUzYmVkMDZjZjMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogV2VkLCAyNyBGZWIgMjAxOSAyMDozNzoxMCArMDEwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBVc2UgaW5saW5lIGltYWdlcyBmb3Igc29ydCBpY29ucwoKLS0tCiBsaXNwL2Vt YWNzLWxpc3AvdGFidWxhdGVkLWxpc3QuZWwgfCAxMiArKysrKysrKysrLS0KIDEgZmlsZSBjaGFu Z2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av ZW1hY3MtbGlzcC90YWJ1bGF0ZWQtbGlzdC5lbCBiL2xpc3AvZW1hY3MtbGlzcC90YWJ1bGF0ZWQt bGlzdC5lbAppbmRleCA3MTYyMzM0ODIyLi5mZjQzYjNhMmFlIDEwMDY0NAotLS0gYS9saXNwL2Vt YWNzLWxpc3AvdGFidWxhdGVkLWxpc3QuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3RhYnVsYXRl ZC1saXN0LmVsCkBAIC0zOSwxMiArMzksMjAgQEAKIChkZWZncm91cCB0YWJ1bGF0ZWQtbGlzdCBu aWwKICAgIlRhYnVsYXRlZC1saXN0IGN1c3RvbWl6YXRpb24gZ3JvdXAuIikKIAotKGRlZmN1c3Rv bSB0YWJ1bGF0ZWQtbGlzdC1zb3J0LWljb24tYXNjICIg4pa8IgorKGRlZmN1c3RvbSB0YWJ1bGF0 ZWQtbGlzdC1zb3J0LWljb24tYXNjIChwcm9wZXJ0aXplICIgIiAgJ2Rpc3BsYXkgKGNyZWF0ZS1p bWFnZSAiPD94bWwgdmVyc2lvbj1cIjEuMFwiIGVuY29kaW5nPVwiVVRGLThcIj8+Cis8IURPQ1RZ UEUgc3ZnIFBVQkxJQyBcIi0vL1czQy8vRFREIFNWRyAxLjEvL0VOXCIgXCJodHRwOi8vd3d3Lncz Lm9yZy9HcmFwaGljcy9TVkcvMS4xL0RURC9zdmcxMS5kdGRcIj4KKzxzdmcgeG1sbnM9XCJodHRw Oi8vd3d3LnczLm9yZy8yMDAwL3N2Z1wiIHhtbG5zOnhsaW5rPVwiaHR0cDovL3d3dy53My5vcmcv MTk5OS94bGlua1wiIHZlcnNpb249XCIxLjFcIiAgd2lkdGg9XCIyNFwiIGhlaWdodD1cIjI0XCIg dmlld0JveD1cIjAgMCAyNCAyNFwiPgorICAgPHBhdGggZmlsbD1cIiMwMDAwMDBcIiBkPVwiTTcs MTBMMTIsMTVMMTcsMTBIN1pcIiAvPgorPC9zdmc+IiAnc3ZnIHQpKQogICAiSWNvbiB0byBkaXNw bGF5IHdoZW4gc29ydCBvcmRlciBpcyBhc2NlbmRpbmcuIgogICA6Z3JvdXAgJ3RhYnVsYXRlZC1s aXN0CiAgIDp0eXBlICdzdHJpbmcpCiAKLShkZWZjdXN0b20gdGFidWxhdGVkLWxpc3Qtc29ydC1p Y29uLWRlc2MgIiDilrIiCisoZGVmY3VzdG9tIHRhYnVsYXRlZC1saXN0LXNvcnQtaWNvbi1kZXNj IChwcm9wZXJ0aXplICIgIiAgJ2Rpc3BsYXkgKGNyZWF0ZS1pbWFnZSAiPD94bWwgdmVyc2lvbj1c IjEuMFwiIGVuY29kaW5nPVwiVVRGLThcIj8+Cis8IURPQ1RZUEUgc3ZnIFBVQkxJQyBcIi0vL1cz Qy8vRFREIFNWRyAxLjEvL0VOXCIgXCJodHRwOi8vd3d3LnczLm9yZy9HcmFwaGljcy9TVkcvMS4x L0RURC9zdmcxMS5kdGRcIj4KKzxzdmcgeG1sbnM9XCJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2 Z1wiIHhtbG5zOnhsaW5rPVwiaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGlua1wiIHZlcnNpb249 XCIxLjFcIiAgd2lkdGg9XCIyNFwiIGhlaWdodD1cIjI0XCIgdmlld0JveD1cIjAgMCAyNCAyNFwi PgorICAgPHBhdGggZmlsbD1cIiMwMDAwMDBcIiBkPVwiTTcsMTBMMTIsMTVMMTcsMTBIN1pcIiAv PgorPC9zdmc+IiAnc3ZnIHQpKQogICAiSWNvbiB0byBkaXNwbGF5IHdoZW4gc29ydCBvcmRlciBp cyBkZXNjZW5kaW5nLiIKICAgOmdyb3VwICd0YWJ1bGF0ZWQtbGlzdAogICA6dHlwZSAnc3RyaW5n KQotLSAKMi4xNy4xCgo= --0000000000007834e10582e5bdda--