Re: tabulated-list sort icon is reversed

[Philippe Vaucher <philippe.vaucher@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 686 bytes --]

> Anway, good news! I'll polish the defcustom patch a little bit and
> resubmit in the next days.
>

Okay here are two patches. The first one is "ready" and works for my
usecase.

The second is Clément's idea but seems to be incomplete, the two SVGs being
the same, and I'm not sure how to modify it (it displays fine but makes an
error when we try to change the sorting order). It can serve as a base for
later modifications, personnally I'd be satisfied with just the first patch.

Please let me know if I should modify something else, like for example the
tabulated-list group definition: should tabulated-list belong to other(s)
group(s)?

Kind regards,
Philippe

[-- Attachment #1.2: Type: text/html, Size: 1086 bytes --]

[-- Attachment #2: 0001-Allow-customization-of-sort-indicators-in-tabulated-.patch --]
[-- Type: text/x-patch, Size: 2559 bytes --]

From 2389b61af11fe507481b86b78e2ffd164afe3c4a Mon Sep 17 00:00:00 2001
From: Philippe Vaucher <philippe.vaucher@gmail.com>
Date: Fri, 10 Aug 2018 21:59:24 +0200
Subject: [PATCH 1/2] Allow customization of sort indicators in tabulated-list

* lisp/emacs-lisp/tabulated-list.el: add customization group, add
  defcustoms.
---
 lisp/emacs-lisp/tabulated-list.el | 31 +++++++++++++++++++++++++++----
 1 file changed, 27 insertions(+), 4 deletions(-)

diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el
index 12d0151d67..7162334822 100644
--- a/lisp/emacs-lisp/tabulated-list.el
+++ b/lisp/emacs-lisp/tabulated-list.el
@@ -36,6 +36,29 @@
 
 ;;; Code:
 
+(defgroup tabulated-list nil
+  "Tabulated-list customization group.")
+
+(defcustom tabulated-list-sort-icon-asc " ▼"
+  "Icon to display when sort order is ascending."
+  :group 'tabulated-list
+  :type 'string)
+
+(defcustom tabulated-list-sort-icon-desc " ▲"
+  "Icon to display when sort order is descending."
+  :group 'tabulated-list
+  :type 'string)
+
+(defcustom tabulated-list-glyphless-sort-icon-asc "v"
+  "Glyphless icon to display when sort order is ascending."
+  :group 'tabulated-list
+  :type 'string)
+
+(defcustom tabulated-list-glyphless-sort-icon-desc "^"
+  "Glyphless icon to display when sort order is descending."
+  :group 'tabulated-list
+  :type 'string)
+
 ;; The reason `tabulated-list-format' and other variables are
 ;; permanent-local is to make it convenient to switch to a different
 ;; major mode, switch back, and have the original Tabulated List data
@@ -178,8 +201,8 @@ If ADVANCE is non-nil, move forward by one line afterwards."
   (let ((table (make-char-table 'glyphless-char-display nil)))
     (set-char-table-parent table glyphless-char-display)
     ;; Some text terminals can't display the Unicode arrows; be safe.
-    (aset table 9650 (cons nil "^"))
-    (aset table 9660 (cons nil "v"))
+    (aset table 9650 (cons nil tabulated-list-glyphless-sort-icon-desc))
+    (aset table 9660 (cons nil tabulated-list-glyphless-sort-icon-asc))
     table)
   "The `glyphless-char-display' table in Tabulated List buffers.")
 
@@ -231,8 +254,8 @@ Populated by `tabulated-list-init-header'.")
 		  (concat label
 			  (cond
 			   ((> (+ 2 (length label)) width) "")
-			   ((cdr tabulated-list-sort-key) " ▲")
-			   (t " ▼")))
+			   ((cdr tabulated-list-sort-key) tabulated-list-sort-icon-desc)
+			   (t tabulated-list-sort-icon-asc)))
 		  'face 'bold
 		  'tabulated-list-column-name label
 		  button-props))
-- 
2.17.1


[-- Attachment #3: 0002-Use-inline-images-for-sort-icons.patch --]
[-- Type: text/x-patch, Size: 1838 bytes --]

From 7b5368d489fbc0aae9938ee33bc8453bed06cf32 Mon Sep 17 00:00:00 2001
From: Philippe Vaucher <philippe.vaucher@gmail.com>
Date: Wed, 27 Feb 2019 20:37:10 +0100
Subject: [PATCH 2/2] Use inline images for sort icons

---
 lisp/emacs-lisp/tabulated-list.el | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el
index 7162334822..ff43b3a2ae 100644
--- a/lisp/emacs-lisp/tabulated-list.el
+++ b/lisp/emacs-lisp/tabulated-list.el
@@ -39,12 +39,20 @@
 (defgroup tabulated-list nil
   "Tabulated-list customization group.")
 
-(defcustom tabulated-list-sort-icon-asc " ▼"
+(defcustom tabulated-list-sort-icon-asc (propertize " "  'display (create-image "<?xml version=\"1.0\" encoding=\"UTF-8\"?>
+<!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 1.1//EN\" \"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd\">
+<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\"  width=\"24\" height=\"24\" viewBox=\"0 0 24 24\">
+   <path fill=\"#000000\" d=\"M7,10L12,15L17,10H7Z\" />
+</svg>" 'svg t))
   "Icon to display when sort order is ascending."
   :group 'tabulated-list
   :type 'string)
 
-(defcustom tabulated-list-sort-icon-desc " ▲"
+(defcustom tabulated-list-sort-icon-desc (propertize " "  'display (create-image "<?xml version=\"1.0\" encoding=\"UTF-8\"?>
+<!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 1.1//EN\" \"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd\">
+<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" version=\"1.1\"  width=\"24\" height=\"24\" viewBox=\"0 0 24 24\">
+   <path fill=\"#000000\" d=\"M7,10L12,15L17,10H7Z\" />
+</svg>" 'svg t))
   "Icon to display when sort order is descending."
   :group 'tabulated-list
   :type 'string)
-- 
2.17.1