all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philippe Vaucher <philippe.vaucher@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 24555@debbugs.gnu.org
Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status'
Date: Mon, 3 Oct 2016 09:42:14 +0200	[thread overview]
Message-ID: <CAGK7Mr4UUBwaKtddcuidCH8qBN78EvQbWiJwHLMVCy9S-xd-nw@mail.gmail.com> (raw)
In-Reply-To: <CAGK7Mr5ekcFUUX+rSY5jNOaD_qz=gamopo8kTRW+jnvZNqscNg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 199 bytes --]

>
> Here are the new patches with your modifications.
>
> Also viewable at https://github.com/Silex/emacs/compare/emacs-25~2...
> Silex:emacs-25
>

And again new patches without a typo :-)

Philippe

[-- Attachment #1.2: Type: text/html, Size: 694 bytes --]

[-- Attachment #2: 0001-Restore-command-debug-status-functionality.patch --]
[-- Type: text/x-patch, Size: 799 bytes --]

From 16524476a21a09e0195d2db34e1ed4008b91d31c Mon Sep 17 00:00:00 2001
From: Philippe Vaucher <philippe.vaucher@gmail.com>
Date: Sat, 1 Oct 2016 13:11:13 +0200
Subject: [PATCH 1/2] Restore command-debug-status functionality

---
 src/callint.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/callint.c b/src/callint.c
index 053ee6c..4652151 100644
--- a/src/callint.c
+++ b/src/callint.c
@@ -837,7 +837,10 @@ invoke it.  If KEYS is omitted or nil, the return value of
   kset_last_command (current_kboard, save_last_command);
 
   {
-    Lisp_Object val = Ffuncall (nargs, args);
+    Lisp_Object val;
+    specbind (Vcommand_debug_status, Qnil);
+
+    val = Ffuncall (nargs, args);
     val = unbind_to (speccount, val);
     SAFE_FREE ();
     return val;
-- 
2.10.0


[-- Attachment #3: 0002-Deprecate-variable-command-debug-status.patch --]
[-- Type: text/x-patch, Size: 1354 bytes --]

From 2ac525977746173c2dd3be552960ab0a099b4dc3 Mon Sep 17 00:00:00 2001
From: Philippe Vaucher <philippe.vaucher@gmail.com>
Date: Wed, 28 Sep 2016 12:14:28 +0200
Subject: [PATCH 2/2] Deprecate variable command-debug-status

---
 doc/lispref/debugging.texi | 2 ++
 lisp/subr.el               | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi
index 2f83b40..c88a2fa 100644
--- a/doc/lispref/debugging.texi
+++ b/doc/lispref/debugging.texi
@@ -654,6 +654,8 @@ invocation.
 The advantage of using this variable rather than an ordinary global
 variable is that the data will never carry over to a subsequent command
 invocation.
+
+This variable is obsolete and will be removed in future versions.
 @end defvar
 
 @defun backtrace-frame frame-number
diff --git a/lisp/subr.el b/lisp/subr.el
index e9e19d3..5a9543d 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -1377,6 +1377,8 @@ is converted into a string by expressing it in decimal."
 (make-obsolete 'process-filter-multibyte-p nil "23.1")
 (make-obsolete 'set-process-filter-multibyte nil "23.1")
 
+(make-obsolete-variable 'command-debug-status "; expect it to be removed in a future version" "25.2")
+
 ;; Lisp manual only updated in 22.1.
 (define-obsolete-variable-alias 'executing-macro 'executing-kbd-macro
   "before 19.34")
-- 
2.10.0


  reply	other threads:[~2016-10-03  7:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 12:39 bug#24555: [PATCH] Remove unused variable `command-debug-status' Philippe Vaucher
2016-09-28 14:58 ` Eli Zaretskii
2016-09-28 16:14   ` Stefan Monnier
2016-09-28 17:24     ` Philippe Vaucher
2016-09-28 20:11       ` Eli Zaretskii
2016-09-29  0:16         ` Stefan Monnier
2016-09-29  6:50           ` Philippe Vaucher
2016-09-29 15:04             ` Eli Zaretskii
2016-09-30  9:08               ` Philippe Vaucher
2016-10-01 13:09                 ` Philippe Vaucher
2016-10-01 15:50                   ` Eli Zaretskii
2016-10-01 16:12                     ` Philippe Vaucher
2016-10-01 17:39                       ` Eli Zaretskii
2016-10-02 17:08                         ` Philippe Vaucher
2016-10-02 18:32                           ` Noam Postavsky
2016-10-02 18:48                             ` Philippe Vaucher
2016-10-02 19:41                         ` Philippe Vaucher
2016-10-03  7:13                           ` Eli Zaretskii
2016-10-03  7:37                             ` Philippe Vaucher
2016-10-03  7:42                               ` Philippe Vaucher [this message]
2016-10-04 14:43                                 ` Eli Zaretskii
2016-10-04 15:18                                   ` Philippe Vaucher
2016-10-04 15:46                                     ` Eli Zaretskii
2016-10-04 15:54                                       ` Philippe Vaucher
2016-09-28 20:05     ` Eli Zaretskii
2016-09-29  0:12       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGK7Mr4UUBwaKtddcuidCH8qBN78EvQbWiJwHLMVCy9S-xd-nw@mail.gmail.com \
    --to=philippe.vaucher@gmail.com \
    --cc=24555@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.