From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.bugs Subject: bug#24985: Add missing provide statements Date: Tue, 22 Nov 2016 14:58:19 +0100 Message-ID: References: <8737ijlngz.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114404c0039ed70541e42cdb X-Trace: blaine.gmane.org 1479823157 11731 195.159.176.226 (22 Nov 2016 13:59:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 22 Nov 2016 13:59:17 +0000 (UTC) Cc: 24985@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 22 14:59:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9BbK-0001o2-1l for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Nov 2016 14:59:10 +0100 Original-Received: from localhost ([::1]:55827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9BbN-0007kG-0k for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Nov 2016 08:59:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9BbG-0007k7-CN for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 08:59:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9BbC-00056p-Bz for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 08:59:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50810) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9BbC-00056h-8D for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 08:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c9BbB-0007U8-Sc for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 08:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philippe Vaucher Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2016 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24985-submit@debbugs.gnu.org id=B24985.147982313828762 (code B ref 24985); Tue, 22 Nov 2016 13:59:01 +0000 Original-Received: (at 24985) by debbugs.gnu.org; 22 Nov 2016 13:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:37976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9Bb7-0007Tq-OW for submit@debbugs.gnu.org; Tue, 22 Nov 2016 08:58:57 -0500 Original-Received: from mail-vk0-f53.google.com ([209.85.213.53]:33472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9Bb5-0007Td-Tw for 24985@debbugs.gnu.org; Tue, 22 Nov 2016 08:58:56 -0500 Original-Received: by mail-vk0-f53.google.com with SMTP id 137so13552420vkl.0 for <24985@debbugs.gnu.org>; Tue, 22 Nov 2016 05:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yX5iD74kjM86BrTypNqpOdfZUjhnNCHpSGta4qg1SIU=; b=PXcnoBIHGMI0Uevqwv/jxIIaTx3IbGamOB7HbYmQkVXVgNrdV2BtMz18Z5ELp82hdv wwGw47LrTkgHj/hL1/hlyU4TaTp5GWFbCIHLmaHcPZmK3j+mOWMl4toKVw018i2nnqAr eATZ13ZMEPw8BwlVR66C+4Ox91zif1Qy1OFwylx1UYExN8I+VhtuX/J8GQJxXfQW3XwH oWLrd1Ixhvs1PZIBfhD6V/QGSClxi6LdkoSdXovaVgO0o6+3uQrC+qO05RT+MRhHI0FY nO+dF5hz4L6SuzvT9htIx0gN6DX5mzHzhhxrP40irAcZ1LdWJb+M6+BowcEkxncXimfw rJYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yX5iD74kjM86BrTypNqpOdfZUjhnNCHpSGta4qg1SIU=; b=AfEjHfqxBws2qqz0Its8KwZi1vYQe1Se5wtwPPDyoSh54Ns5EaciY+d3453IEM57lX OmQL6xw+Ru5Nlz24F0ZerdkMiZpKtwFPQNEQoGBoRaVnx4O+lrd2/IOaHcAsoGc8AYlt NeqljIpTKOcbcWGoZbroIe/UwP0rl+t6bthcZbNGzsQg/gt/KXawWeKfYKUUxxZfSSU5 lrt6+jpGqrNBrEJga6Fdj6e6rnrOK4Nya9HWABTOVMRK8AXwG1lesaYGk6LIYXypqRGt 0oMGQXA+dsaUUSL3jZW1Wdle9gw1k+KrhDmn+cAOsulT5vhHcgpMdlK6/igOTB5K0mA+ huIA== X-Gm-Message-State: AKaTC033Mz9ksysN/8F7xzMHZr5TfI/EmYwfggEGjSGx4YKFjTODQ9a0tAsiYENeNelhxD7HjiR7X2JUU87jUw== X-Received: by 10.31.172.74 with SMTP id v71mr9368208vke.150.1479823130302; Tue, 22 Nov 2016 05:58:50 -0800 (PST) Original-Received: by 10.103.72.70 with HTTP; Tue, 22 Nov 2016 05:58:19 -0800 (PST) In-Reply-To: <8737ijlngz.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125986 Archived-At: --001a114404c0039ed70541e42cdb Content-Type: multipart/alternative; boundary=001a114404c0039ed30541e42cd9 --001a114404c0039ed30541e42cd9 Content-Type: text/plain; charset=UTF-8 > > > (defalias 'toggle-auto-composition 'auto-composition-mode) > > > > +(provide 'auto-composition-mode) > > Why that? I would expect (provide 'composite) here. > I thought that the most interesting thing in composite was auto-composition-mode... same reasoning for replace.el which provided 'occur in my first patch. Anyway, you're right, it's not very consistent. Here attached is a new patch that simply follows the file name. In the future, I think we should consider renaming/splitting these files so each mode provide its feature (e.g occur provides 'occur, etc). Best regards, Philippe --001a114404c0039ed30541e42cd9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
>=C2=A0 (defalias 'toggle-auto-compositio= n 'auto-composition-mode)
>
> +(provide 'auto-composition-mode)

Why that? I would expect (provide 'composite) here.

I thought that the most interesting thing in composite was= auto-composition-mode... same reasoning for replace.el which provided '= ;occur in my first patch.

Anyway, you're right= , it's not very consistent. Here attached is a new patch that simply fo= llows the file name.

In the future, I think we sho= uld consider renaming/splitting these files so each mode provide its featur= e (e.g occur provides 'occur, etc).

Best regar= ds,
Philippe


--001a114404c0039ed30541e42cd9-- --001a114404c0039ed70541e42cdb Content-Type: text/x-patch; charset=US-ASCII; name="0001-Add-missing-provide-statements.patch" Content-Disposition: attachment; filename="0001-Add-missing-provide-statements.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ivtketgk0 RnJvbSBmODYzODNkOGZmNjgzYmM4OGExNDEwNzA4ZDhlNTJhMzNkMzhmYTY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQHN0 dnMuY29tPgpEYXRlOiBUdWUsIDIyIE5vdiAyMDE2IDA5OjM1OjIyICswMTAwClN1YmplY3Q6IFtQ QVRDSF0gQWRkIG1pc3NpbmcgcHJvdmlkZSBzdGF0ZW1lbnRzCgoqIGxpc3AvY29tcG9zaXRlLmVs OiBhZGQgcHJvdmlkZSBzdGF0ZW1lbnQKKiBsaXNwL3JlcGxhY2UuZWw6IGFkZCBwcm92aWRlIHN0 YXRlbWVudAoqIGxpc3AvdGV4dG1vZGVzL3RleHQtbW9kZS5lbDogYWRkIHByb3ZpZGUgc3RhdGVt ZW50Ci0tLQogbGlzcC9jb21wb3NpdGUuZWwgICAgICAgICAgIHwgMiArKwogbGlzcC9yZXBsYWNl LmVsICAgICAgICAgICAgIHwgMiArKwogbGlzcC90ZXh0bW9kZXMvdGV4dC1tb2RlLmVsIHwgMiAr KwogMyBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2Nv bXBvc2l0ZS5lbCBiL2xpc3AvY29tcG9zaXRlLmVsCmluZGV4IDk0YjE0ZGYuLjUzMDEzYzEgMTAw NjQ0Ci0tLSBhL2xpc3AvY29tcG9zaXRlLmVsCisrKyBiL2xpc3AvY29tcG9zaXRlLmVsCkBAIC04 NDMsNiArODQzLDggQEAgRm9yIG1vcmUgaW5mb3JtYXRpb24gb24gQXV0byBDb21wb3NpdGlvbiBt b2RlLCBzZWUKIAogKGRlZmFsaWFzICd0b2dnbGUtYXV0by1jb21wb3NpdGlvbiAnYXV0by1jb21w b3NpdGlvbi1tb2RlKQogCisocHJvdmlkZSAnY29tcG9zaXRlKQorCiAMCiAKIDs7OyBjb21wb3Np dGUuZWwgZW5kcyBoZXJlCmRpZmYgLS1naXQgYS9saXNwL3JlcGxhY2UuZWwgYi9saXNwL3JlcGxh Y2UuZWwKaW5kZXggZWI1ZTBjZi4uYWUxYzE5MiAxMDA2NDQKLS0tIGEvbGlzcC9yZXBsYWNlLmVs CisrKyBiL2xpc3AvcmVwbGFjZS5lbApAQCAtMjU0NCw0ICsyNTQ0LDYgQEAgSXQgbXVzdCByZXR1 cm4gYSBzdHJpbmcuIgogCQkgICAiIikpKQogICAgIChvciAoYW5kIGtlZXAtZ29pbmcgc3RhY2sp IG11bHRpLWJ1ZmZlcikpKQogCisocHJvdmlkZSAncmVwbGFjZSkKKwogOzs7IHJlcGxhY2UuZWwg ZW5kcyBoZXJlCmRpZmYgLS1naXQgYS9saXNwL3RleHRtb2Rlcy90ZXh0LW1vZGUuZWwgYi9saXNw L3RleHRtb2Rlcy90ZXh0LW1vZGUuZWwKaW5kZXggNzMxYzJkMi4uNTFhN2JiZSAxMDA2NDQKLS0t IGEvbGlzcC90ZXh0bW9kZXMvdGV4dC1tb2RlLmVsCisrKyBiL2xpc3AvdGV4dG1vZGVzL3RleHQt bW9kZS5lbApAQCAtMjMyLDQgKzIzMiw2IEBAIFRoZSBhcmd1bWVudCBOTElORVMgc2F5cyBob3cg bWFueSBsaW5lcyB0byBjZW50ZXIuIgogCSAgIChzZXRxIG5saW5lcyAoMSsgbmxpbmVzKSkKIAkg ICAoZm9yd2FyZC1saW5lIC0xKSkpKSkKIAorKHByb3ZpZGUgJ3RleHQtbW9kZSkKKwogOzs7IHRl eHQtbW9kZS5lbCBlbmRzIGhlcmUKLS0gCjIuMTAuMgoK --001a114404c0039ed70541e42cdb--