From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.bugs Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status' Date: Tue, 4 Oct 2016 17:18:23 +0200 Message-ID: References: <837f9woyu6.fsf@gnu.org> <83twczokd3.fsf@gnu.org> <83fuoioigw.fsf@gnu.org> <83k2dskqzq.fsf@gnu.org> <83bmz4klyc.fsf@gnu.org> <83k2dpq517.fsf@gnu.org> <83r37wmayh.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c06164623a872053e0b94f7 X-Trace: blaine.gmane.org 1475594423 13882 195.159.176.226 (4 Oct 2016 15:20:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Oct 2016 15:20:23 +0000 (UTC) Cc: Stefan Monnier , 24555-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 04 17:20:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brRVx-0002hj-2s for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 17:20:17 +0200 Original-Received: from localhost ([::1]:43607 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brRVv-0001Om-EF for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 11:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brRVp-0001NO-G6 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 11:20:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brRVj-0006UR-FU for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 11:20:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brRVj-0006UJ-CH for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 11:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1brRVj-0001F5-A8 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 11:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philippe Vaucher Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2016 15:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24555-done@debbugs.gnu.org id=D24555.14755943424667 (code D ref 24555); Tue, 04 Oct 2016 15:20:03 +0000 Original-Received: (at 24555-done) by debbugs.gnu.org; 4 Oct 2016 15:19:02 +0000 Original-Received: from localhost ([127.0.0.1]:44664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brRUk-0001D5-C9 for submit@debbugs.gnu.org; Tue, 04 Oct 2016 11:19:02 -0400 Original-Received: from mail-ua0-f174.google.com ([209.85.217.174]:34703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brRUi-0001Ci-3Y for 24555-done@debbugs.gnu.org; Tue, 04 Oct 2016 11:19:00 -0400 Original-Received: by mail-ua0-f174.google.com with SMTP id p25so61813750uaa.1 for <24555-done@debbugs.gnu.org>; Tue, 04 Oct 2016 08:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zjSzh1TaID9Lw6IY23x+pNhO2Gd1xqPTJdiu/SWgZ5w=; b=cp3h0Tgjt371Av4eBu6Sv/srRXHvn+46fclgsgtJo25qQwBO3IFV6YU25XvhQas1mx yu8j66WeT9cHyT+AXFvr9boNv6daK6hY72wHWKR3Re7nmAGh6SFRdR2LWm0yLbaSWp17 V3ALwzI8twmOE7NGirhU/GGeQCrfX/JFssSIhqPXnjgtp/PxxmrYDzjExb8SqW+yELLm PaMdcjFqaL3AFyVjZ2eWKGbBFGQjk9RV7fTfZ5aOesoHkP2zXbPB3VxuquOEpMMjOqo+ MkKVAqh8aEy2BH6gKociiOGYJKFqYanh6/ke1vjjWnOg4VFU4XviZkC6JgRqngdBEOf4 EYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zjSzh1TaID9Lw6IY23x+pNhO2Gd1xqPTJdiu/SWgZ5w=; b=b2qjViDyjkpceyWApvvWs0e1jkTP8l/NReV4R1pZXcEEttG4ikBEqUm4AtYLF2KCw5 9+q60Whmj+OdtibwEqJmEYL0uvFJyFb5xy32QbSK2BTXOChMy7WKs25jH7kBQVVR6SRH uwxPj3gockanAoGMVK018nxFVkQKopjAHcvIbrEDgNGOgI2bSWtfzo71ZkXVX3IfOnbb D9bGcNxmQkP8ELUz4xvZi8U9WVmBjiTq+RY6ZNpEa/IaUtdOuZ8DBJ3ef2YvsFv9G0uO YBY1jjgIm7qXzLX9YyO64SaeH4YKHfnwjtpI0hTG+yFsv2nIfMWRhsXUGh+AcXdror+7 ltiA== X-Gm-Message-State: AA6/9RnoUvlNb+k/09RcFSXnJRNKte/+dxLw3R5G1Wy+hfc+RhCkoGCZgVCKg48dgQZRhNXttFRctZ7npvfQBA== X-Received: by 10.176.66.199 with SMTP id j65mr2255540uaj.73.1475594334478; Tue, 04 Oct 2016 08:18:54 -0700 (PDT) Original-Received: by 10.103.0.197 with HTTP; Tue, 4 Oct 2016 08:18:23 -0700 (PDT) In-Reply-To: <83r37wmayh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124042 Archived-At: --94eb2c06164623a872053e0b94f7 Content-Type: text/plain; charset=UTF-8 > > Please note that your patch had a fatal flaw: specbind needs a > (quoted) symbol, not its value. Using Vcommand_debug_status there > produced a broken binary that would display an error message and > become unresponsive. See what I actually committed for the details. > Ah, you're right I missread the patch that removed Vcommand_debug_status and assumed "Q" variables got renamed to "V" in the emacs 25 transition. I understand now that variables and symbols are different things :-) I should have verified. > Please always test the build after you patch it, to make sure the > behavior is correct and no bugs creep in. > Yes, I should have. Sorry. > Finally, in the future please provide commit log messages for the > changes formatted in the ChanegLog style, as described in CONTRIBUTE. > I wrote them for this commit, please see the commit for the details of > the formatting we use. > Well, the commit f2144eef does not contain any ChangeLog entries... maybe you forgot to stage these changes? But yes, I understand what you mean. Regards, Philippe --94eb2c06164623a872053e0b94f7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Please note that your patch h= ad a fatal flaw: specbind needs a
(quoted) symbol, not its value.=C2=A0 Using Vcommand_debug_status there
produced a broken binary that would display an error message and
become unresponsive.=C2=A0 See what I actually committed for the details.

Ah, you're right I missread the patc= h that removed Vcommand_debug_status and assumed "Q" variables go= t renamed to "V" in the emacs 25 transition. I understand now tha= t variables and symbols are different things :-) I should have verified.

=C2=A0
Please always test the build after you patch it, to make sure th= e
behavior is correct and no bugs creep in.

Yes, I should have. Sorry.

=C2=A0
Finally, in the future please pro= vide commit log messages for the
changes formatted in the ChanegLog style, as described in CONTRIBUTE.
I wrote them for this commit, please see the commit for the details of
the formatting we use.

Well, the commit= f2144eef=C2=A0does not contain any ChangeLog entries... maybe you forgot t= o stage these changes? But yes, I understand what you mean.

<= /div>
Regards,
Philippe
--94eb2c06164623a872053e0b94f7--