Re: tabulated-list sort icon is reversed

[Philippe Vaucher <philippe.vaucher@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1160 bytes --]

On Wed, Feb 27, 2019 at 10:27 PM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> > +(defcustom tabulated-list-sort-icon-asc " ▼"
> > +(defcustom tabulated-list-sort-icon-desc " ▲"
> > +(defcustom tabulated-list-glyphless-sort-icon-asc "v"
> > +(defcustom tabulated-list-glyphless-sort-icon-desc "^"
> [...]
> > -    (aset table 9650 (cons nil "^"))
> > -    (aset table 9660 (cons nil "v"))
> > +    (aset table 9650 (cons nil tabulated-list-glyphless-sort-icon-desc))
> > +    (aset table 9660 (cons nil tabulated-list-glyphless-sort-icon-asc))
>
> [ 9650 and 9660 should really have been written ?▲ and ?▼.  ]
>
> The above code should be changed so that the table's entries that are
> set correspond to the chars configured in tabulated-list-sort-icon-*sc.
>

Thanks, here attached is a patch doing that.

I noticed a problem: I can customize the unicode char just fine, but
whenever I try to customize the glyphless char and use `emacs -nw` it
doesn't work, it still uses "^"  or "v". My wild guess is that
`glyphless-char-display` is used instead of the custom table... if anyone
has an idea...

Regards,
Philippe

[-- Attachment #1.2: Type: text/html, Size: 1744 bytes --]

[-- Attachment #2: 0001-Allow-customization-of-sort-indicators-in-tabulated-.patch --]
[-- Type: text/x-patch, Size: 2672 bytes --]

From f13bf05db5a6b18ce4b9916bf63dce3f4288f76b Mon Sep 17 00:00:00 2001
From: Philippe Vaucher <philippe.vaucher@gmail.com>
Date: Fri, 10 Aug 2018 21:59:24 +0200
Subject: [PATCH] Allow customization of sort indicators in tabulated-list

* lisp/emacs-lisp/tabulated-list.el: add customization group, add
  defcustoms.
---
 lisp/emacs-lisp/tabulated-list.el | 31 +++++++++++++++++++++++++++----
 1 file changed, 27 insertions(+), 4 deletions(-)

diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el
index 12d0151d6..a1af196bd 100644
--- a/lisp/emacs-lisp/tabulated-list.el
+++ b/lisp/emacs-lisp/tabulated-list.el
@@ -36,6 +36,29 @@
 
 ;;; Code:
 
+(defgroup tabulated-list nil
+  "Tabulated-list customization group.")
+
+(defcustom tabulated-list-sort-icon-asc ?▼
+  "Icon to display when sort order is ascending."
+  :group 'tabulated-list
+  :type 'character)
+
+(defcustom tabulated-list-sort-icon-desc ?▲
+  "Icon to display when sort order is descending."
+  :group 'tabulated-list
+  :type 'character)
+
+(defcustom tabulated-list-glyphless-sort-icon-asc ?v
+  "Glyphless icon to display when sort order is ascending."
+  :group 'tabulated-list
+  :type 'character)
+
+(defcustom tabulated-list-glyphless-sort-icon-desc ?^
+  "Glyphless icon to display when sort order is descending."
+  :group 'tabulated-list
+  :type 'character)
+
 ;; The reason `tabulated-list-format' and other variables are
 ;; permanent-local is to make it convenient to switch to a different
 ;; major mode, switch back, and have the original Tabulated List data
@@ -178,8 +201,8 @@ If ADVANCE is non-nil, move forward by one line afterwards."
   (let ((table (make-char-table 'glyphless-char-display nil)))
     (set-char-table-parent table glyphless-char-display)
     ;; Some text terminals can't display the Unicode arrows; be safe.
-    (aset table 9650 (cons nil "^"))
-    (aset table 9660 (cons nil "v"))
+    (aset table tabulated-list-sort-icon-desc (cons nil (char-to-string tabulated-list-glyphless-sort-icon-desc)))
+    (aset table tabulated-list-sort-icon-asc (cons nil (char-to-string tabulated-list-glyphless-sort-icon-asc)))
     table)
   "The `glyphless-char-display' table in Tabulated List buffers.")
 
@@ -231,8 +254,8 @@ Populated by `tabulated-list-init-header'.")
 		  (concat label
 			  (cond
 			   ((> (+ 2 (length label)) width) "")
-			   ((cdr tabulated-list-sort-key) " ▲")
-			   (t " ▼")))
+			   ((cdr tabulated-list-sort-key) (format " %c" tabulated-list-sort-icon-desc))
+			   (t (format " %c" tabulated-list-sort-icon-asc))))
 		  'face 'bold
 		  'tabulated-list-column-name label
 		  button-props))
-- 
2.20.1