Minor bug in dunnet

Minor bug in dunnet

[Lu Wang]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Hello,

  It seems to me that in dunnet, the line that extracts the current time is
offset by 1.  You may try to eval:

(substring (current-time-string) 11 19)
and
(substring (current-time-string) 12 20)


  While I believe that the game must have once worked with earlier versions
of emacs, I'm not sure if (substring) or (current-time-string) has been
changed since then.


  Please find the patch below.


  Thanks!

  regards,
  - Lu Wang

/////
diff --git a/lisp/play/dunnet.el b/lisp/play/dunnet.el
index 2f4536c..2d1a58f 100644
--- a/dunnet.el
+++ b/dunnet.el
@@ -3099,7 +3099,7 @@ File not found")))
 (defun dun-dos-boot-msg ()
   (sleep-for 3)
   (dun-mprinc "Current time is ")
-  (dun-mprincl (substring (current-time-string) 12 20))
+  (dun-mprincl (substring (current-time-string) 11 19))
   (dun-mprinc "Enter new time: ")
   (dun-read-line)
   (if (not dun-batch-mode)

[-- Attachment #2: Type: text/html, Size: 1175 bytes --]

bug#20554: Fwd: Minor bug in dunnet

[Lu Wang]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

Hello,

  (Sorry I have posted this email to -devel by mistake)

  It seems to me that in dunnet, the line that extracts the current time is
offset by 1.  You may try to eval:

(substring (current-time-string) 11 19)
and
(substring (current-time-string) 12 20)


  While I believe that the game must have once worked with earlier versions
of emacs, I'm not sure if (substring) or (current-time-string) has been
changed since then.


  Please find the patch below.


  Thanks!

  regards,
  - Lu Wang

/////
diff --git a/lisp/play/dunnet.el b/lisp/play/dunnet.el
index 2f4536c..2d1a58f 100644
--- a/dunnet.el
+++ b/dunnet.el
@@ -3099,7 +3099,7 @@ File not found")))
 (defun dun-dos-boot-msg ()
   (sleep-for 3)
   (dun-mprinc "Current time is ")
-  (dun-mprincl (substring (current-time-string) 12 20))
+  (dun-mprincl (substring (current-time-string) 11 19))
   (dun-mprinc "Enter new time: ")
   (dun-read-line)
   (if (not dun-batch-mode)

[-- Attachment #2: Type: text/html, Size: 1308 bytes --]

bug#20554: Fwd: Minor bug in dunnet

[Glenn Morris]

Version: 25.1

Thanks; fixed.

Re: Minor bug in dunnet

[Aurélien Aptel]

This should go in the emacs bugtracker, debbugs.

http://debbugs.gnu.org/
http://debbugs.gnu.org/cgi/pkgreport.cgi?package=emacs

Re: Minor bug in dunnet

[Lu Wang]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

Sorry for the mistake.
Yes I have sent it to the correct list, and it has been fixed.

regards,
- Lu
 2015-5-12 下午10:11于 "Aurélien Aptel" <aurelien.aptel+emacs@gmail.com>写道：

> This should go in the emacs bugtracker, debbugs.
>
> http://debbugs.gnu.org/
> http://debbugs.gnu.org/cgi/pkgreport.cgi?package=emacs
>

[-- Attachment #2: Type: text/html, Size: 769 bytes --]