From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Pogonyshev Newsgroups: gmane.emacs.bugs Subject: bug#56614: two problems with `package--reload-previously-loaded' Date: Sun, 24 Jul 2022 11:02:11 +0200 Message-ID: References: <8735es1bao.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000556be305e48953f0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27928"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56614@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 24 11:05:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFXYV-000717-3D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jul 2022 11:05:43 +0200 Original-Received: from localhost ([::1]:56192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFXYT-0008RN-Vv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jul 2022 05:05:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFXVw-0007iG-22 for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 05:03:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57060) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFXVu-0004UT-Hq for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 05:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFXVu-0007Wd-Co for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 05:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2022 09:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56614 X-GNU-PR-Package: emacs Original-Received: via spool by 56614-submit@debbugs.gnu.org id=B56614.165865335628867 (code B ref 56614); Sun, 24 Jul 2022 09:03:02 +0000 Original-Received: (at 56614) by debbugs.gnu.org; 24 Jul 2022 09:02:36 +0000 Original-Received: from localhost ([127.0.0.1]:46807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFXVT-0007VV-Qi for submit@debbugs.gnu.org; Sun, 24 Jul 2022 05:02:36 -0400 Original-Received: from mail-yw1-f178.google.com ([209.85.128.178]:33628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFXVO-0007Un-9b for 56614@debbugs.gnu.org; Sun, 24 Jul 2022 05:02:31 -0400 Original-Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-31e47ac84daso83962067b3.0 for <56614@debbugs.gnu.org>; Sun, 24 Jul 2022 02:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rhj/yGgImqgzEI0QKmR+5PafIhJ8ISfN5pZesm3BUjo=; b=kdmrQQlVy0auuCinGjS/RR6L19cJdKmHiLYHdYflFXxg99P6zgGu37Dm0U9I2BlpUx uB3p34FbNob+OzuW7UdD4evIqCmihFRsy4bGMHzskVaKdCV9Z4dyXq952Z8NC9MM0RFl kPp/n62MdCRF8JIOJdSPLeAnSyRNHcRUZMhnimu+adJi8Uwtxzryv43RjRW8dNfxYLmu pPp04xsu1/ENKjABDA8DExsDF+qQCJvb6+sKjrKhl8mzL866xRV4cjWPP/88EDUJ3ecA /hG9Np+/DqQ24ym/TJFjDNdlqJV2WUeV0HEJehF2bzynhKkzwFNxew21ziovSHwUY2j5 BwJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rhj/yGgImqgzEI0QKmR+5PafIhJ8ISfN5pZesm3BUjo=; b=BLcMk20v/xmYDB7GjDZn4rO4wSDk/AUiD6r03zmYtRGOFuSKFoDBCTfAYIdozaaGyM Plb1m4LTgx4tFXqcxKRxyWLtxGFrKcBNItFcb4+YXq7qibyDWeHS6v5Op0DC3Ude7WPy KgbteYcyNr8dLNepqUj3LbRfsXQusNpv/qr1rXKCWqYqo0jr0KVN1HJYIE3IKvE+pTU/ yrabUqKl/Bp+l2vMG1sDn93JgADRXcFm8B4TlMtkUrrd35hCqGTF2ZpXtPnNrj2KYGnX n3g2j2wHxBy9tqXZPaNmbTGR6DFR7jflUt4pcdYbCSbz/bwYZpxs3sipS2yP9SQiKzaz a5mg== X-Gm-Message-State: AJIora/gbiaZoS8qCI3M/Dpy8ewVdVQgHPYvEE0ArbwtR+ltFomHy8Xr VzDDkg47PVn5NURRjU1l8sc15pqU7Jxo0+nSg3Bi2F0YJg== X-Google-Smtp-Source: AGRyM1vyrRw7mLF6s8oZld337gv8CFV3cV/sKppJvNQzWY05GA13hGD5QnSpGzFnfcr03dyOVwoGvjsk1rJTvrgMnLo= X-Received: by 2002:a81:7484:0:b0:31e:61a7:82aa with SMTP id p126-20020a817484000000b0031e61a782aamr6039209ywc.346.1658653343295; Sun, 24 Jul 2022 02:02:23 -0700 (PDT) In-Reply-To: <8735es1bao.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237817 Archived-At: --000000000000556be305e48953f0 Content-Type: multipart/alternative; boundary="000000000000556be105e48953ee" --000000000000556be105e48953ee Content-Type: text/plain; charset="UTF-8" > Could you prepare a patch for both these > issues? (It's safer if you do it so that you can verify that things > work fine after the change (since you already have a test case).) Please find attached. I added comments for both changes that explain the reasoning, so that they are not accidentally reverted by a later change. Also replaced obsolete `find-function-source-path' with its new name `find-library-source-path'. Paul On Sat, 23 Jul 2022 at 10:30, Lars Ingebrigtsen wrote: > Paul Pogonyshev writes: > > > 1. Function excludes package's current directory, see variable > > `load-path-sans-dir'. This is problematic if a package is reinstalled > > from the same directory after changes have been made. I know this is > > not how things usually work, but it seems to create problems for no > > reason: if the same directory is never used, why bother about it here? > > Normal usecases are not affected at all, why "special" usecases that > > reuse the same directory suffer. > > Yes, that seems odd. > > > 2. When searching in `load-history', the function ignores changes from > byte-compiled > > to source and vice versa, i.e. `.el' -> `.elc' and `.elc' -> `.el'. In > other words, if you > > replace a byte-compiled file with a non-compiled (or vice versa), it > never gets > > reloaded. A simple fix (having zero effect in normal usecases) would be > e.g. this: > > > > (truename (file-truename canonical)) > > (found (or (member truename history) > > (member (if (string-suffix-p ".el" truename) > > (replace-regexp-in-string (rx ".el" eos) > ".elc" truename t) > > (replace-regexp-in-string (rx ".elc" eos) > ".el" truename t)) > > history))) > > > > I think that makes sense. Could you prepare a patch for both these > issues? (It's safer if you do it so that you can verify that things > work fine after the change (since you already have a test case).) > > --000000000000556be105e48953ee Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Could you prepare a patch for both these
>=C2= =A0issues?=C2=A0 (It's safer if you do it so that you can verify that t= hings
>=C2=A0work fine after the change (since you already have a tes= t case).)

Please find attached. I added comments for both = changes that explain the reasoning, so that they are not accidentally rever= ted by a later change.

Also replaced obsolete `find-function-source-path' with = its new name `find-library-source-path'.
=
Paul

On Sat, 23 Jul 2022 at 10:30, = Lars Ingebrigtsen <larsi@gnus.org&= gt; wrote:
Paul = Pogonyshev <po= gonyshev@gmail.com> writes:

> 1. Function excludes package's current directory, see variable
> `load-path-sans-dir'.=C2=A0 This is problematic if a package is re= installed
> from the same directory after changes have been made. I know this is > not how things usually work, but it seems to create problems for no > reason: if the same directory is never used, why bother about it here?=
> Normal usecases are not affected at all, why "special" useca= ses that
> reuse the same directory suffer.

Yes, that seems odd.

> 2. When searching in `load-history', the function ignores changes = from byte-compiled
> to source and vice versa, i.e. `.el' -> `.elc' and `.elc= 9; -> `.el'. In other words, if you
> replace a byte-compiled file with a non-compiled (or vice versa), it n= ever gets
> reloaded. A simple fix (having zero effect in normal usecases) would b= e e.g. this:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(truename (file-truename canonical))<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(found (or (member truename history)<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (= member (if (string-suffix-p ".el" truename)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (replace-regexp-in-string (rx &qu= ot;.el" eos) ".elc" truename t)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (replace-regexp-in-string (rx ".elc= " eos) ".el" truename t))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 history)))
>

I think that makes sense.=C2=A0 Could you prepare a patch for both these issues?=C2=A0 (It's safer if you do it so that you can verify that thin= gs
work fine after the change (since you already have a test case).)

--000000000000556be105e48953ee-- --000000000000556be305e48953f0 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Tweak-package-reload-previously-loaded-bug-56614.patch" Content-Disposition: attachment; filename="0001-Tweak-package-reload-previously-loaded-bug-56614.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l5z3cn680 RnJvbSBiYTBmZWM2OWY4MTBmOTI0Y2IxMDIzMTY5NGZkNzQxYmQzOTE1MTAzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIFBvZ29ueXNoZXYgPHBvZ29ueXNoZXZAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI0IEp1bCAyMDIyIDExOjAwOjQ2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g VHdlYWsgYHBhY2thZ2UtLXJlbG9hZC1wcmV2aW91c2x5LWxvYWRlZCcgKGJ1ZyM1NjYxNCkKCi0t LQogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgfCAyNSArKysrKysrKysrKysrKysrKysrLS0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCBiL2xpc3AvZW1hY3MtbGlzcC9w YWNrYWdlLmVsCmluZGV4IDAwYmVlZTgxMWIuLjZiNTU3MjY1NDYgMTAwNjQ0Ci0tLSBhL2xpc3Av ZW1hY3MtbGlzcC9wYWNrYWdlLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCkBA IC03ODUsMTAgKzc4NSwxNCBAQCBwYWNrYWdlLS1yZWxvYWQtcHJldmlvdXNseS1sb2FkZWQKICAg KHdpdGgtZGVtb3RlZC1lcnJvcnMgIkVycm9yIGluIHBhY2thZ2UtLWxvYWQtZmlsZXMtZm9yLWFj dGl2YXRpb246ICVzIgogICAgIChsZXQqIChyZXN1bHQKICAgICAgICAgICAgKGRpciAocGFja2Fn ZS1kZXNjLWRpciBwa2ctZGVzYykpCi0gICAgICAgICAgIChsb2FkLXBhdGgtc2Fucy1kaXIKLSAg ICAgICAgICAgIChjbC1yZW1vdmUtaWYgKGFwcGx5LXBhcnRpYWxseSAjJ3N0cmluZz0gZGlyKQot ICAgICAgICAgICAgICAgICAgICAgICAgICAob3IgKGJvdW5kLWFuZC10cnVlLXAgZmluZC1mdW5j dGlvbi1zb3VyY2UtcGF0aCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxvYWQtcGF0 aCkpKQorICAgICAgICAgICA7OyBBIHByZXZpb3VzIGltcGxlbWVudGF0aW9uIHdvdWxkIHNraXAg YGRpcicgaXRzZWxmLgorICAgICAgICAgICA7OyBIb3dldmVyLCBpbiBub3JtYWwgdXNlIHJlbG9h ZGluZyBmcm9tIHRoZSBzYW1lIGRpcmVjdG9yeQorICAgICAgICAgICA7OyBuZXZlciBoYXBwZW5z IGFueXdheSwgd2hpbGUgaW4gY2VydGFpbiBjYXNlcyBleHRlcm5hbCB0bworICAgICAgICAgICA7 OyBFbWFjcyBhIHBhY2thZ2UgaW4gdGhlIHNhbWUgZGlyZWN0b3J5IG5vdCBuZWNlc3NhcnkKKyAg ICAgICAgICAgOzsgc3RheXMgYnl0ZS1pZGVudGljYWwsIGUuZy4gIGR1cmluZyBkZXZlbG9wbWVu dC4gIEp1c3QKKyAgICAgICAgICAgOzsgZG9uJ3Qgc3BlY2lhbC1jYXNlIGBkaXInLgorICAgICAg ICAgICAoZWZmZWN0aXZlLXBhdGggKG9yIChib3VuZC1hbmQtdHJ1ZS1wIGZpbmQtbGlicmFyeS1z b3VyY2UtcGF0aCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb2FkLXBhdGgpKQog ICAgICAgICAgICAoZmlsZXMgKGRpcmVjdG9yeS1maWxlcy1yZWN1cnNpdmVseSBkaXIgIlxcYFte XFwuXS4qXFwuZWxcXCciKSkKICAgICAgICAgICAgKGhpc3RvcnkgKG1hcGNhciAjJ2ZpbGUtdHJ1 ZW5hbWUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2wtcmVtb3ZlLWlmLW5vdCAjJ3N0 cmluZ3AKQEAgLTc5Niw4ICs4MDAsMTcgQEAgcGFja2FnZS0tcmVsb2FkLXByZXZpb3VzbHktbG9h ZGVkCiAgICAgICAoZG9saXN0IChmaWxlIGZpbGVzKQogICAgICAgICAod2hlbi1sZXQgKChsaWJy YXJ5IChwYWNrYWdlLS1saWJyYXJ5LXN0ZW0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGZpbGUtcmVsYXRpdmUtbmFtZSBmaWxlIGRpcikpKQotICAgICAgICAgICAgICAgICAgIChjYW5v bmljYWwgKGxvY2F0ZS1saWJyYXJ5IGxpYnJhcnkgbmlsIGxvYWQtcGF0aC1zYW5zLWRpcikpCi0g ICAgICAgICAgICAgICAgICAgKGZvdW5kIChtZW1iZXIgKGZpbGUtdHJ1ZW5hbWUgY2Fub25pY2Fs KSBoaXN0b3J5KSkKKyAgICAgICAgICAgICAgICAgICAoY2Fub25pY2FsIChsb2NhdGUtbGlicmFy eSBsaWJyYXJ5IG5pbCBlZmZlY3RpdmUtcGF0aCkpCisgICAgICAgICAgICAgICAgICAgKHRydWVu YW1lIChmaWxlLXRydWVuYW1lIGNhbm9uaWNhbCkpCisgICAgICAgICAgICAgICAgICAgOzsgTm9y bWFsbHksIGFsbCBmaWxlcyBpbiBhIHBhY2thZ2UgYXJlIGNvbXBpbGVkIGJ5CisgICAgICAgICAg ICAgICAgICAgOzsgbm93LCBidXQgZG9uJ3QgYXNzdW1lIHRoYXQuICBFLmcuIGRpZmZlcmVudAor ICAgICAgICAgICAgICAgICAgIDs7IHZlcnNpb25zIGNhbiBhZGQgb3IgcmVtb3ZlIGBuby1ieXRl LWNvbXBpbGUnLgorICAgICAgICAgICAgICAgICAgIChhbHRuYW1lIChpZiAoc3RyaW5nLXN1ZmZp eC1wICIuZWwiIHRydWVuYW1lKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocmVw bGFjZS1yZWdleHAtaW4tc3RyaW5nICJcXC5lbFxcJyIgIi5lbGMiIHRydWVuYW1lIHQpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAocmVwbGFjZS1yZWdleHAtaW4tc3RyaW5nICJcXC5l bGNcXCciICIuZWwiIHRydWVuYW1lIHQpKSkKKyAgICAgICAgICAgICAgICAgICAoZm91bmQgKG9y IChtZW1iZXIgdHJ1ZW5hbWUgaGlzdG9yeSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChhbmQgKG5vdCAoc3RyaW5nPSBhbHRuYW1lIHRydWVuYW1lKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKG1lbWJlciBhbHRuYW1lIGhpc3RvcnkpKSkpCiAgICAgICAgICAg ICAgICAgICAgKHJlY2VudC1pbmRleCAobGVuZ3RoIGZvdW5kKSkpCiAgICAgICAgICAgKHVubGVz cyAoZXF1YWwgKGZpbGUtbmFtZS1iYXNlIGxpYnJhcnkpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgKGZvcm1hdCAiJXMtYXV0b2xvYWRzIiAocGFja2FnZS1kZXNjLW5hbWUgcGtnLWRlc2MpKSkK LS0gCjIuMzUuMQoK --000000000000556be305e48953f0--