From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Pogonyshev Newsgroups: gmane.emacs.bugs Subject: bug#15322: VC log buffer scrolls itself Date: Thu, 26 Sep 2013 09:17:52 +0200 Message-ID: References: <55fvtc5z7w.fsf@fencepost.gnu.org> <70six9g7nn.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c1e22e05c79604e7442bbb X-Trace: ger.gmane.org 1380179899 2478 80.91.229.3 (26 Sep 2013 07:18:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Sep 2013 07:18:19 +0000 (UTC) Cc: 15322@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 26 09:18:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VP5q8-0003zJ-0y for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2013 09:18:20 +0200 Original-Received: from localhost ([::1]:56592 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VP5q5-0001Wr-A2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2013 03:18:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VP5px-0001Wf-L0 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 03:18:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VP5ps-0007wS-R6 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 03:18:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VP5ps-0007wM-ND for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 03:18:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VP5pr-0002v2-Je for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 03:18:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2013 07:18:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15322 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15322-submit@debbugs.gnu.org id=B15322.138017987711201 (code B ref 15322); Thu, 26 Sep 2013 07:18:03 +0000 Original-Received: (at 15322) by debbugs.gnu.org; 26 Sep 2013 07:17:57 +0000 Original-Received: from localhost ([127.0.0.1]:36856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VP5pj-0002uY-Ti for submit@debbugs.gnu.org; Thu, 26 Sep 2013 03:17:56 -0400 Original-Received: from mail-oa0-f48.google.com ([209.85.219.48]:53878) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VP5ph-0002uL-B5 for 15322@debbugs.gnu.org; Thu, 26 Sep 2013 03:17:54 -0400 Original-Received: by mail-oa0-f48.google.com with SMTP id m6so260550oag.35 for <15322@debbugs.gnu.org>; Thu, 26 Sep 2013 00:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=4mhcvvJWiEQFwbE9gC2X9vUwHoSTbktE01iusl3W2E0=; b=IUu39lZK5knLAP1WQwurPK3mX0vUMbO/8qjviaHVCE8aYP+VY4bzW03C5HImcvkQxI maSuLFAdK3GClhnxLoSQf4cMIVCSExIfdwTgky8tXAq3z9AI3TdQ2irdTYBq0OpNSZ8m 1OCYhIPFeNHjkrMvLia1KdTJ5raLDwG4pI0J3R+8LzWAZev89pRHTcyZtId1K+EoYxkv QAyAVGQV6uhQbgYwz1s2qcus75kHvJaesO/wGml56ZL6OdwxIWP+6WPKPXGWgPpPuVgV 52W/xd0h7NVwMy3xK/bt4JGdGSUCg86ilp/SkgogicVqARBIS1KSD4lYuFbMN1tXq8XN KJ6Q== X-Received: by 10.182.131.166 with SMTP id on6mr42583obb.60.1380179872432; Thu, 26 Sep 2013 00:17:52 -0700 (PDT) Original-Received: by 10.182.200.163 with HTTP; Thu, 26 Sep 2013 00:17:52 -0700 (PDT) In-Reply-To: <70six9g7nn.fsf@fencepost.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78748 Archived-At: --001a11c1e22e05c79604e7442bbb Content-Type: text/plain; charset=UTF-8 In Emacs built from trunk yesterday it still jumps, though to the "correct" version (the one reported by 'svn info'). However, given that committing changes from the buffer does not advance the working directory revision (e.g. what I have now is 26 revisions in the past), I'm not sure how useful this is, at least for subversion. Probably it's better for saner VCS's, but for subversion if feels like annoyance. Paul On 12 September 2013 21:30, Glenn Morris wrote: > Stefan Monnier wrote: > > > And I think that makes sense. It's natural to select a particular > > revision when running vc-print-log from (say) vc-annotate, but for > > a plain `C-x v l', the user just wants to see "the log" and presumably > > doesn't care about which revision happens to be current. > > > > IOW, I think we're trying too hard here. > > *** lisp/vc/vc.el 2013-09-12 06:10:12 +0000 > --- lisp/vc/vc.el 2013-09-12 19:28:04 +0000 > *************** > *** 2299,2305 **** > (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef > (backend (car vc-fileset)) > (files (cadr vc-fileset)) > ! (working-revision (or working-revision (vc-working-revision (car > files))))) > (vc-print-log-internal backend files working-revision nil limit))) > > ;;;###autoload > --- 2299,2306 ---- > (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef > (backend (car vc-fileset)) > (files (cadr vc-fileset)) > ! ;; (working-revision (or working-revision (vc-working-revision (car > files)))) > ! ) > (vc-print-log-internal backend files working-revision nil limit))) > > ;;;###autoload > --001a11c1e22e05c79604e7442bbb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
In Emacs built from trunk yesterday it still jumps, t= hough to the "correct" version (the one reported by 'svn info= '). However, given that committing changes from the buffer does not adv= ance the working directory revision (e.g. what I have now is 26 revisions i= n the past), I'm not sure how useful this is, at least for subversion. = Probably it's better for saner VCS's, but for subversion if feels l= ike annoyance.

Paul


On 12 September 2013 21:30, Glenn Morris <<= a href=3D"mailto:rgm@gnu.org" target=3D"_blank">rgm@gnu.org> = wrote:
Stefan Monnier wrote:

> And I think that makes sense. =C2=A0It's natural to select a parti= cular
> revision when running vc-print-log from (say) vc-annotate, but for
> a plain `C-x v l', the user just wants to see "the log" = and presumably
> doesn't care about which revision happens to be current.
>
> IOW, I think we're trying too hard here.

*** lisp/vc/vc.el =C2=A0 =C2=A0 =C2=A0 2013-09-12 06:10:12 +0000
--- lisp/vc/vc.el =C2=A0 =C2=A0 =C2=A0 2013-09-12 19:28:04 +0000
***************
*** 2299,2305 ****
=C2=A0 =C2=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --St= ef
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(backend (car vc-fileset))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(files (cadr vc-fileset))
! =C2=A0 =C2=A0 =C2=A0 =C2=A0(working-revision (or working-revision (vc-wor= king-revision (car files)))))
=C2=A0 =C2=A0 =C2=A0 (vc-print-log-internal backend files working-revision = nil limit)))

=C2=A0 ;;;###autoload
--- 2299,2306 ----
=C2=A0 =C2=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --St= ef
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(backend (car vc-fileset))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(files (cadr vc-fileset))
! ;; =C2=A0 =C2=A0 (working-revision (or working-revision (vc-working-revis= ion (car files))))
! =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)
=C2=A0 =C2=A0 =C2=A0 (vc-print-log-internal backend files working-revision = nil limit)))

=C2=A0 ;;;###autoload

--001a11c1e22e05c79604e7442bbb--