all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Pogonyshev <pogonyshev@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 15322@debbugs.gnu.org
Subject: bug#15322: VC log buffer scrolls itself
Date: Thu, 26 Sep 2013 09:17:52 +0200	[thread overview]
Message-ID: <CAG7BpaqWZARcKDeb64v-Tb42Nfb=rBn0yHS+bRzYsqt99YQB9g@mail.gmail.com> (raw)
In-Reply-To: <70six9g7nn.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1679 bytes --]

In Emacs built from trunk yesterday it still jumps, though to the "correct"
version (the one reported by 'svn info'). However, given that committing
changes from the buffer does not advance the working directory revision
(e.g. what I have now is 26 revisions in the past), I'm not sure how useful
this is, at least for subversion. Probably it's better for saner VCS's, but
for subversion if feels like annoyance.

Paul


On 12 September 2013 21:30, Glenn Morris <rgm@gnu.org> wrote:

> Stefan Monnier wrote:
>
> > And I think that makes sense.  It's natural to select a particular
> > revision when running vc-print-log from (say) vc-annotate, but for
> > a plain `C-x v l', the user just wants to see "the log" and presumably
> > doesn't care about which revision happens to be current.
> >
> > IOW, I think we're trying too hard here.
>
> *** lisp/vc/vc.el       2013-09-12 06:10:12 +0000
> --- lisp/vc/vc.el       2013-09-12 19:28:04 +0000
> ***************
> *** 2299,2305 ****
>     (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef
>          (backend (car vc-fileset))
>          (files (cadr vc-fileset))
> !        (working-revision (or working-revision (vc-working-revision (car
> files)))))
>       (vc-print-log-internal backend files working-revision nil limit)))
>
>   ;;;###autoload
> --- 2299,2306 ----
>     (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef
>          (backend (car vc-fileset))
>          (files (cadr vc-fileset))
> ! ;;     (working-revision (or working-revision (vc-working-revision (car
> files))))
> !          )
>       (vc-print-log-internal backend files working-revision nil limit)))
>
>   ;;;###autoload
>

[-- Attachment #2: Type: text/html, Size: 2224 bytes --]

  reply	other threads:[~2013-09-26  7:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 13:24 bug#15322: VC log buffer scrolls itself Paul Pogonyshev
2013-09-10 15:57 ` Eli Zaretskii
2013-09-10 16:04 ` Glenn Morris
2013-09-10 18:05   ` Glenn Morris
2013-09-10 18:30     ` Eli Zaretskii
2013-09-11  6:58       ` Paul Pogonyshev
2013-09-11 13:28         ` Eli Zaretskii
2013-09-12  6:26     ` Glenn Morris
2013-09-12  7:25       ` Paul Pogonyshev
2013-09-12 15:57         ` Glenn Morris
2013-09-12 19:09           ` Stefan Monnier
2013-09-12 19:30             ` Glenn Morris
2013-09-26  7:17               ` Paul Pogonyshev [this message]
2013-10-24  8:39                 ` Paul Pogonyshev
2013-10-24  8:49                   ` Andreas Schwab
2013-10-24 14:24                     ` Stefan Monnier
2014-08-02 16:04                       ` Paul Pogonyshev
2015-05-03  3:38                     ` Dmitry Gutov
2014-11-19 21:19 ` Richard Copley
2014-11-19 21:57   ` Richard Copley
2015-05-03  3:32     ` Dmitry Gutov
2015-05-03 14:34       ` Eli Zaretskii
2015-05-03 15:58         ` Dmitry Gutov
2015-05-03 16:32           ` Eli Zaretskii
2015-05-03 18:33             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAG7BpaqWZARcKDeb64v-Tb42Nfb=rBn0yHS+bRzYsqt99YQB9g@mail.gmail.com' \
    --to=pogonyshev@gmail.com \
    --cc=15322@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.