From: Paul Pogonyshev <pogonyshev@gmail.com>
To: 34037@debbugs.gnu.org
Subject: bug#34037: [PATCH] Make `package' not "uninhibit" messages
Date: Thu, 10 Jan 2019 20:42:47 +0100 [thread overview]
Message-ID: <CAG7BpapFxX7sn5vBDjOcjRB2BACWE11RG8tKnQhse1e4t3mdLw@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 131 bytes --]
Two `package' functions can reset `inhibit-message' that is already set to
t by outer code. Attached trivial patch fixes it.
Paul
[-- Attachment #1.2: Type: text/html, Size: 184 bytes --]
[-- Attachment #2: 0001-Make-package-not-uninhibit-messages.patch --]
[-- Type: text/x-patch, Size: 1423 bytes --]
From d5bebf1d282ee620f500393a40dc63eca29a1b10 Mon Sep 17 00:00:00 2001
From: Paul Pogonyshev <pogonyshev@gmail.com>
Date: Thu, 10 Jan 2019 20:39:54 +0100
Subject: [PATCH] Make `package' not "uninhibit" messages
---
lisp/emacs-lisp/package.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 1752c7e9fe..dc279f55c2 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1605,7 +1605,7 @@ package-refresh-contents
(make-directory package-user-dir t))
(let ((default-keyring (expand-file-name "package-keyring.gpg"
data-directory))
- (inhibit-message async))
+ (inhibit-message (or inhibit-message async)))
(when (and package-check-signature (file-exists-p default-keyring))
(condition-case-unless-debug error
(package-import-keyring default-keyring)
@@ -3245,7 +3245,7 @@ package-menu--perform-transaction
(redisplay 'force)
(dolist (elt (package--sort-by-dependence delete-list))
(condition-case-unless-debug err
- (let ((inhibit-message package-menu-async))
+ (let ((inhibit-message (or inhibit-message package-menu-async)))
(package-delete elt nil 'nosave))
(error (message "Error trying to delete `%s': %S"
(package-desc-full-name elt)
--
2.19.2
next reply other threads:[~2019-01-10 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 19:42 Paul Pogonyshev [this message]
2019-05-16 13:07 ` bug#34037: ping Paul Pogonyshev
2019-05-17 0:09 ` bug#34037: [PATCH] Make `package' not "uninhibit" messages Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG7BpapFxX7sn5vBDjOcjRB2BACWE11RG8tKnQhse1e4t3mdLw@mail.gmail.com \
--to=pogonyshev@gmail.com \
--cc=34037@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.