From: Paul Pogonyshev <pogonyshev@gmail.com>
To: 41065@debbugs.gnu.org
Subject: bug#41065: PATCH
Date: Tue, 27 Oct 2020 01:10:58 +0100 [thread overview]
Message-ID: <CAG7BpapBS=ryOLX11eCsBcwhU-SAVfv5S1n=e2OyhEDTPGrk-Q@mail.gmail.com> (raw)
In-Reply-To: <CAG7BpapBsmFHH3WGr443C8Hma2RXnN0hK+DSM4qmiwqMdCpR2Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 24 bytes --]
Trivial patch attached.
[-- Attachment #1.2: Type: text/html, Size: 45 bytes --]
[-- Attachment #2: 0001-Don-t-leak-result-of-nested-byte-compilation-to-oute.patch --]
[-- Type: text/x-patch, Size: 1299 bytes --]
From 87d927a3a61f16fa908b5dd1c00457023f269114 Mon Sep 17 00:00:00 2001
From: Paul Pogonyshev <pogonyshev@gmail.com>
Date: Tue, 27 Oct 2020 01:08:19 +0100
Subject: [PATCH] Don't leak result of nested byte-compilation to outer level
(bug#41065)
---
lisp/emacs-lisp/bytecomp.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index a547b672b1..cbda16d051 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1938,7 +1938,7 @@ byte-compile-file
(byte-compile--known-dynamic-vars
(byte-compile--load-dynvars (getenv "EMACS_DYNVARS_FILE")))
target-file input-buffer output-buffer
- byte-compile-dest-file)
+ byte-compile-dest-file byte-compiler-error-flag)
(setq target-file (byte-compile-dest-file filename))
(setq byte-compile-dest-file target-file)
(with-current-buffer
@@ -2000,7 +2000,6 @@ byte-compile-file
'no-byte-compile)
(when byte-compile-verbose
(message "Compiling %s..." filename))
- (setq byte-compiler-error-flag nil)
;; It is important that input-buffer not be current at this call,
;; so that the value of point set in input-buffer
;; within byte-compile-from-buffer lingers in that buffer.
--
2.20.1
next prev parent reply other threads:[~2020-10-27 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 22:21 bug#41065: Result of byte-compilation can be nil even if the compiled file contains no errors Paul Pogonyshev
2020-10-27 0:10 ` Paul Pogonyshev [this message]
2020-10-27 8:47 ` bug#41065: (no subject) Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG7BpapBS=ryOLX11eCsBcwhU-SAVfv5S1n=e2OyhEDTPGrk-Q@mail.gmail.com' \
--to=pogonyshev@gmail.com \
--cc=41065@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.