From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Pogonyshev Newsgroups: gmane.emacs.bugs Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Date: Sun, 29 May 2016 16:11:02 +0200 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113d469ec22a1a0533fbb507 X-Trace: ger.gmane.org 1464531147 16459 80.91.229.3 (29 May 2016 14:12:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 May 2016 14:12:27 +0000 (UTC) To: 23648@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 29 16:12:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b71Rv-0005RN-4y for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2016 16:12:15 +0200 Original-Received: from localhost ([::1]:56023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Ru-0004s4-Ax for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2016 10:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Rl-0004p0-84 for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71Rj-00047u-3O for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:12:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Ri-00047q-VU for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b71Ri-0000p4-Mq for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2016 14:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14645310753106 (code B ref -1); Sun, 29 May 2016 14:12:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 May 2016 14:11:15 +0000 Original-Received: from localhost ([127.0.0.1]:46529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b71Qx-0000o2-33 for submit@debbugs.gnu.org; Sun, 29 May 2016 10:11:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b71Qw-0000no-4D for submit@debbugs.gnu.org; Sun, 29 May 2016 10:11:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71Qp-0003zY-Vy for submit@debbugs.gnu.org; Sun, 29 May 2016 10:11:08 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Qp-0003yR-Sm for submit@debbugs.gnu.org; Sun, 29 May 2016 10:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Qn-0004Ke-PP for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:11:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71Ql-0003xC-Mn for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:11:04 -0400 Original-Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:36772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Ql-0003x4-Hz for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:11:03 -0400 Original-Received: by mail-oi0-x22b.google.com with SMTP id j1so237430848oih.3 for ; Sun, 29 May 2016 07:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=hhDwvb6rjqHVIEMUuyE+dfvPNVGh5cE6CdWa7NDkYzg=; b=FsmvDVmR5xrF4jlFtN1TtewxlfW7v9gDbzKaXwhtr0F1hijlArnVWTkOYSbE1Vn5x3 oskZXGD02GZkoPWrXsq9sWK8vqUbo9qlD7q+0WUgpXfSkdn2IciJTw9rVPc9wBkeOVMD On4KAJfKlAVRAFhp/gvsXl3m+K/siQ1J/drQfWTit0Xpp/vKYz0KzHBUsAvDHnMkyAl+ X/tXD4WEuUJdMztWbPMbd9IIIrc4U5ClKLpedbjM22WHpWUTvRARHYEp3T8z7ZmJSodG AHMdJiAAOP/ucBoO1pZn1QBsxwKLzyrvT79v/lEko81NiSOgJd2yF2JC5MIjFdH7dw7w PO+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=hhDwvb6rjqHVIEMUuyE+dfvPNVGh5cE6CdWa7NDkYzg=; b=Wh8zb6a5uIzttIa4FgTRm2nFVANU9V2QPbQike4DlLgrDXpqnmbGhIk0R8N1086/pp YWqelWyBZqiNjZvdfDR/tMgCWeSbLoX+52f0yENQ7knof9bvtRDc2fY1tYGICvOAphOf bOdO1ppPkARbDrwaGV6UZSAp1hXEtUdDc55vEwBZmC346ECJQVVdZS8kEG/E2BKOpMSL Y8pRiIZFpiC7X+oWpK4TjimsgudYc4lbYMA0KqrXqswOLM91Cw2QncF18ITANt+WTD60 XXVlHCooD9PMKQYOJ7+Eg5MpAqYBXcwUeivkfqIIg9ZJr8bhkW5mlPF5fUHeEj5icEgG iyGg== X-Gm-Message-State: ALyK8tLdHj19+sMEj5U+MNe/6XRdhXF1t+yKkbcpUO+FNWIqCj4Up6fMhqEBbdtfOxksg+tnkTTy/swRKTxF3g== X-Received: by 10.202.225.5 with SMTP id y5mr15599479oig.187.1464531062749; Sun, 29 May 2016 07:11:02 -0700 (PDT) Original-Received: by 10.202.71.150 with HTTP; Sun, 29 May 2016 07:11:02 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118831 Archived-At: --001a113d469ec22a1a0533fbb507 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I quite often get the following messages: Warning: Unknown defun property =E2=80=98compiler-macro=E2=80=99 in ... As far as I could trace it, the problem is indirectly caused by `define-inline'. While definition of `defun-declarations-alist' does contain `compiler-macro' in its init form, it can be removed later. E.g. when I evaluated the variable, it was not there anymore, only `gv-setter' was there. It seems this is done unintentionally by `elisp-completion-at-point': (`declare (list t (mapcar (lambda (x) (symbol-name (car x))) (delete-dups ;; FIXME: We should include some ;; docstring with each entry. (append macro-declarations-alist defun-declarations-alist))))) Here `delete-dups' destructively modifies a list that includes `defun-declarations-alist' as its tail verbatim, not as a copy. Attached patch should fix that. Paul * elisp-mode.el (elisp-completion-at-point): Fix to not alter `defun-declarations-alist' by side effect. --001a113d469ec22a1a0533fbb507 Content-Type: text/plain; charset=US-ASCII; name="xxx.diff" Content-Disposition: attachment; filename="xxx.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iosnxy600 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2VsaXNwLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rl cy9lbGlzcC1tb2RlLmVsCmluZGV4IDJhZDIyZGQuLmQ4ZjMxNjIgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2VsaXNwLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvZWxpc3AtbW9kZS5l bApAQCAtNTMzLDkgKzUzMyw5IEBAIEl0IGNhbiBiZSBxdW90ZWQsIG9yIGJlIGluc2lkZSBhIHF1 b3RlZCBmb3JtLiIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVs ZXRlLWR1cHMKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgRklY TUU6IFdlIHNob3VsZCBpbmNsdWRlIHNvbWUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgOzsgZG9jc3RyaW5nIHdpdGggZWFjaCBlbnRyeS4KLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFwcGVuZAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbWFjcm8tZGVjbGFyYXRpb25zLWFsaXN0Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZWZ1bi1kZWNsYXJhdGlvbnMtYWxpc3Qp KSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYXBwZW5kIG1h Y3JvLWRlY2xhcmF0aW9ucy1hbGlzdAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGRlZnVuLWRlY2xhcmF0aW9ucy1hbGlzdAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5pbCkpKSkpCiAgICAgICAgICAgICAg ICAgICAgICAgICgoYW5kIChvciBgY29uZGl0aW9uLWNhc2UgYGNvbmRpdGlvbi1jYXNlLXVubGVz cy1kZWJ1ZykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGd1YXJkIChzYXZlLWV4Y3Vy c2lvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWdub3JlLWVycm9y cwo= --001a113d469ec22a1a0533fbb507--