From: Paul Pogonyshev <pogonyshev@gmail.com>
To: 23648@debbugs.gnu.org
Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified
Date: Sun, 29 May 2016 16:11:02 +0200 [thread overview]
Message-ID: <CAG7Bpap8Jn4FucbEAbH=GjgjV55_oXsKDJWcPYd_jfxC3nkJEQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
I quite often get the following messages:
Warning: Unknown defun property ‘compiler-macro’ in ...
As far as I could trace it, the problem is indirectly caused by
`define-inline'. While definition of `defun-declarations-alist' does
contain `compiler-macro' in its init form, it can be removed later.
E.g. when I evaluated the variable, it was not there anymore, only
`gv-setter' was there.
It seems this is done unintentionally by `elisp-completion-at-point':
(`declare
(list t (mapcar (lambda (x) (symbol-name (car x)))
(delete-dups
;; FIXME: We should include some
;; docstring with each entry.
(append
macro-declarations-alist
defun-declarations-alist)))))
Here `delete-dups' destructively modifies a list that includes
`defun-declarations-alist' as its tail verbatim, not as a copy.
Attached patch should fix that.
Paul
* elisp-mode.el (elisp-completion-at-point): Fix to not alter
`defun-declarations-alist' by side effect.
[-- Attachment #2: xxx.diff --]
[-- Type: text/plain, Size: 1028 bytes --]
diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index 2ad22dd..d8f3162 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -533,9 +533,9 @@ It can be quoted, or be inside a quoted form."
(delete-dups
;; FIXME: We should include some
;; docstring with each entry.
- (append
- macro-declarations-alist
- defun-declarations-alist)))))
+ (append macro-declarations-alist
+ defun-declarations-alist
+ nil)))))
((and (or `condition-case `condition-case-unless-debug)
(guard (save-excursion
(ignore-errors
next reply other threads:[~2016-05-29 14:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 14:11 Paul Pogonyshev [this message]
2016-07-18 3:00 ` bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified npostavs
2016-07-18 14:33 ` Eli Zaretskii
2016-07-18 15:53 ` Noam Postavsky
2016-07-18 18:16 ` Eli Zaretskii
2016-07-18 18:58 ` Noam Postavsky
2016-07-18 19:08 ` Eli Zaretskii
2016-07-18 21:28 ` Michael Heerdegen
2016-07-19 2:40 ` Eli Zaretskii
2016-07-21 1:09 ` npostavs
2016-07-21 14:22 ` Eli Zaretskii
2016-07-21 21:27 ` Noam Postavsky
2016-07-23 8:54 ` Eli Zaretskii
2016-07-23 14:18 ` npostavs
2016-07-24 17:07 ` Paul Pogonyshev
2016-07-24 17:31 ` Eli Zaretskii
2016-07-18 19:17 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG7Bpap8Jn4FucbEAbH=GjgjV55_oXsKDJWcPYd_jfxC3nkJEQ@mail.gmail.com' \
--to=pogonyshev@gmail.com \
--cc=23648@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.