From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Pogonyshev Newsgroups: gmane.emacs.bugs Subject: bug#57684: locked narrowing breaks existing code without an apparent way to repair Date: Thu, 8 Sep 2022 22:30:45 +0200 Message-ID: References: <2e25ca87e3c6ebb795d7@heytings.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008a42c805e8304e66" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14718"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57684@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 08 22:36:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWOFt-0003Yd-SF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 22:36:09 +0200 Original-Received: from localhost ([::1]:46856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWOFs-0001Pj-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 16:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWOBu-0007OJ-GH for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 16:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWOBu-0006wZ-5m for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 16:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWOBu-0005hS-1D for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Sep 2022 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57684 X-GNU-PR-Package: emacs Original-Received: via spool by 57684-submit@debbugs.gnu.org id=B57684.166266907121851 (code B ref 57684); Thu, 08 Sep 2022 20:32:01 +0000 Original-Received: (at 57684) by debbugs.gnu.org; 8 Sep 2022 20:31:11 +0000 Original-Received: from localhost ([127.0.0.1]:60226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWOB5-0005gL-3V for submit@debbugs.gnu.org; Thu, 08 Sep 2022 16:31:11 -0400 Original-Received: from mail-ej1-f44.google.com ([209.85.218.44]:42532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWOAx-0005fk-C6 for 57684@debbugs.gnu.org; Thu, 08 Sep 2022 16:31:10 -0400 Original-Received: by mail-ej1-f44.google.com with SMTP id r17so13378163ejy.9 for <57684@debbugs.gnu.org>; Thu, 08 Sep 2022 13:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=453EV6+Vk4UiA+QPML9PMd8FW+X3vUlRpn0D8jE/Fgo=; b=FSWujGN5KQQ7lyf+3e8YCEZmB7NYo+Uq5kv0fj5eZM9ZeAYkFTLpte7vtEGV9D0H9e JJN7SnbvSC4SkeAVHQ9R/bpqHvyjFfaxU2RG8JXZC26b42E32W1Af5gRWTG/b+ifuNrs rugPMk+lP3sKgIMoCX5Z3zHz1p34z4SC0C+wZME97xUsCGgWdE/tX5+GMjRrGU6AJnVv uKEzxhKBGsYF88DmygTpqmbQxriq3RW9h6TdV3UYQnXrRRYOPiY/cdZ5V/0QXqusHtIJ ynJuRGDaZlrfbBXst6yur84bg9eP595x9biO7SrTiLba6qkCZUKJqYpIkQ2vQkVJrY7R WTfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=453EV6+Vk4UiA+QPML9PMd8FW+X3vUlRpn0D8jE/Fgo=; b=k/JFootsMQ/0Kpugq7sCruhveDFLLLYKgE74IbEnDZCkGy5rsyam0IBYx875132xKM 7RzBoY7H8Cg/KSs4NgMdIeBGSC1qw5AWknSCHR1Bi1Lyo7oncG2jle0JRF77PKb9rUtX ftUYU4fQmVgzWEzX3gm4MwUJTR0IqhmZQaI16iytd1iB7mGK/q/HUX3sCV2vB/QHZjUD Cm73bLirVMb3GxDwvlnzXgXroxbCnN688e5/HpYfbAl3j/z9cn6jW7LWRKHQn8r19cK4 EJu+p+yTqg0vfyzQAGmZnfxkcg14gzKMNv78NwYXIwozJsgf0q7vHufkrdSx6lF/CF5L Vemg== X-Gm-Message-State: ACgBeo2/22tnJ1EKNuv4+BQxxfqhc6WNc7+gv94y5PH3NGleXD9pTvMD iJdXSRO9+JKyBEB9AzpckxmpvEfGC+nQLe7BGHabP5g= X-Google-Smtp-Source: AA6agR7tfUg+Kd0H5LSYnHQimuQZkixdgr5ZQLXLZs3DX9y9WHjwNdx1tzVmDcJHpoDVMuD3/nNoiufbRyvjgV/UQwk= X-Received: by 2002:a17:906:d54c:b0:750:5e1c:b88c with SMTP id cr12-20020a170906d54c00b007505e1cb88cmr7495250ejc.485.1662669057310; Thu, 08 Sep 2022 13:30:57 -0700 (PDT) In-Reply-To: <2e25ca87e3c6ebb795d7@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241943 Archived-At: --0000000000008a42c805e8304e66 Content-Type: text/plain; charset="UTF-8" Good to hear. I think in all cases it should be left to the coder to temporarily lift restrictions, even if those are "locked", maybe with strong warnings in documentation. Speed should always come a second priority to functionality. Besides, Logview (one example of what would suffer if widening is impossible) is very fast. As an example of why widening might be needed: fontification may depend on preceding text in the buffer. Maybe standard Emacs fontification code handles that separately, but e.g. Logview (almost) completely replaces the standard code here with a home-grown solution aimed specifically at log files. And actually this was done exactly for speed. Anyway, I hope this is finished soon. Paul On Thu, 8 Sept 2022 at 21:57, Gregory Heytings wrote: > > > > > "Locked narrowing" added in Emacs 29 cannot be (temporarily) canceled by > > code called inside. > > > > This issue is being worked on, see the (not yet finished) > feature/improved-locked-narrowing branch. > --0000000000008a42c805e8304e66 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Good to hear. I think in all cases it should be left to th= e coder to
temporarily lift restrictions, even if those are "locke= d", maybe
with strong warnings in documentation. Speed should alwa= ys
come a second priority to functionality. Besides, Logview (one=
example of what would suffer if widening is impossible) is very<= /div>
fast.

As an example of why widenin= g might be needed: fontification
may depend on preceding text in = the buffer. Maybe standard
Emacs fontification code handles that = separately, but e.g.
Logview (almost) completely replaces the= standard code here
with a home-grown solution aimed specifically= at log files. And
actually this was done exactly for speed.

Anyway, I hope this is finished soon.

Paul

On Thu, 8 Sept 2022 at 21:57, Gregory Heytings <gregory@heytings.org> wrote:
<= /div>

>
> "Locked narrowing" added in Emacs 29 cannot be (temporarily)= canceled by
> code called inside.
>

This issue is being worked on, see the (not yet finished)
feature/improved-locked-narrowing branch.
--0000000000008a42c805e8304e66--