bug#15467: CSS-mode gives weird indentation when you put opening bracket on its own line

bug#15467: CSS-mode gives weird indentation when you put opening bracket on its own line

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

For example, if you create a CSS buffer and put

.xxx
{
}

into it, indentation adds one space before '{'. Confusingly, if you add one
or more empty line at the start (i.e. before this only rule), indentation
is back to normal, with '{' in the column 0. However, this seems to apply
only to the very first rule, all others are always broken.

Paul

[-- Attachment #2: Type: text/html, Size: 479 bytes --]

bug#15467: CSS-mode gives weird indentation when you put opening bracket on its own line

[Stefan Monnier]

> For example, if you create a CSS buffer and put
> .xxx
> {
> }
> into it, indentation adds one space before '{'. Confusingly, if you add one

Indeed, thanks.  Should be fixed now in the trunk thanks to the
patch below.


        Stefan


--- lisp/textmodes/css-mode.el	2013-08-29 21:00:18 +0000
+++ lisp/textmodes/css-mode.el	2013-10-04 21:40:55 +0000
@@ -302,6 +302,7 @@
   (pcase (cons kind token)
     (`(:elem . basic) css-indent-offset)
     (`(:elem . arg) 0)
+    (`(:list-intro . "") t)             ;"" stands for BOB (bug#15467).
     (`(:before . "{") (if (smie-rule-hanging-p)
                          (smie-rule-parent 0)))))
 

bug#15467: CSS-mode gives weird indentation when you put opening bracket on its own line

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

This fixes the problem I originally reported, but there seem to be more:

.x1
{
}

.x2
 {
 }

div.x3
   {
   }

As you see only the first rule is indented properly.

As a feature request, it would be nice if '}' triggered auto-indent on
insertion, as in e.g. various programming modes.

Paul


On 4 October 2013 23:46, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> > For example, if you create a CSS buffer and put
> > .xxx
> > {
> > }
> > into it, indentation adds one space before '{'. Confusingly, if you add
> one
>
> Indeed, thanks.  Should be fixed now in the trunk thanks to the
> patch below.
>
>
>         Stefan
>
>
> --- lisp/textmodes/css-mode.el  2013-08-29 21:00:18 +0000
> +++ lisp/textmodes/css-mode.el  2013-10-04 21:40:55 +0000
> @@ -302,6 +302,7 @@
>    (pcase (cons kind token)
>      (`(:elem . basic) css-indent-offset)
>      (`(:elem . arg) 0)
> +    (`(:list-intro . "") t)             ;"" stands for BOB (bug#15467).
>      (`(:before . "{") (if (smie-rule-hanging-p)
>                           (smie-rule-parent 0)))))
>
>
>

[-- Attachment #2: Type: text/html, Size: 1650 bytes --]

bug#15467: CSS-mode gives weird indentation when you put opening bracket on its own line

[Stefan Monnier]

> This fixes the problem I originally reported, but there seem to be more:
> .x1
> {
> }

> .x2
>  {
>  }

> div.x3
>    {
>    }

Thanks.  Should be fixed now.

> As a feature request, it would be nice if '}' triggered auto-indent on
> insertion, as in e.g. various programming modes.

Now electric-indent-mode obeys css-electric-keys.


        Stefan

bug#15467: CSS-mode gives weird indentation when you put opening bracket on its own line

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

Thank you, now everything works fine.

Paul


On 7 October 2013 17:41, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> > This fixes the problem I originally reported, but there seem to be more:
> > .x1
> > {
> > }
>
> > .x2
> >  {
> >  }
>
> > div.x3
> >    {
> >    }
>
> Thanks.  Should be fixed now.
>
> > As a feature request, it would be nice if '}' triggered auto-indent on
> > insertion, as in e.g. various programming modes.
>
> Now electric-indent-mode obeys css-electric-keys.
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 1066 bytes --]