bug#34037: [PATCH] Make `package' not "uninhibit" messages

bug#34037: [PATCH] Make `package' not "uninhibit" messages

[Paul Pogonyshev]

[-- Attachment #1.1: Type: text/plain, Size: 131 bytes --]

Two `package' functions can reset `inhibit-message' that is already set to
t by outer code. Attached trivial patch fixes it.

Paul

[-- Attachment #1.2: Type: text/html, Size: 184 bytes --]

[-- Attachment #2: 0001-Make-package-not-uninhibit-messages.patch --]
[-- Type: text/x-patch, Size: 1423 bytes --]

From d5bebf1d282ee620f500393a40dc63eca29a1b10 Mon Sep 17 00:00:00 2001
From: Paul Pogonyshev <pogonyshev@gmail.com>
Date: Thu, 10 Jan 2019 20:39:54 +0100
Subject: [PATCH] Make `package' not "uninhibit" messages

---
 lisp/emacs-lisp/package.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 1752c7e9fe..dc279f55c2 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1605,7 +1605,7 @@ package-refresh-contents
     (make-directory package-user-dir t))
   (let ((default-keyring (expand-file-name "package-keyring.gpg"
                                            data-directory))
-        (inhibit-message async))
+        (inhibit-message (or inhibit-message async)))
     (when (and package-check-signature (file-exists-p default-keyring))
       (condition-case-unless-debug error
           (package-import-keyring default-keyring)
@@ -3245,7 +3245,7 @@ package-menu--perform-transaction
     (redisplay 'force)
     (dolist (elt (package--sort-by-dependence delete-list))
       (condition-case-unless-debug err
-          (let ((inhibit-message package-menu-async))
+          (let ((inhibit-message (or inhibit-message package-menu-async)))
             (package-delete elt nil 'nosave))
         (error (message "Error trying to delete `%s': %S"
                  (package-desc-full-name elt)
-- 
2.19.2

bug#34037: ping

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

Can anyone please install this patch? To see the problem, run from command
line:

$ rm -rf /tmp/elpa; emacs --batch --eval "(let ((inhibit-message t)
(package-archives '((\"melpa-stable\" .
\"http://stable.melpa.org/packages/\")))
(package-user-dir \"/tmp/elpa\")) (package-initialize t)
(package-refresh-contents))"

[-- Attachment #2: Type: text/html, Size: 541 bytes --]

bug#34037: [PATCH] Make `package' not "uninhibit" messages

[Noam Postavsky]

tags 34037 fixed
close 34037 27.1
quit

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> Two `package' functions can reset `inhibit-message' that is already set to
> t by outer code. Attached trivial patch fixes it.

Pushed to master.

8d3fff6bd6 2019-05-16T20:08:27-04:00 "Make `package' not "uninhibit" messages (Bug#34037)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8d3fff6bd68198b1a76dce559b0b8a5f87cd5103