From: yary <not.com@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 15577 <15577@debbugs.gnu.org>
Subject: bug#15577: 24.3; dir-local variables not applied when switching major-mode
Date: Sun, 20 Oct 2013 09:00:57 -0400 [thread overview]
Message-ID: <CAG2CFAbtEy2kQ=iXYmct9stzde8U1g+NQ_mWGgA+yb_=igHkiw@mail.gmail.com> (raw)
In-Reply-To: <jwvfvrx9bbh.fsf-monnier+emacsbugs@gnu.org>
For anyone following this discussion, I moved the non-dir-local parts to:
bug#15658: Easy way to make a file-local variable also permanent-local
bug#15659: Simple method for preserving minor-mode
>> Moving dir-local setup code to after-change-major-mode-hook would be a
>> simple fix for issue #1. File-local (as it is now) in
>> after-change-major-mode-hook would cause some problems eg. if a
>> file-local sets the mode!
>
>Obviously if we move the mode-setting part, we introduce a bug, so we
>wouldn't move it (it's already handled separately for the same kind of
>reasons).
Right. So it looks like a patch for moving dir-local setup to
after-change-major-mode-hook is in order. Where I fall down in the
implementation is figuring out what exactly changes so that I don't
change behavior for find-file or kill-all-local-variables, and also
don't set dir-locals twice when opening a file (without using
defadvice which seems wrong in the core). Plus I'd have to get started
as a contributor. Neither are insurmountable, though I think I don't
have much more time to devote to these at the moment.
next prev parent reply other threads:[~2013-10-20 13:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 20:14 bug#15577: 24.3; dir-local variables not applied when switching major-mode yary
2013-10-09 21:42 ` Glenn Morris
2013-10-10 18:34 ` yary
2013-10-10 21:27 ` Glenn Morris
2013-10-10 21:52 ` Stefan Monnier
2013-10-10 23:12 ` yary
2013-10-14 18:41 ` yary
2013-10-16 14:26 ` yary
2013-10-18 15:43 ` yary
2013-10-19 1:18 ` Stefan Monnier
2013-10-19 19:08 ` yary
2013-10-19 21:55 ` Stefan Monnier
2013-10-20 13:00 ` yary [this message]
2013-10-20 13:38 ` Phil Sainty
2013-10-21 13:11 ` Stefan Monnier
2013-10-21 13:23 ` yary
2013-10-21 14:23 ` Stefan Monnier
2013-10-21 21:58 ` Phil Sainty
2013-10-18 16:29 ` Phil Sainty
[not found] ` <mailman.3789.1381430919.10748.bug-gnu-emacs@gnu.org>
2016-05-05 11:26 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG2CFAbtEy2kQ=iXYmct9stzde8U1g+NQ_mWGgA+yb_=igHkiw@mail.gmail.com' \
--to=not.com@gmail.com \
--cc=15577@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.