From: Kaushal Modi <kaushal.modi@gmail.com>
To: 19717@debbugs.gnu.org, jorge.alfaro-murillo@yale.edu,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#19717: 24.4.50; printing.el still uses ps-eval-switch
Date: Wed, 11 May 2016 17:08:21 +0000 [thread overview]
Message-ID: <CAFyQvY3xmtE+Ng9VgEqFGRBA7nXSrt8-bWUjgESfymx7tLE95w@mail.gmail.com> (raw)
In-Reply-To: <87wq4667tb.fsf@yale.edu>
[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]
Hi,
I have attached the below patch in an attempt to fix this. I notice that
printing.el requires lpr.el, and pr-switches function anyways uses
lpr-flatten-list from lpr.el. So there should be no harm using
lpr-eval-switch instead of ps-eval-switch. I have verified that
lpr-eval-switch is the exact same function as the now obsolete
ps-eval-switch; just different names.
Copying Stefan for reviewing and commiting this patch as he was the author
of the commit
http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-25&id=2cdeb903c57126d3ad5f0cbd72e182584b76ee29
where
ps-eval-switch was removed.
=====
From 4af9c6403b5917aca27490cc331a36dd6e1222c3 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Wed, 11 May 2016 12:45:42 -0400
Subject: [PATCH] Fix reference to obsolete fn ps-eval-switch
The `lpr-eval-switch' is functionally the same as `ps-eval-switch' which
was obsoleted in 2cdeb903c57126d3ad5f0cbd72e182584b76ee29. So using
that instead (Bug#19717).
* printing.el (pr-switches): Use lpr-eval-switch instead of ps-eval-switch.
---
lisp/printing.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/printing.el b/lisp/printing.el
index 3bd5a67..a336aeb 100644
--- a/lisp/printing.el
+++ b/lisp/printing.el
@@ -5673,7 +5673,7 @@ pr-switches
(or (listp switches)
(error "%S should have a list of strings" mess))
(lpr-flatten-list ; dynamic evaluation
- (mapcar 'ps-eval-switch switches)))
+ (mapcar 'lpr-eval-switch switches)))
(defun pr-ps-preview (kind n-up filename mess)
--
2.6.0.rc0.24.gec371ff
--
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 2375 bytes --]
next prev parent reply other threads:[~2016-05-11 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 19:09 bug#19717: 24.4.50; printing.el still uses ps-eval-switch Jorge A. Alfaro-Murillo
2016-05-11 17:08 ` Kaushal Modi [this message]
2016-05-12 0:56 ` Stefan Monnier
2016-05-12 1:42 ` Kaushal Modi
2016-05-23 0:52 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY3xmtE+Ng9VgEqFGRBA7nXSrt8-bWUjgESfymx7tLE95w@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=19717@debbugs.gnu.org \
--cc=jorge.alfaro-murillo@yale.edu \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.