From: Kaushal Modi <kaushal.modi@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Default share/ and lisp/ directories?
Date: Tue, 20 Feb 2018 20:27:01 +0000 [thread overview]
Message-ID: <CAFyQvY3qrMGNuXaZZr8VR+tBSvYN+33CJFsJ0CZ5TZVLFguF6w@mail.gmail.com> (raw)
In-Reply-To: <31b4fa70-3cbf-4d75-8d62-4f27c8272d49@default>
[-- Attachment #1: Type: text/plain, Size: 3325 bytes --]
On Tue, Feb 20, 2018 at 1:48 PM Drew Adams <drew.adams@oracle.com> wrote:
> Suggestion: use functions for manipulating file/dir names.
>
> Use (file-name-directory (directory-file-name (expand-file-name file)))
>
Thank you. I was aware of that, but was just being plain lazy.. I didn't
consider refactoring my whole config to fix that until now[1], so thanks :)
Here's the improved code:
(let* ((bin-dir (when (and invocation-directory
(file-exists-p invocation-directory))
(file-truename invocation-directory)))
(prefix-dir (when bin-dir ;Because bin-dir = prefix-dir +
"bin/"
(file-name-directory (directory-file-name bin-dir))))
(share-dir (when (and prefix-dir
(file-exists-p prefix-dir))
(file-name-as-directory (expand-file-name "share"
prefix-dir))))
(emacs-dir (when (and share-dir
(file-exists-p share-dir))
(file-name-as-directory (expand-file-name "emacs"
share-dir))))
(version-dir (when emacs-dir
;; Possibility where the lisp dir is something like
;; ../emacs/26.0.50/lisp/. If `emacs-version' is
x.y.z.w,
;; remove the ".w" portion. Though, this is not
needed
;; for emacs 26+, and also will do nothing in that
case.
;;
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=22b2207471807bda86534b4faf1a29b3a6447536
(let* ((version (replace-regexp-in-string
"\\([0-9]+\\.[0-9]+\\.[0-9]+\\).*" "\\1" emacs-version))
(version-dir-1 (file-name-as-directory
(expand-file-name version emacs-dir))))
(if (file-exists-p version-dir-1)
version-dir-1
;; Possibility where the lisp dir is something
like
;; ../emacs/25.2/lisp/. If `emacs-version' is
x.y.z,
;; remove the ".z" portion.
(setq version (replace-regexp-in-string
"\\([0-9]+\\.[0-9]+\\).*" "\\1" emacs-version))
(setq version-dir-1 (file-name-as-directory
(expand-file-name version emacs-dir)))
(when (file-exists-p version-dir-1)
version-dir-1)))))
(lisp-dir (file-name-as-directory (expand-file-name "lisp"
version-dir))))
(defvar modi/default-share-directory (when (file-exists-p share-dir)
share-dir)
"Share directory for this Emacs installation.")
(defvar modi/default-lisp-directory (when (file-exists-p lisp-dir)
lisp-dir)
"Directory containing lisp files for the Emacs installation.
This value must match the path to the lisp/ directory of the
Emacs installation. If Emacs is installed using
--prefix=\"${PREFIX_DIR}\" this value would typically be
\"${PREFIX_DIR}/share/emacs/<VERSION>/lisp/\"."))
I think it would be useful to include the share/ and lisp/ dirs stored in
some variable in emacs core, just like invocation-directory.
[1]:
https://github.com/kaushalmodi/.emacs.d/commit/64b0c3fbf3372bd96a32d1f24d9adeb9112abd08
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 4879 bytes --]
next prev parent reply other threads:[~2018-02-20 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 18:09 Default share/ and lisp/ directories? Kaushal Modi
2018-02-20 18:48 ` Drew Adams
2018-02-20 20:27 ` Kaushal Modi [this message]
2018-02-20 21:06 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY3qrMGNuXaZZr8VR+tBSvYN+33CJFsJ0CZ5TZVLFguF6w@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.