From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#28412: 26.0.50; Let save-some-buffers accept write-contents-functions Date: Mon, 18 Sep 2017 16:16:05 +0000 Message-ID: References: <87bmmikyug.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="089e0828d2c0f39b3d0559790f2f" X-Trace: blaine.gmane.org 1505751737 12769 195.159.176.226 (18 Sep 2017 16:22:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Sep 2017 16:22:17 +0000 (UTC) To: 28412@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 18 18:22:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtyoD-0002vl-F4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Sep 2017 18:22:09 +0200 Original-Received: from localhost ([::1]:37679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtyoJ-0000Qu-2S for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Sep 2017 12:22:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtyjJ-0004CR-R4 for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 12:17:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtyjG-0003uD-Jq for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 12:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtyjG-0003tx-Ev for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 12:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dtyjG-0007OG-1I for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 12:17:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87bmmikyug.fsf@ericabrahamsen.net> Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2017 16:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28412-submit@debbugs.gnu.org id=B28412.150575138628355 (code B ref 28412); Mon, 18 Sep 2017 16:17:01 +0000 Original-Received: (at 28412) by debbugs.gnu.org; 18 Sep 2017 16:16:26 +0000 Original-Received: from localhost ([127.0.0.1]:46671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtyif-0007NH-Nh for submit@debbugs.gnu.org; Mon, 18 Sep 2017 12:16:25 -0400 Original-Received: from mail-yw0-f177.google.com ([209.85.161.177]:43183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtyid-0007N2-3s for 28412@debbugs.gnu.org; Mon, 18 Sep 2017 12:16:23 -0400 Original-Received: by mail-yw0-f177.google.com with SMTP id s62so706828ywg.0 for <28412@debbugs.gnu.org>; Mon, 18 Sep 2017 09:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=9AtSDToEb3Mc6OtwKwDpo0a5egvChOBZOH84VbOJRtA=; b=RYfXMaRSkKVW3Q2SClGUl5sk7w5NbXVo2NolJNvZQmO/Q+UOzNrizOHGpauwnOkeKu MXhe2xCppYQVPltyPjYYLflrJ11kCqpvjYLgoAzrzI5DydGtlRMzN3Hnopf07QR/JwPQ FvhNdDS9/iqNEkhA+/m8jPdmUM7hy7S21qh0+QGrFYd11R0OaXaFRxS12+Qywx8y5lpw 8ZF8vlupmh60Kq2kYTS7hb5LImmsg+WOS1n8J8LaLcqXhx2jAJDBbhJvNMd5CdQWKVUz yod1NctdF9g9YUKMD+RwQaWgmprpI8oyNdvsA3v2dAb5tMj/ITPIr5AeTianUaz2bC0y kJ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9AtSDToEb3Mc6OtwKwDpo0a5egvChOBZOH84VbOJRtA=; b=mJQc/By+0A4xBxnmIo6CShAJB6i5CgyFylmwjG+koYzD+2HlQ8R34MLqSZRPEGHvnn 1wbLuHKWzKmzHECPH/kjjB3DbuLkcq1VG+NkRm7+YgyXOYPGqpiBl/kN8ncP0k93EQT7 jL1wKf2qMlJD7N1kVpqrGCTk+rR5HvrDKSfnLZ5P3ajXk2/QU4+JZ7kxvt5JEAjl++dT Lz5nn2wKtsM6EAY2AneEiKdyDCkBAxHXeo4VylghPRJkeOHvZASSyKGhwrhT/R3f+1mg dB/ngALDTLO1wp856vX1QQS+oyMLpuszU331bDuCRRphA00TlWIgMRBalAA/Fi7WaRBG gPhw== X-Gm-Message-State: AHPjjUhDMbtEh5BQvoGZMImTzE74cvC8pr7SCHe7S/TPOWqesQkveCl9 OnHAOYs8G3BNVAFegc19TMOlCgPJKTnrvGzyoJY= X-Google-Smtp-Source: AOwi7QAF+PwY2MBauC+9o/8g9YqGbu6hLmoK/Nqdlfat8sqyjAeLObEXtW8/FJ8dCH8dUdjsqaSfVnQF3Pb11dXTvxE= X-Received: by 10.37.135.9 with SMTP id a9mr26278792ybl.316.1505751377089; Mon, 18 Sep 2017 09:16:17 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137062 Archived-At: --089e0828d2c0f39b3d0559790f2f Content-Type: text/plain; charset="UTF-8" Hello Eric, Eli: I became a victim of this change because of these overlapping use-cases: - I use ggtags.el that creates a hidden (is that the right term for that?) buffer (starting with space) to fontify code snippets using the file's major mode. - The major mode I use (verilog-mode) sets write-file-functions to a non-nil value. So each time I quit emacs, I get a prompt to save that hidden buffer " *Code-Fontify*" (which it didn't earlier, as intended). Details: https://github.com/leoliu/ggtags/issues/157 I suggested calling (set-buffer-modified-p nil) in that special buffer. But is that the best way to fix this? Or should save-some-buffers never try to save buffers whose names begin with space? PS: Please CC me on the replies, else I won't get those. -- Kaushal Modi --089e0828d2c0f39b3d0559790f2f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Eric, Eli:=C2=A0

I became a victi= m of this change because of these overlapping use-cases:

- I use ggtags.el that creates a hidden (is that the right term for = that?) buffer (starting with space) to fontify code snippets using the file= 's major mode.
- The major mode I use (verilog-mode) sets wri= te-file-functions to a non-nil value.

So each time= I quit emacs, I get a prompt to save that hidden buffer " *Code-Fonti= fy*" (which it didn't earlier, as intended).

<= div>Details:=C2=A0https://github.com/leoliu/ggtags/issues/157
=
I suggested calling (set-buffer-modified-p nil) in that spec= ial buffer.=C2=A0

But is that the best way to fix = this? Or should save-some-buffers never try to save buffers whose names beg= in with space?

PS: Please CC me on the replies, el= se I won't get those.

--

Kaushal Modi

--089e0828d2c0f39b3d0559790f2f--