From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#28412: 26.0.50; Let save-some-buffers accept write-contents-functions Date: Mon, 18 Sep 2017 19:23:10 +0000 Message-ID: References: <87bmmikyug.fsf@ericabrahamsen.net> <838thbj32x.fsf@gnu.org> <87377jizy6.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c0bb8e2fe811d05597bacae" X-Trace: blaine.gmane.org 1505762726 17235 195.159.176.226 (18 Sep 2017 19:25:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Sep 2017 19:25:26 +0000 (UTC) Cc: 28412@debbugs.gnu.org To: Eric Abrahamsen , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 18 21:25:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du1fW-00046Z-1K for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Sep 2017 21:25:22 +0200 Original-Received: from localhost ([::1]:38511 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du1fa-00068m-7X for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Sep 2017 15:25:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du1eJ-0004wJ-Jp for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 15:24:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1du1eE-0002Oj-LU for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 15:24:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1du1eE-0002OY-Hq for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 15:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1du1eE-0007Gs-Cs for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 15:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2017 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28412-submit@debbugs.gnu.org id=B28412.150576261027904 (code B ref 28412); Mon, 18 Sep 2017 19:24:02 +0000 Original-Received: (at 28412) by debbugs.gnu.org; 18 Sep 2017 19:23:30 +0000 Original-Received: from localhost ([127.0.0.1]:46837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du1di-0007G0-0c for submit@debbugs.gnu.org; Mon, 18 Sep 2017 15:23:30 -0400 Original-Received: from mail-yw0-f176.google.com ([209.85.161.176]:54013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du1df-0007Fm-Cy for 28412@debbugs.gnu.org; Mon, 18 Sep 2017 15:23:27 -0400 Original-Received: by mail-yw0-f176.google.com with SMTP id x131so1058927ywa.10 for <28412@debbugs.gnu.org>; Mon, 18 Sep 2017 12:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=57Ss5JLmH+LF1TGP87M4MnMHi46D9VfklYaBj2xqpGI=; b=I6NCPLpN0/x+i7csbVf5NUApg/gH3cXQBaEcp7hUoXK0xMImr+zs+5UH2JNRuZVOF1 elLrfa/QCZrI8GdxkTO4gWlB+k/Rxmq7/gSga+YlqysXW7i5PfX7xKiOcruCOS5eqTG/ ci8NwHyEsF5Wh8d5eqYqd2m3VkgY0J+eD7ELQh0LnqfVbD6HR6Xb2UlaWFepQPqGsp9N 8gYCWY/XJ5BxSajpT64NoaAlKvpeIBNb2z9s8bCPtSmNe9Qd0YCZCp1kT0uecT69ZBsy oD15alOsSM+lub63A9XxdQILKO5qitHoz0yz6+wmNmEIS7MNeUbW8kwSi03ZOF31cmOo EVRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=57Ss5JLmH+LF1TGP87M4MnMHi46D9VfklYaBj2xqpGI=; b=I2guKKyMl+1fxF8N+25gb7hrg8tKE+DxrafPae0cbCtjU1gPt8yIzWoA31GmmPzMPC BSZyCdbMdOtcbP+wBsTWqM5/ftkxxu3AvVOCYzTgRgXrDQuacKvaoH5Ct6Qup5yzqj7e FcwAOwT+/la4CAFIETHzkfwOLXED3nV0+9WO2Qkzs47mf70ohntzbNIJ1x6ztJT8zyvN jIVdYO9NcJIfR25xsoS4Y6vnRT+wox+6Eq50Zq4uqVAyieKJAqchlKhBMuUeyfjSpiej VGEoVVXjUKdvDw66m4dFvrxRHBeQPmcP/5gsVfBnFf1n1yEvewYgGSMp5jFhQT/CuuCV JCGA== X-Gm-Message-State: AHPjjUhf309Ch5i4elujJNT7X1UvdeCO9cHE477PoqPr9rEXnheN+TJM BgYo6Qsiku8RuwN4vJhWpoBgZQcKLBRjAbidpEQ= X-Google-Smtp-Source: ADKCNb68ILdxPVuEJLlg38G91COpQUNrOCH2EHCCRIpxzqssaXoS/pIhshSG6zRMsldyVHw8qJY2cMGv4apiHyBRE8s= X-Received: by 10.129.159.69 with SMTP id w66mr27493182ywg.392.1505762601761; Mon, 18 Sep 2017 12:23:21 -0700 (PDT) In-Reply-To: <87377jizy6.fsf@ericabrahamsen.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137077 Archived-At: --94eb2c0bb8e2fe811d05597bacae Content-Type: text/plain; charset="UTF-8" On Mon, Sep 18, 2017 at 3:12 PM Eric Abrahamsen wrote: > Also, there don't appear to be any built-in functions or regexps for > dealing with "hidden" buffers, I'm assuming: > > (not (string-prefix-p " " (buffer-name buffer))) > > is okay? > That crossed my mind too. So I had started looking for its existing implementation, and found this in buff-menu.el inside list-buffers--refresh function: (string= (substring name 0 1) " ") I was wondering if that should be wrapped into a function like buffer-internal-p (based on the many docstrings like below in buff-menu.el: "By default, the Buffer Menu lists all buffers except those whose names start with a space (which are for internal use)."). Having a function like this would be better than having that logic implemented in different ways in the emacs core. I just don't know the best place to put this function definition. Eli? -- Kaushal Modi --94eb2c0bb8e2fe811d05597bacae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Sep 18= , 2017 at 3:12 PM Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
Also, there don't appear to be any built-in functions or rege= xps for
dealing with "hidden" buffers, I'm assuming:

(not (string-prefix-p " " (buffer-name buffer)))

is okay?

That crossed my mind too. So I= had started looking for its existing implementation, and found this in buf= f-menu.el inside list-buffers--refresh function:

= =C2=A0 =C2=A0 (string=3D (substring name 0 1) " ")
=
I was wondering if that should be wrapped into a function li= ke buffer-internal-p (based on the many docstrings like below in buff-menu.= el: "By default, the Buffer Menu lists all buffers except those whose = names start with a space (which are for internal use)."). Having a fun= ction like this would be better than having that logic implemented in diffe= rent ways in the emacs core.

I just don't know= the best place to put this function definition. Eli?
--

Kaushal Modi

--94eb2c0bb8e2fe811d05597bacae--