From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#24057: 25.1.50; ffap interprets comments beginning with "//" as file path Date: Sat, 18 Mar 2017 01:28:46 +0000 Message-ID: References: <83lh0sx0yf.fsf@gnu.org> <83shv0v716.fsf@gnu.org> <83poq4v4jk.fsf@gnu.org> <83wpkbt92i.fsf@gnu.org> <83mvl5tzv7.fsf@gnu.org> <83invttyv7.fsf@gnu.org> <874lys64bm.fsf@users.sourceforge.net> <87var74h2j.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=f403045ccbb0dfe122054af737d7 X-Trace: blaine.gmane.org 1489800623 22901 195.159.176.226 (18 Mar 2017 01:30:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2017 01:30:23 +0000 (UTC) Cc: 24057@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 18 02:30:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp3C4-0004Rk-Nu for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Mar 2017 02:30:09 +0100 Original-Received: from localhost ([::1]:51528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cp3CA-0001vk-Gk for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Mar 2017 21:30:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cp3C3-0001tw-4t for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2017 21:30:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cp3C0-0000iH-2K for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2017 21:30:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cp3Bz-0000iC-TR for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2017 21:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cp3Bz-0008Ft-Fm for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2017 21:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2017 01:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24057 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24057-submit@debbugs.gnu.org id=B24057.148980054631622 (code B ref 24057); Sat, 18 Mar 2017 01:30:03 +0000 Original-Received: (at 24057) by debbugs.gnu.org; 18 Mar 2017 01:29:06 +0000 Original-Received: from localhost ([127.0.0.1]:33082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp3B4-0008Dx-Et for submit@debbugs.gnu.org; Fri, 17 Mar 2017 21:29:06 -0400 Original-Received: from mail-pf0-f173.google.com ([209.85.192.173]:32844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cp3B2-0008DQ-Cq for 24057@debbugs.gnu.org; Fri, 17 Mar 2017 21:29:04 -0400 Original-Received: by mail-pf0-f173.google.com with SMTP id e129so5518892pfh.0 for <24057@debbugs.gnu.org>; Fri, 17 Mar 2017 18:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tPQiSj7nYyvGFVCYU3Ewk+vqv6wYq8XpIeAQJPZ8hzM=; b=b4FAJf6z3T72chvIRbrnkxxt+Vr1Gat/5Oybjoyr2nMkKEPoI6zk9VayyQl2puE54r /WqkIL6tXfnS2I9tSj2VWBUtn+Yr/ZN9/N8z0eZe1iGso0SWbrss2yizUWUMSMsxg7nE +QxZaRHGNFpT1LCI0P0sNj10nMgWtAosY106w1ycR1eRWvgWjgVJ9OLvKQhkRP9oIxtu c571BfIwSdGaFAIrk4aMHK2G32xYUIA2g7WNDI+7Bwpb5MfInCLZZilhykPGTsHEYcme SByJrvUvLKsMMNFl8CtuThyEM/HbrdNHov1xcxUBLmNtogTbk4wa9JMRNSzSJ/zZUIsJ 99Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tPQiSj7nYyvGFVCYU3Ewk+vqv6wYq8XpIeAQJPZ8hzM=; b=QMkGuDRDJCUzoialN/LWvcjwpJzM0a2zxxG6oT8qVJgLWwZTUnT+kZlCFBqO2NCNKx ciiYE8lRsCFDljSv7/5vNnt8AzzCKjmEJm7BPRsFBY3eptXWQLUKIy6fQ4OSc61aaDmm boHmmxy3iPNylbhliukfoJmIzqPzfwsr6Yh/cGFrmQCli4JpxOinNgRditdfi3r8AnJF KJc9e0fMf9o+BFjl/yFx0yuhHHyk0rkXWcklF/Md3yB7ZcNm+V5S7d0XJ1YGJHY1tD1K GC20wPh6T9VmIHwh/vj81aPT0QhBz3BJO/pm1X2z6VP/A6GdzVg9eXWXJYUjYsk0cF3p y69A== X-Gm-Message-State: AFeK/H1cygcPhyLg4h1KRJSNmYPtCYrLezgRhI4l1XcLo6RHEfWTj/6YkYDdudvLrSwjAgs25D4Jy99x8S041Q== X-Received: by 10.98.139.78 with SMTP id j75mr19831156pfe.122.1489800538274; Fri, 17 Mar 2017 18:28:58 -0700 (PDT) In-Reply-To: <87var74h2j.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130685 Archived-At: --f403045ccbb0dfe122054af737d7 Content-Type: multipart/alternative; boundary=f403045ccbb0dfe11d054af737d5 --f403045ccbb0dfe11d054af737d5 Content-Type: text/plain; charset=UTF-8 On Fri, Mar 17, 2017 at 7:29 PM wrote: > > Oh, then I don't understand why you separated that sentence into its own > paragraph, it seemed like a continuation of the same idea. (In general, > paragraphs should go before the ChangeLog entries, because that format > doesn't allow for multiple paragraphs in the same entry (AFAIK)). > It's alright. I have kept the whole thing as a single paragraph. > > characters (especially for major modes that have '//' as comment start > > characters). Otherwise, in a major mode like c-mode, with `ido-mode' > ^^^ > > There should be double space between sentences though. > The attached patch has this fixed. Btw if you don't mind explaining: - How did you detect that minor missing space? Do you have a minor mode? Or do you have a check function? - Being used to using single spaces at end of sentences, I always forget adding double spaces. Is there a robust way to ensure that sentences always end in double spaces in commit messages and in the docstrings? > > > > Thanks! I did not know about parse-partial-sexp. Here too, I need to > retain > > the save-excursion, else the point will move after the comment start > chars > > if it is at the BOL in c-mode on a line like > > Oops, right. (I would consider just putting a single save-excursion > around the 'when', but it doesn't hugely matter either way (and Drew > would probably not like the single save-excursion version ;) [1]).) > > [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25777#38 It did actually occur to merge the two save-excursions, but for code clarity, I kept them separate. I did not want to merge the save-excursion in the "condition" part with the "action" part in (when (condition) action) The attached patch has the double space fixed in the commit message. Thanks. -- Kaushal Modi --f403045ccbb0dfe11d054af737d5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Fri, Mar 17= , 2017 at 7:29 PM <npo= stavs@users.sourceforge.net> wrote:

Oh, then I don't understand why you separated that sentence into its ow= n
paragraph, it seemed like a continuation of the same idea.=C2=A0 (In genera= l,
paragraphs should go before the ChangeLog entries, because that format
doesn't allow for multiple paragraphs in the same entry (AFAIK)).

It's alright. I have= kept the whole thing as a single paragraph.
=C2=A0
> characters (especially for major modes that have '//' as comme= nt start
> characters). Otherwise, in a major mode like c-mode, with `ido-mode= 9;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^^

There should be double space between sentences though.

The attached patch has this fixed.

Btw if you don't mind explaining:
- How = did you detect that minor missing space? Do you have a minor mode? Or do yo= u have a check function?
- Being used to using single spaces at e= nd of sentences, I always forget adding double spaces. Is there a robust wa= y to ensure that sentences always end in double spaces in commit messages a= nd in the docstrings?

=C2=A0
>
> Thanks! I did not know about parse-partial-sexp. Here too, I need to r= etain
> the save-excursion, else the point will move after the comment start c= hars
> if it is at the BOL in c-mode on a line like

Oops, right.=C2=A0 (I would consider just putting a single save-excursion around the 'when', but it doesn't hugely matter either way (and= Drew
would probably not like the single save-excursion version ;) [1]).)

[1]: https://debbugs.gnu= .org/cgi/bugreport.cgi?bug=3D25777#38

I= t did actually occur to merge the two save-excursions, but for code clarity= , I kept them separate. I did not want to merge the save-excursion in the &= quot;condition" part with the "action" part in=C2=A0

=C2=A0 =C2=A0 (when (condition)
=C2=A0 =C2=A0 = =C2=A0 action)
=C2=A0 =C2=A0=C2=A0
=C2=A0The attached p= atch has the double space fixed in the commit message.

=
Thanks.=C2=A0
--

Kaushal Modi

--f403045ccbb0dfe11d054af737d5-- --f403045ccbb0dfe122054af737d7 Content-Type: application/octet-stream; name="0001-Do-not-include-comment-start-chars-in-ffap-string.patch" Content-Disposition: attachment; filename="0001-Do-not-include-comment-start-chars-in-ffap-string.patch" Content-Transfer-Encoding: base64 Content-ID: <15adf02f29d27af84df1> X-Attachment-Id: 15adf02f29d27af84df1 RnJvbSBjZjYxZmExMWRkMGUwYTczNTNjNjk3OTU3YTE2ZWMxODJiMTg4ZmE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXVzaGFsIE1vZGkgPGthdXNoYWwubW9kaUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgMTcgTWFyIDIwMTcgMTg6MDM6MjMgLTA0MDAKU3ViamVjdDogW1BBVENIXSBE byBub3QgaW5jbHVkZSBjb21tZW50IHN0YXJ0IGNoYXJzIGluIGZmYXAgc3RyaW5nCgoqIGxpc3Av ZmZhcC5lbCAoZmZhcC1zdHJpbmctYXQtcG9pbnQpOiBJZiB0aGUgcG9pbnQgaXMgaW4gYSBjb21t ZW50LAplbnN1cmUgdGhhdCB0aGUgcmV0dXJuZWQgc3RyaW5nIGRvZXMgbm90IGNvbnRhaW4gdGhl IGNvbW1lbnQgc3RhcnQKY2hhcmFjdGVycyAoZXNwZWNpYWxseSBmb3IgbWFqb3IgbW9kZXMgdGhh dCBoYXZlICcvLycgYXMgY29tbWVudCBzdGFydApjaGFyYWN0ZXJzKS4gIE90aGVyd2lzZSwgaW4g YSBtYWpvciBtb2RlIGxpa2UgYy1tb2RlLCB3aXRoIGBpZG8tbW9kZScKZW5hYmxlZCBhbmQgYGlk by11c2UtZmlsZW5hbWUtYXQtcG9pbnQnIHNldCB0byBgZ3Vlc3MnLCBkb2luZyAiQy14CkMtZiIg b24gYSAiLy9mb28iIGNvbW1lbnQgd2lsbCBpbml0aWF0ZSBhbiBhdHRlbXB0IHRvIGFjY2VzcyBh IHBhdGgKIi8vZm9vIiAoQnVnIzI0MDU3KS4KCkNvLWF1dGhvcmVkLWJ5OiBOb2FtIFBvc3RhdnNr eSA8bnBvc3RhdnNAZ21haWwuY29tPgotLS0KIGxpc3AvZmZhcC5lbCB8IDQxICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMzggaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2ZmYXAuZWwgYi9saXNw L2ZmYXAuZWwKaW5kZXggZDcyMjJiZmI2OC4uYTE1MDgzZjRmYSAxMDA2NDQKLS0tIGEvbGlzcC9m ZmFwLmVsCisrKyBiL2xpc3AvZmZhcC5lbApAQCAtMTExMCwzMiArMTExMCw2NyBAQCBmZmFwLXN0 cmluZy1hdC1wb2ludAogCiAoZGVmdW4gZmZhcC1zdHJpbmctYXQtcG9pbnQgKCZvcHRpb25hbCBt b2RlKQogICAiUmV0dXJuIGEgc3RyaW5nIG9mIGNoYXJhY3RlcnMgZnJvbSBhcm91bmQgcG9pbnQu CisKIE1PREUgKGRlZmF1bHRzIHRvIHZhbHVlIG9mIGBtYWpvci1tb2RlJykgaXMgYSBzeW1ib2wg dXNlZCB0byBsb29rIHVwCiBzdHJpbmcgc3ludGF4IHBhcmFtZXRlcnMgaW4gYGZmYXAtc3RyaW5n LWF0LXBvaW50LW1vZGUtYWxpc3QnLgorCiBJZiBNT0RFIGlzIG5vdCBmb3VuZCwgd2UgdXNlIGBm aWxlJyBpbnN0ZWFkIG9mIE1PREUuCisKIElmIHRoZSByZWdpb24gaXMgYWN0aXZlLCByZXR1cm4g YSBzdHJpbmcgZnJvbSB0aGUgcmVnaW9uLgotU2V0IHRoZSB2YXJpYWJsZSBgZmZhcC1zdHJpbmct YXQtcG9pbnQnIGFuZCB0aGUgdmFyaWFibGUKKworSWYgdGhlIHBvaW50IGlzIGluIGEgY29tbWVu dCwgZW5zdXJlIHRoYXQgdGhlIHJldHVybmVkIHN0cmluZyBkb2VzIG5vdAorY29udGFpbiB0aGUg Y29tbWVudCBzdGFydCBjaGFyYWN0ZXJzIChlc3BlY2lhbGx5IGZvciBtYWpvciBtb2RlcyB0aGF0 CitoYXZlICcvLycgYXMgY29tbWVudCBzdGFydCBjaGFyYWN0ZXJzKS4KKworU2V0IHRoZSB2YXJp YWJsZXMgYGZmYXAtc3RyaW5nLWF0LXBvaW50JyBhbmQKIGBmZmFwLXN0cmluZy1hdC1wb2ludC1y ZWdpb24nLgorCiBXaGVuIHRoZSByZWdpb24gaXMgYWN0aXZlIGFuZCBsYXJnZXIgdGhhbiBgZmZh cC1tYXgtcmVnaW9uLWxlbmd0aCcsCiByZXR1cm4gYW4gZW1wdHkgc3RyaW5nLCBhbmQgc2V0IGBm ZmFwLXN0cmluZy1hdC1wb2ludC1yZWdpb24nIHRvICcoMSAxKS4iCiAgIChsZXQqICgoYXJncwog CSAgKGNkcgogCSAgIChvciAoYXNzcSAob3IgbW9kZSBtYWpvci1tb2RlKSBmZmFwLXN0cmluZy1h dC1wb2ludC1tb2RlLWFsaXN0KQogCSAgICAgICAoYXNzcSAnZmlsZSBmZmFwLXN0cmluZy1hdC1w b2ludC1tb2RlLWFsaXN0KSkpKQorICAgICAgICAgKHJlZ2lvbi1zZWxlY3RlZCAodXNlLXJlZ2lv bi1wKSkKIAkgKHB0IChwb2ludCkpCi0JIChiZWcgKGlmICh1c2UtcmVnaW9uLXApCisgICAgICAg ICAoYmVnIChpZiByZWdpb24tc2VsZWN0ZWQKIAkJICAocmVnaW9uLWJlZ2lubmluZykKIAkJKHNh dmUtZXhjdXJzaW9uCiAJCSAgKHNraXAtY2hhcnMtYmFja3dhcmQgKGNhciBhcmdzKSkKIAkJICAo c2tpcC1jaGFycy1mb3J3YXJkIChudGggMSBhcmdzKSBwdCkKIAkJICAocG9pbnQpKSkpCi0JIChl bmQgKGlmICh1c2UtcmVnaW9uLXApCisgICAgICAgICAoZW5kIChpZiByZWdpb24tc2VsZWN0ZWQK IAkJICAocmVnaW9uLWVuZCkKIAkJKHNhdmUtZXhjdXJzaW9uCiAJCSAgKHNraXAtY2hhcnMtZm9y d2FyZCAoY2FyIGFyZ3MpKQogCQkgIChza2lwLWNoYXJzLWJhY2t3YXJkIChudGggMiBhcmdzKSBw dCkKIAkJICAocG9pbnQpKSkpCiAgICAgICAgICAocmVnaW9uLWxlbiAoLSAobWF4IGJlZyBlbmQp IChtaW4gYmVnIGVuZCkpKSkKKworICAgIDs7IElmIHRoZSBpbml0aWFsIGNoYXJhY3RlcnMgb2Yg dGhlIHRvLWJlLXJldHVybmVkIHN0cmluZyBhcmUgdGhlCisgICAgOzsgY3VycmVudCBtYWpvciBt b2RlJ3MgY29tbWVudCBzdGFydGVyIGNoYXJhY3RlcnMsICphbmQqIGFyZQorICAgIDs7IG5vdCBw YXJ0IG9mIGEgY29tbWVudCwgcmVtb3ZlIHRob3NlIGZyb20gdGhlIHJldHVybmVkIHN0cmluZwor ICAgIDs7IChCdWcjMjQwNTcpLgorICAgIDs7IEV4YW1wbGUgY29tbWVudHMgaW4gYGMtbW9kZScg KHdoaWNoIGNvbnNpZGVycyBsaW5lcyBiZWdpbm5pbmcKKyAgICA7OyB3aXRoICIvLyIgYXMgY29t bWVudHMpOgorICAgIDs7ICAvL3RtcCAtIFRoaXMgaXMgYSBjb21tZW50LiBJdCBkb2VzIG5vdCBj b250YWluIGFueSBwYXRoIHJlZmVyZW5jZS4KKyAgICA7OyAgLy8vdG1wIC0gVGhpcyBpcyBhIGNv bW1lbnQuIFRoZSAiL3RtcCIgcG9ydGlvbiBpbiB0aGF0IGlzIGEgcGF0aC4KKyAgICA7OyAgLy8v L3RtcCAtIFRoaXMgaXMgYSBjb21tZW50LiBUaGUgIi8vdG1wIiBwb3J0aW9uIGluIHRoYXQgaXMg YSBwYXRoLgorICAgICh3aGVuIChhbmQKKyAgICAgICAgICAgOzsgUHJvY2VlZCBpZiBubyByZWdp b24gaXMgc2VsZWN0ZWQgYnkgdGhlIHVzZXIuCisgICAgICAgICAgIChudWxsIHJlZ2lvbi1zZWxl Y3RlZCkKKyAgICAgICAgICAgOzsgQ2hlY2sgaWYgRU5EIGNoYXJhY3RlciBpcyBwYXJ0IG9mIGEg Y29tbWVudC4KKyAgICAgICAgICAgKHNhdmUtZXhjdXJzaW9uCisgICAgICAgICAgICAgKG50aCA0 IChzeW50YXgtcHBzcyBlbmQpKSkpCisgICAgICA7OyBNb3ZlIEJFRyB0byBiZWdpbm5pbmcgb2Yg Y29tbWVudCAoYWZ0ZXIgdGhlIGNvbW1lbnQgc3RhcnQKKyAgICAgIDs7IGNoYXJhY3RlcnMpLCBv ciBFTkQsIHdoaWNoZXZlciBjb21lcyBmaXJzdC4KKyAgICAgIChzYXZlLWV4Y3Vyc2lvbgorICAg ICAgICAobGV0ICgoc3RhdGUgKHN5bnRheC1wcHNzIGJlZykpKQorICAgICAgICAgIDs7IChudGgg NCAoc3ludGF4LXBwc3MpKSB3aWxsIGJlIG5pbCBmb3IgY29tbWVudCBzdGFydCBjaGFycworICAg ICAgICAgICh1bmxlc3MgKG50aCA0IHN0YXRlKQorICAgICAgICAgICAgKHBhcnNlLXBhcnRpYWwt c2V4cCBiZWcgZW5kIG5pbCBuaWwgc3RhdGUgOmNvbW1lbnRzdG9wKQorICAgICAgICAgICAgKHNl dHEgYmVnIChwb2ludCkpKSkpKQorCiAgICAgKGlmIChhbmQgKG5hdG51bXAgZmZhcC1tYXgtcmVn aW9uLWxlbmd0aCkKICAgICAgICAgICAgICAoPCByZWdpb24tbGVuIGZmYXAtbWF4LXJlZ2lvbi1s ZW5ndGgpKSA7IEJ1ZyMyNTI0My4KICAgICAgICAgKHNldGYgZmZhcC1zdHJpbmctYXQtcG9pbnQt cmVnaW9uIChsaXN0IGJlZyBlbmQpCi0tIAoyLjExLjAKCg== --f403045ccbb0dfe122054af737d7--