From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Date: Tue, 6 Oct 2015 06:20:09 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e013a14ea81ede405216cf9c1 X-Trace: ger.gmane.org 1444126886 10092 80.91.229.3 (6 Oct 2015 10:21:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Oct 2015 10:21:26 +0000 (UTC) Cc: 21619@debbugs.gnu.org To: Bruce Connor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 06 12:21:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZjPMw-0004cK-QH for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 12:21:15 +0200 Original-Received: from localhost ([::1]:50052 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjPMw-0004hy-34 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 06:21:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjPMo-0004hd-NT for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 06:21:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjPMk-0002wV-Ao for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 06:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjPMk-0002wE-7R for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 06:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZjPMj-0007BD-OP for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 06:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21619-submit@debbugs.gnu.org id=B21619.144412681327535 (code B ref 21619); Tue, 06 Oct 2015 10:21:01 +0000 Original-Received: (at 21619) by debbugs.gnu.org; 6 Oct 2015 10:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:56002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPLx-0007A2-4p for submit@debbugs.gnu.org; Tue, 06 Oct 2015 06:20:13 -0400 Original-Received: from mail-ob0-f171.google.com ([209.85.214.171]:36285) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjPLu-00079u-Ga for 21619@debbugs.gnu.org; Tue, 06 Oct 2015 06:20:11 -0400 Original-Received: by obcgx8 with SMTP id gx8so150114253obc.3 for <21619@debbugs.gnu.org>; Tue, 06 Oct 2015 03:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=UscFMYA3pc+6duYaKf/etZSugfmHclDVOnmiJ36Pnmc=; b=VUFuesqvtqj4Yk4g745Htxtvo/DRX3Ca3wc9ZYeMJXun+tsbU3EaK/aX75AbbLyqVy y9YdSDD9KK1m6+lXHBF2I0agxVaoCx2FI5+QpaifbYAqQieObIUHWUE3c3VoN0aSz0sn 8SZzBhJaPMFrlUVlP/uJfZwEw6fUo7UJT3rJ2+1xpc2OlHvGGBxsVhevETCF2VKdtbpN MmCQjIRz0hNiwF0Ffv0rFKHQf1HOft1gHe1wv1VsYSLHtF42jOFDtdgnjtXTfiy+KIVK iL3AiYM5mNCrTu4jwkZ/uefIJAthqIwkGnR5B9zPZDmkme/eiWKKV/Fg0lFEbM7FM74d AX+A== X-Received: by 10.60.36.202 with SMTP id s10mr20929484oej.0.1444126809777; Tue, 06 Oct 2015 03:20:09 -0700 (PDT) Original-Received: by 10.202.172.205 with HTTP; Tue, 6 Oct 2015 03:20:09 -0700 (PDT) Original-Received: by 10.202.172.205 with HTTP; Tue, 6 Oct 2015 03:20:09 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107363 Archived-At: --089e013a14ea81ede405216cf9c1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I copied the wrong snippet.. But in general I saw many instances of quote fixes in doc strings in that merge commit. Also I do not see curvy quotes in the Help buffer that opens when I do C-h f font-lock-add-keywords. I am on emacs built on that big merge commit yesterday. On Oct 6, 2015 5:15 AM, "Artur Malabarba" wrote= : > 2015-10-05 17:28 GMT+01:00 Kaushal Modi : > > Artur Malabarba gmail.com> writes: > > > >> > >> The docstring for this function (when displayed in a help buffer) has > >> the following code-snippet, which clearly has the wrong type of > >> quotes. > >> > >> (font-lock-add-keywords =E2=80=99c-mode > >> =E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99font-lock-warning-face prepe= nd) > >> ("\\<\\(and\\|or\\|not\\)\\>" . =E2=80=99font-lock-keyword-face))) > >> > >> Instead of fixing this by manually escaping them, how about we change > >> the algorithm to only convert `...' quotes if the ... is a single > >> symbol? > >> > >> > > > > > > Looks like it got fixed in this commit: > > > > http://git.savannah.gnu.org/cgit/emacs.git/commit/? > > id=3D47e9556c70a7009d7c750fd7bf10a0e6cf41cdce > > > > > > - (sql-add-product-keywords 'ms > > - '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) > > + (sql-add-product-keywords \\=3D'ms > > + \\=3D'((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face))) > > I'm confused. That link appears to be a merge commit, and the snippet > you quote doesn't apply to the snippet I had quotedl. > --089e013a14ea81ede405216cf9c1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

I copied the wrong snippet.. But in general I saw many insta= nces of quote fixes in doc strings in that merge commit.

Also I do not see curvy quotes in the Help buffer that opens= when I do C-h f font-lock-add-keywords. I am on emacs built on that big me= rge commit yesterday.

On Oct 6, 2015 5:15 AM, "Artur Malabarba&qu= ot; <bruce.connor.am@gmail.= com> wrote:
2= 015-10-05 17:28 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
> Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
>
>>
>> The docstring for this function (when displayed in a help buffer) = has
>> the following code-snippet, which clearly has the wrong type of >> quotes.
>>
>> (font-lock-add-keywords =E2=80=99c-mode
>>=C2=A0 =C2=A0=E2=80=99(("\\<\\(FIXME\\):" 1 =E2=80=99f= ont-lock-warning-face prepend)
>>=C2=A0 =C2=A0 =C2=A0("\\<\\(and\\|or\\|not\\)\\>" .= =E2=80=99font-lock-keyword-face)))
>>
>> Instead of fixing this by manually escaping them, how about we cha= nge
>> the algorithm to only convert `...' quotes if the ... is a sin= gle
>> symbol?
>>
>>
>
>
> Looks like it got fixed in this commit:
>
> http://git.savannah.gnu.org/cgit/emacs.git/co= mmit/?
> id=3D47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
>
>
> - (sql-add-product-keywords 'ms
> -=C2=A0 '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)= ))
> + (sql-add-product-keywords \\=3D'ms
> +=C2=A0 \\=3D'((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-= face)))

I'm confused. That link appears to be a merge commit, and the snippet you quote doesn't apply to the snippet I had quotedl.
--089e013a14ea81ede405216cf9c1--