all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: warren ferguson <gobold1y@hotmail.com>, 21492-done@debbugs.gnu.org
Subject: bug#21492: 25.0.50: Make untabify work nicely with write-file-functions
Date: Wed, 16 Sep 2015 22:54:56 -0400	[thread overview]
Message-ID: <CAFyQvY368UCjfx=vb8d0UhJLMiLhdgSZ4G0qT-kW9MrD01ByWA@mail.gmail.com> (raw)
In-Reply-To: <jwvh9mt6cdx.fsf-monnier+emacsbugs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

Thanks.

Yes, I had then ended up replacing all my write-file-functions add-hooks
with before-save-hook:
https://github.com/kaushalmodi/.emacs.d/commit/d89d6333f0978d7fda4af412ecaa5089812b7e26

--
Kaushal Modi
On Sep 16, 2015 9:54 PM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:

> > I also have now started using before-save-hook instead of
> > write-file-functions where I don't care about the return values of the
> > functions added to the hook.
>
> BTW, the use of before-save-hook is not just so you don't have to care
> about the return value.  It's also because some functions on
> write-file-functions may not be run at all (if some earlier function
> returns non-nil because it took care of performing the write).
>
> So even adding a "nil" at the of your function doesn't make it right to
> add it to write-file-functions.
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 1347 bytes --]

      reply	other threads:[~2015-09-17  2:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  3:35 bug#21492: 25.0.50: Make untabify work nicely with write-file-functions Kaushal Modi
2015-09-16  8:24 ` Glenn Morris
2015-09-16 12:55   ` Kaushal Modi
2015-09-16 13:13     ` Kaushal Modi
2015-09-16 13:14 ` Stefan Monnier
2015-09-16 15:54   ` Kaushal Modi
2015-09-17  1:54     ` Stefan Monnier
2015-09-17  2:54       ` Kaushal Modi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY368UCjfx=vb8d0UhJLMiLhdgSZ4G0qT-kW9MrD01ByWA@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=21492-done@debbugs.gnu.org \
    --cc=gobold1y@hotmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.