From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Remove unused variable `command-debug-status' Date: Wed, 28 Sep 2016 14:30:47 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c12453eb37708053d923502 X-Trace: blaine.gmane.org 1475073115 27331 195.159.176.226 (28 Sep 2016 14:31:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Sep 2016 14:31:55 +0000 (UTC) Cc: Eli Zaretskii , Emacs developers To: Philippe Vaucher Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 28 16:31:50 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpFtj-00065h-3M for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2016 16:31:47 +0200 Original-Received: from localhost ([::1]:59248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpFth-0007L3-IH for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2016 10:31:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpFt3-0007Kg-LS for emacs-devel@gnu.org; Wed, 28 Sep 2016 10:31:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpFsx-00039J-Pv for emacs-devel@gnu.org; Wed, 28 Sep 2016 10:31:04 -0400 Original-Received: from mail-ua0-x22d.google.com ([2607:f8b0:400c:c08::22d]:36039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpFsx-000399-Ju; Wed, 28 Sep 2016 10:30:59 -0400 Original-Received: by mail-ua0-x22d.google.com with SMTP id n13so39205977uaa.3; Wed, 28 Sep 2016 07:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jMnVt+sb2tv2TUrYN+rUvb4IMA6KFABmwxNc1REDBl8=; b=m+diBCotnz1Jg5IOiOfm0EtCoNtO4qqJ5K9wyJDwrYr47HIgyWCK2dJk8C7J9W43Gs aVQele54M0wYTrGQ0/fv1Xh7BwRr8uIig4A0e4Jzy+521qgkpFVB1c+XtHABpgk4lBii QYBQWnxzC3zCbmkrwNmX6ZC0HVFg7mFnUeQE+Y3M8jt1r418S1hTU1qlJBlztLuvYtrH Qmxg2JwjnliqL8CezX4B10IBEe1wjBoLtO2gghXyMdSUH8i5b1VNxIQ6kHCvNt1WPZfc MbQuERkkXLICF+hFVA96R6N6SlifvkBYXJ0UTDUlWmQ7A8DtdBF9IyuX+iA6MQahEKr9 acSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jMnVt+sb2tv2TUrYN+rUvb4IMA6KFABmwxNc1REDBl8=; b=X/cXNWeHNH+s8HSN9fLuK6/iVRB9VOA2cqCj9KnqxuNnQ6Uz8Ww9F13tLsnuE7PkdW Om1hr1y/WleKv4hvS4rtHKw1cUErnOQQwtpMqJNXX4ANGj4M1SmlBdAeroofu45ov6sb bA1FcuocwpuYpdoYT0s0aoLWYJ0Oi2Sqjmjjm5v5NGfZcPq5XiNe3a4tgg/W24L+xzs2 IXJG+m4S8wTdiGuVji/4wNRqBgpT/fY19X+PvcS5h0PtX1QRcQqoNSVlCfXLjWglsHrX DlVINaYl2egzuhyEgt8iKgjihqV4ErSTR4oZ6imLbge7zRGKosIt0TV6wnFjLymO8oya 054Q== X-Gm-Message-State: AA6/9RkoKLItceCHjiJQXHIS+TKH/sylKoCKebI6LLF8/yzszj+pfnrRFw9H3s3hpOKXNPd77f/Qw3vXnzU+sg== X-Received: by 10.159.39.41 with SMTP id a38mr5806763uaa.145.1475073059024; Wed, 28 Sep 2016 07:30:59 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c08::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207859 Archived-At: --94eb2c12453eb37708053d923502 Content-Type: text/plain; charset=UTF-8 On Wed, Sep 28, 2016 at 7:25 AM Philippe Vaucher wrote: > Well, I had to do copyright assignements for ztree, but that was on github > (https://github.com/fourier/ztree/pull/33). > If the copyright assignment was to FSF, then someone having a fencepost account can confirm if you are on the list. I cannot. Oh, I did that in the past but I thought that was meant for general bug > reporting. > Based on some recent discussions, the bug report email is meant for everything: bug reports, feature requests, patch submissions, etc > Do messages sent to bug-gnu-emacs@gnu.org also end on emacs-devel? > No. Those end up on the bug-gnu-emacs mailing list. I believe almost all core developers subscribe to that. Normally, when I submit a patch, I CC one or two people whose code I am modifying. (The new vc-region-history command in emacs 25.1 is really useful for that.) If you do not get a feedback in about a week or so, it might be useful copying emacs-devel mailing list and referring them to the bug thread to see if anyone can review and commit it for you. > For information, messages like > https://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00635.html > don't seem to follow this "patches as bug reports" philosophy. > Yeah, the patch submitter needs to ping emacs-devel if they don't get any response to their update. > Anyway, I found on > https://www.kernel.org/doc/Documentation/email-clients.txt that GMail's > UI is not good to send inline patches, so I'll send them to > bug-gnu-emacs@gnu.org as attachment instead (that or setup another > client). > I have always sent patches via Google Inbox. They ended up fine. The only instance where I had to send a patch as an attachment was when it contained both tab and space characters (I was trying to not mess up the original whitespace). In such cases, you need to send the patch as an attachment. Nowadays, with recent commits you will rarely find the tab chars in the patch diffs (which is a good thing!). So inline patches work just fine. For reading sanity, I always send emails via Gmail/Inbox without any rich text formatting. -- Kaushal Modi --94eb2c12453eb37708053d923502 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Sep 28= , 2016 at 7:25 AM Philippe Vaucher <philippe.vaucher@gmail.com> wrote:
Well, I had to do copyright assignements for ztree, but that= was on github (https://github.com/fourier/ztree/pull/33).

If the copyright assignment was to= FSF, then someone having a fencepost account can confirm if you are on the= list. I cannot.

Oh, I = did that in the past but I thought that was meant for general bug reporting= .

Based on some re= cent discussions, the bug report email is meant for everything: bug reports= , feature requests, patch submissions, etc
=C2=A0
Do messages sent to bug-gnu-emacs@gnu.org also end on emacs-devel= ?

No. Those end up= on the bug-gnu-emacs mailing list. I believe almost all core developers su= bscribe to that. Normally, when I submit a patch, I CC one or two people wh= ose code I am modifying. (The new vc-region-history command in emacs 25.1 i= s really useful for that.) If you do not get a feedback in about a week or = so, it might be useful copying emacs-devel mailing list and referring them = to the bug thread to see if anyone can review and commit it for you.
<= div>=C2=A0
For information, messages = like https://lists.gnu.org/archive/html/emacs-devel= /2016-09/msg00635.html don't seem to follow this "patches as b= ug reports" philosophy.

<= /div>
Yeah, the patch submitter needs to ping emacs-devel if they don&#= 39;t get any response to their update.
=C2=A0
Anyway, I found on=C2=A0https://www.kernel.= org/doc/Documentation/email-clients.txt that GMail's UI is not good= to send inline patches, so I'll send them to bug-gnu-emacs@gnu.org as attachment i= nstead (that or setup another client).
=

I have always sent patches via Google Inbox. They ended= up fine. The only instance where I had to send a patch as an attachment wa= s when it contained both tab and space characters (I was trying to not mess= up the original whitespace). In such cases, you need to send the patch as = an attachment. Nowadays, with recent commits you will rarely find the tab c= hars in the patch diffs (which is a good thing!). So inline patches work ju= st fine.

For reading sanity, I always send emails = via Gmail/Inbox without any rich text formatting.
--

Kaushal Modi

--94eb2c12453eb37708053d923502--