From: Kaushal Modi <kaushal.modi@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Help Gnu Emacs mailing list <help-gnu-emacs@gnu.org>
Subject: Re: A way for interactive to modify a let-bound variable?
Date: Fri, 12 Feb 2016 13:18:02 -0500 [thread overview]
Message-ID: <CAFyQvY2t6oBJbYAg3Qo_wyTmpH2jW_5ouVxPDsDQat1Pc9Ht7A@mail.gmail.com> (raw)
In-Reply-To: <87a8n57ss1.fsf@web.de>
This is the actual function I want to optimize (Reference:
http://thread.gmane.org/gmane.emacs.help/109025/focus=109137 ).
(defun modi/advice-region-or-whole (orig-fun &rest args)
(interactive (if (use-region-p)
(list (region-beginning) (region-end))
(list (point-min) (point-max))))
(prog1
(apply orig-fun args) ; this defun NEEDS to return this form's value
(when (and (called-interactively-p 'interactive) ; duplication of
condition
(not (use-region-p))) ;
(message "Executed %s on the whole buffer."
(propertize (symbol-name this-command)
'face 'font-lock-function-name-face)))))
This is an :around advice function and it needs to return the (apply
orig-fun args) value.
> You can of course use `let' _inside_ `interactive'
If I move the let form inside interactive, the let form needs to return the
list required for interactive. Then how would I return the (apply ..) value?
Eventually I want something like below that actually works:
(defun modi/advice-region-or-whole (orig-fun &rest args)
(let (msg)
(interactive (if (use-region-p)
(list (region-beginning) (region-end))
(setq msg (format "Executed %s on the whole buffer."
(propertize (symbol-name this-command)
'face
'font-lock-function-name-face)))
(list (point-min) (point-max))))
(prog1
(apply orig-fun args)
(when msg
(message msg)))))
next prev parent reply other threads:[~2016-02-12 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 16:41 A way for interactive to modify a let-bound variable? Kaushal Modi
2016-02-12 16:57 ` Drew Adams
2016-02-12 17:17 ` Michael Heerdegen
2016-02-12 18:18 ` Kaushal Modi [this message]
2016-02-12 18:38 ` Michael Heerdegen
2016-02-12 18:49 ` Kaushal Modi
2016-02-12 19:12 ` Michael Heerdegen
2016-02-12 19:20 ` Kaushal Modi
2016-02-12 19:30 ` Marcin Borkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY2t6oBJbYAg3Qo_wyTmpH2jW_5ouVxPDsDQat1Pc9Ht7A@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.