From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history Date: Thu, 28 Sep 2017 17:22:04 +0000 Message-ID: References: <83h8vxfobt.fsf@gnu.org> <6ab17adb-c05e-628d-6b53-666c8bf26a75@yandex.ru> <83o9q4dshj.fsf@gnu.org> <75512192-de23-07dd-2492-ec8ec0888161@yandex.ru> <1506597095.2715104.1121128328.5F777197@webmail.messagingengine.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c06a38658dd71055a43261a" X-Trace: blaine.gmane.org 1506619351 18874 195.159.176.226 (28 Sep 2017 17:22:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 28 Sep 2017 17:22:31 +0000 (UTC) To: jostein@kjonigsen.net, Emacs developers , Eli Zaretskii , John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 28 19:22:25 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxcVx-0004Fq-Jx for ged-emacs-devel@m.gmane.org; Thu, 28 Sep 2017 19:22:21 +0200 Original-Received: from localhost ([::1]:60157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxcW5-00027R-2q for ged-emacs-devel@m.gmane.org; Thu, 28 Sep 2017 13:22:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxcVv-00025s-UF for emacs-devel@gnu.org; Thu, 28 Sep 2017 13:22:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxcVu-00007q-Sz for emacs-devel@gnu.org; Thu, 28 Sep 2017 13:22:19 -0400 Original-Received: from mail-yw0-x22d.google.com ([2607:f8b0:4002:c05::22d]:48904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxcVu-000075-N0; Thu, 28 Sep 2017 13:22:18 -0400 Original-Received: by mail-yw0-x22d.google.com with SMTP id u205so1503543ywa.5; Thu, 28 Sep 2017 10:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=pMvfBRXO/QWR1U7zPWA2BgLYRobKvZMIetKO0CuCGlw=; b=szFa8WIWTOGlcu9JC+bUXvlDKXF7wqBzeIjlkiewwwqIGJdMPEV1vmCUMoeCEhu+dg KRu9r+P/SG4Kx0UlXCzFyxV4U/i1XkW6IFTvDoc+mgcJRvdK3iiFPEqIOpmfz+WPQzNa 7A3dFWaVgpSX7SqSU0D9qJwh0MBI0LUqfqGZofJkSKDHP6Pv35fuh+enViYAYmBCynh5 n/bYOtW4RJBQhWlt1Ee4+X+KCrHzwMrAVueXs+8oOIy0/nTxBwiBKblyeKfQS0knkjZ8 /qQt9G6hzKqu9hTEOF7e8Bn8Ocsbhs2vnQLcAPuNLt5FURroH1BDrF/mdKKuNSjSheqO l+Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=pMvfBRXO/QWR1U7zPWA2BgLYRobKvZMIetKO0CuCGlw=; b=rzKoeo4xJZWZHXilALbSlgVqlekOBrO956q3kzKk9mSzZ/I+Yp1UGnMvQe3YCePyAH mUgNfMt/yyKI174JwWDkesJUUYEkzlRIdyYiwvsKPFRp1G4o6vPCFq5svvDkzeSVZS1v jCBRAx9kvD/kHujxwenfzfMdHcIvI+rk29jy4UB5gxIsLSosMTPdjM40Ld7K9im8/TaN 1ZZvY0KwtfwU+eOoNJhomVGDtGjqWnqnaOZLVHZbPXBSourmXpKLmio811BKwplmB/yl Yrv1rUbjxGd+VBhaCNFbP0TvS2uvyG61YlsVguENqe5MbIhULxWI6oj4Ha7iydn3NbEJ lmkA== X-Gm-Message-State: AHPjjUhG4QEIvrDbNw/KE39iU325/b01TgS0PFY/YMkCa51MXu9clY/e /LpNRyFN1VcGFXti4rU43MOAtVlzUFcFewM9ln0= X-Google-Smtp-Source: AOwi7QAOVLEZEaBHeaM40Ze+cvmjvOXE002jG8q2RyD0vxUtEcgihmoA0uqbM5DQVCriWxZxq9CslwtQvITy1TorAr0= X-Received: by 10.13.253.196 with SMTP id n187mr4078534ywf.523.1506619336218; Thu, 28 Sep 2017 10:22:16 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4002:c05::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218853 Archived-At: --94eb2c06a38658dd71055a43261a Content-Type: text/plain; charset="UTF-8" On Thu, Sep 28, 2017 at 12:59 PM John Wiegley wrote: > Isn't C-x v h already `vc-insert-headers'? > Hi John, As mentioned earlier in the thread, Stefan suggested this binding as he never found the default binding useful[1], Dmitry corroborated that[2], I have never found the default useful. Later Clement and Jostein also chimed in a +1[3, 4]. So far there has been no opposition to binding C-x v h with vc-region-history. I am basically proposing to bind the super-useful vc-region-history to "something" in "C-x v" map. I offered C-x v H. But based on the above discussion C-x v h makes more sense. I would be great to get a clear "yes" or "no" as this issue seems to have lingered too long. I'd put this very concisely as: (let ((res (binding--vc-region-history--resolution))) (cond ((string= "yes, C-x v h" res) "best option") ((string= "yes, C-x v H" res) "good option") ((string= "no, don't bind vc-region-history" res) "bad option, but I'll accept") (t (error "invalid")))) [1]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00772.html [2]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00786.html [3]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00823.html [4]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00950.html -- Kaushal Modi --94eb2c06a38658dd71055a43261a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Sep 28= , 2017 at 12:59 PM John Wiegley <j= wiegley@gmail.com> wrote:
Is= n't C-x v h already `vc-insert-headers'?

<= /div>
Hi John,=C2=A0

As mentioned earlier in t= he thread, Stefan suggested this binding as he never found the default bind= ing useful[1], Dmitry corroborated that[2], I have never found the default = useful. Later Clement and Jostein also chimed in a=C2=A0+1[3, 4].

So far there has been no opposition to binding C-x v h with= vc-region-history.=C2=A0

I am basically proposing= to bind the super-useful vc-region-history to "something" in &qu= ot;C-x v" map. I offered C-x v H. But based on the above discussion C-= x v h makes more sense.

I would be great to get a = clear "yes" or "no" as this issue seems to have lingere= d too long.

I'd put this very concisely as:

(let ((res (binding--vc-region-history--resolut= ion)))
=C2=A0 (cond ((string=3D "yes, C-x v h" res)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"best option")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((string=3D "yes, C-x v H" res)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"good option")
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((string=3D "no, don't bind vc-region-= history" res)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"bad op= tion, but I'll accept")
--

Kaushal Modi

--94eb2c06a38658dd71055a43261a--