From: Kaushal Modi <kaushal.modi@gmail.com>
To: jostein@kjonigsen.net, Emacs developers <emacs-devel@gnu.org>,
Eli Zaretskii <eliz@gnu.org>, John Wiegley <johnw@gnu.org>
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 28 Sep 2017 17:22:04 +0000 [thread overview]
Message-ID: <CAFyQvY2jArXL5sVca+kAJ-U5OLbtZMABnZ_b_yZ6QDPmarapiQ@mail.gmail.com> (raw)
In-Reply-To: <m2r2uqrc7x.fsf@newartisans.com>
[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]
On Thu, Sep 28, 2017 at 12:59 PM John Wiegley <jwiegley@gmail.com> wrote:
> Isn't C-x v h already `vc-insert-headers'?
>
Hi John,
As mentioned earlier in the thread, Stefan suggested this binding as he
never found the default binding useful[1], Dmitry corroborated that[2], I
have never found the default useful. Later Clement and Jostein also chimed
in a +1[3, 4].
So far there has been no opposition to binding C-x v h with
vc-region-history.
I am basically proposing to bind the super-useful vc-region-history to
"something" in "C-x v" map. I offered C-x v H. But based on the above
discussion C-x v h makes more sense.
I would be great to get a clear "yes" or "no" as this issue seems to have
lingered too long.
I'd put this very concisely as:
(let ((res (binding--vc-region-history--resolution)))
(cond ((string= "yes, C-x v h" res)
"best option")
((string= "yes, C-x v H" res)
"good option")
((string= "no, don't bind vc-region-history" res)
"bad option, but I'll accept")
(t
(error "invalid"))))
[1]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00772.html
[2]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00786.html
[3]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00823.html
[4]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00950.html
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 2575 bytes --]
next prev parent reply other threads:[~2017-09-28 17:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 18:43 bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history Kaushal Modi
2017-09-20 14:03 ` Kaushal Modi
2017-09-20 14:15 ` Eli Zaretskii
2017-09-21 3:01 ` Kaushal Modi
2017-09-28 18:23 ` Kaushal Modi
2017-09-29 11:54 ` Dmitry Gutov
2017-09-29 11:59 ` Kaushal Modi
2017-09-29 16:43 ` Kaushal Modi
2017-09-29 17:31 ` John Wiegley
2017-09-29 17:22 ` Eli Zaretskii
2017-09-29 17:39 ` Stefan Monnier
2017-09-29 18:16 ` Eli Zaretskii
2017-09-29 18:32 ` Kaushal Modi
2017-09-30 14:03 ` Dmitry Gutov
2017-09-30 14:12 ` Kaushal Modi
2017-09-21 14:22 ` Dmitry Gutov
2017-09-21 14:41 ` Eli Zaretskii
2017-09-21 15:29 ` Dmitry Gutov
2017-09-21 20:39 ` Kaushal Modi
2017-09-22 3:15 ` Stefan Monnier
2017-09-22 13:51 ` Dmitry Gutov
2017-09-22 14:06 ` Kaushal Modi
2017-09-22 14:03 ` Kaushal Modi
2017-09-23 8:06 ` Clément Pit-Claudel
2017-09-28 11:11 ` Jostein Kjønigsen
2017-09-28 11:19 ` Kaushal Modi
2017-09-28 16:59 ` John Wiegley
2017-09-28 17:22 ` Kaushal Modi [this message]
2017-09-28 17:24 ` John Wiegley
2017-09-28 18:26 ` Kaushal Modi
2017-09-28 19:59 ` Stefan Monnier
2017-09-28 19:55 ` Stefan Monnier
2017-09-29 9:37 ` Robert Pluim
2017-09-29 19:50 ` Paul Eggert
2017-09-29 19:55 ` Kaushal Modi
2017-09-28 21:11 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY2jArXL5sVca+kAJ-U5OLbtZMABnZ_b_yZ6QDPmarapiQ@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=johnw@gnu.org \
--cc=jostein@kjonigsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.