From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#19717: 24.4.50; printing.el still uses ps-eval-switch Date: Thu, 12 May 2016 01:42:05 +0000 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114630f4a2098b05329b440e X-Trace: ger.gmane.org 1463017401 9251 80.91.229.3 (12 May 2016 01:43:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 May 2016 01:43:21 +0000 (UTC) Cc: jorge.alfaro-murillo@yale.edu, 19717@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 12 03:43:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b0feh-0000Bi-FZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 May 2016 03:43:11 +0200 Original-Received: from localhost ([::1]:54990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0feg-0003lY-Tz for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2016 21:43:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0feb-0003gh-Pg for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 21:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0feY-0001vf-GT for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 21:43:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0feY-0001vZ-CC for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 21:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b0feY-0006cR-4a for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 21:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 May 2016 01:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19717 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19717-submit@debbugs.gnu.org id=B19717.146301734425400 (code B ref 19717); Thu, 12 May 2016 01:43:02 +0000 Original-Received: (at 19717) by debbugs.gnu.org; 12 May 2016 01:42:24 +0000 Original-Received: from localhost ([127.0.0.1]:47905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0fdv-0006bb-Ns for submit@debbugs.gnu.org; Wed, 11 May 2016 21:42:23 -0400 Original-Received: from mail-oi0-f47.google.com ([209.85.218.47]:33824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0fdu-0006bM-31 for 19717@debbugs.gnu.org; Wed, 11 May 2016 21:42:22 -0400 Original-Received: by mail-oi0-f47.google.com with SMTP id k142so97381010oib.1 for <19717@debbugs.gnu.org>; Wed, 11 May 2016 18:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sm2P2MRTBw/17P3pIFPVpVhTR2JzPds0ouaK9DDZuUc=; b=gFcL3/mWSy4w3qMkx+x9cQ8w502skyzfTruN4T95xSWbnxOvWPQRbblleeBqzLkQOr 1I1KOqkYV48ljRV2G3wHfppO9vqRgPQpr1f5KbCyl/xORVc9zmf9rF02ML6gt7/ZUH9x WU8WtuUkbE66jYGMF62QD87EJGFgeQKu0g25d/N7J9BVU9Y2pf/CatKgNzksZ4ZFpKzQ /8Ik2t/ApxPLSA8dUug5w6zzK7+UHljlQR1kjTNvK4Z3IpIC9ZOkdu/Hix/ezW4cjmRP b9XZ3dZ84+vAMtX0BUVUkimvcgz/aW2sAroO2ftP5wR/p61eIaa7ceCQbUDxJYgdv7TI wxCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sm2P2MRTBw/17P3pIFPVpVhTR2JzPds0ouaK9DDZuUc=; b=fKvHYeliZQbjX1Zo67ccytWc0SyFWnRvTwhdiTQD19ssRCQTUOm3vIhsp/lbewd89t kWqoiU2SpPtzZHG93bm9uwLWW5BGp29d20mMdvczamUGdhDEcn5mGkU1jJq7RIkRZf/8 wEACXp1kx68vgHJoF2GLlwqjxuznxkTwvmgtyeJm1aYkvhVi1ehraG1Y02Jf5yTZsmCD 6hObLjx+ChsXhzqqORslB4oYcNcBM4AAFflEyoYfEMC0dNq1a4eGywQdBS4g57dtjUMK T4j+pGdmpOicBudDnN/NQGQYtLVDCR2CerOKE2cTie+cjMuJpLHurWOG0CUeanVOOq+9 b09g== X-Gm-Message-State: AOPr4FXMrvWmXHdrwnzMTEtbYO56d50zIBklLjvr7MakTBbgo/m1kiRz+olH1oOnE/BQ30jJoofoAy1l+qUyoA== X-Received: by 10.157.20.170 with SMTP id d39mr2242197ote.164.1463017336330; Wed, 11 May 2016 18:42:16 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118151 Archived-At: --001a114630f4a2098b05329b440e Content-Type: text/plain; charset=UTF-8 On Wed, May 11, 2016 at 8:56 PM Stefan Monnier wrote: > Fine by me, tho I'd recommend #' rather than ' > Sure, here's the updated patch with #' after rebasing to emacs-25 branch. Thanks! >From 495655b3be76023299d5f9b623f5961314be3244 Mon Sep 17 00:00:00 2001 From: Kaushal Modi Date: Wed, 11 May 2016 21:37:43 -0400 Subject: [PATCH] Fix reference to obsolete fn ps-eval-switch The `lpr-eval-switch' is functionally the same as `ps-eval-switch' which was obsoleted in 2cdeb903c57126d3ad5f0cbd72e182584b76ee29. So using that instead (Bug#19717). * printing.el (pr-switches): Use lpr-eval-switch instead of ps-eval-switch. --- lisp/printing.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/printing.el b/lisp/printing.el index 3bd5a67..d9cc2a3 100644 --- a/lisp/printing.el +++ b/lisp/printing.el @@ -5673,7 +5673,7 @@ pr-switches (or (listp switches) (error "%S should have a list of strings" mess)) (lpr-flatten-list ; dynamic evaluation - (mapcar 'ps-eval-switch switches))) + (mapcar #'lpr-eval-switch switches))) (defun pr-ps-preview (kind n-up filename mess) -- 2.6.0.rc0.24.gec371ff -- -- Kaushal Modi --001a114630f4a2098b05329b440e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, May 11= , 2016 at 8:56 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
Fine by me, tho I'd recommend #' rather than '
=

Sure, here's the updated patch with #' after re= basing to emacs-25 branch. Thanks!

From 49565= 5b3be76023299d5f9b623f5961314be3244 Mon Sep 17 00:00:00 2001
From= : Kaushal Modi <kaushal.modi@g= mail.com>
Date: Wed, 11 May 2016 21:37:43 -0400
= Subject: [PATCH] Fix reference to obsolete fn ps-eval-switch

=
The `lpr-eval-switch' is functionally the same as `ps-eval-s= witch' which
was obsoleted in 2cdeb903c57126d3ad5f0cbd72e1825= 84b76ee29.=C2=A0 So using
that instead (Bug#19717).
* printing.el (pr-switches): Use lpr-eval-switch instead of ps-= eval-switch.
---
=C2=A0lisp/printing.el | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

<= div>diff --git a/lisp/printing.el b/lisp/printing.el
index 3bd5a6= 7..d9cc2a3 100644
--- a/lisp/printing.el
+++ b/lisp/pri= nting.el
@@ -5673,7 +5673,7 @@ pr-switches
=C2=A0 =C2= =A0(or (listp switches)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(error "%= S should have a list of strings" mess))
=C2=A0 =C2=A0(lpr-fl= atten-list ; dynamic evaluation
- =C2=A0 (mapcar 'ps-eval-switch switc= hes)))
+ =C2=A0 (mapcar #'lpr-eval-switch switches)))
=C2=A0
=C2=A0
=C2=A0(defun pr-ps-preview (kind n-up = filename mess)
--=C2=A0
2.6.0.rc0.24.gec371ff

--

-= -
Kaushal Modi

--001a114630f4a2098b05329b440e--